)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0d5c2accd81c6c6bcd45ff12196f05c1bbea8c63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6643446_b96e6ea3","updated":"2026-06-24 12:11:12.000000000","message":"In general it LGTM, but I shared 2 suggestions inline. CR-1 for visibility","commit_id":"263b90d6740e01d09428ca6f5a12204bd1a09490"}],"designate_tempest_plugin/tests/scenario/v2/test_recordsets.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0d5c2accd81c6c6bcd45ff12196f05c1bbea8c63","unresolved":true,"context_lines":[{"line_number":254,"context_line":"                    recordset_name, rdatatype\u003drecordset_data[\u0027type\u0027])"},{"line_number":255,"context_line":"                if not update_indicator:"},{"line_number":256,"context_line":"                    if all(rec in str(ns_record) for rec in updated_records):"},{"line_number":257,"context_line":"                        return"},{"line_number":258,"context_line":"                if update_indicator:"},{"line_number":259,"context_line":"                    if update_indicator in str(ns_record):"},{"line_number":260,"context_line":"                        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"16adc622_cbc3cea1","line":257,"range":{"start_line":257,"start_character":24,"end_line":257,"end_character":30},"updated":"2026-06-24 12:11:12.000000000","message":"Maybe we could switch this \"return\" to \"break\", also on line #260:\nWhen the updated records are detected on the first nameserver, return exits the entire method, skipping remaining nameservers. Since the test is named propagated_to_backends (plural), it should verify all nameservers.","commit_id":"263b90d6740e01d09428ca6f5a12204bd1a09490"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0d5c2accd81c6c6bcd45ff12196f05c1bbea8c63","unresolved":true,"context_lines":[{"line_number":255,"context_line":"                if not update_indicator:"},{"line_number":256,"context_line":"                    if all(rec in str(ns_record) for rec in updated_records):"},{"line_number":257,"context_line":"                        return"},{"line_number":258,"context_line":"                if update_indicator:"},{"line_number":259,"context_line":"                    if update_indicator in str(ns_record):"},{"line_number":260,"context_line":"                        return"},{"line_number":261,"context_line":"                if time.time() - start \u003e\u003d config.CONF.dns.build_timeout:"},{"line_number":262,"context_line":"                    raise lib_exc.TimeoutException("}],"source_content_type":"text/x-python","patch_set":1,"id":"c3343ca3_ba0fb395","line":259,"range":{"start_line":258,"start_character":16,"end_line":259,"end_character":22},"updated":"2026-06-24 12:11:12.000000000","message":"nit: we could replace this nested if with elif","commit_id":"263b90d6740e01d09428ca6f5a12204bd1a09490"}]}
