)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"65d57311c32c7e208d56afc6472bb1f6f8ce10b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"afc8e4c3_e7f2373a","updated":"2026-04-06 23:51:10.000000000","message":"recheck","commit_id":"bf5953f0e3a11a5a6bbbccabdd6d927cab4d470c"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"292e38f730d7db9edae9443ca1e7e2c109593860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f0c5f146_dfbdf66c","updated":"2026-05-07 13:19:23.000000000","message":"recheck","commit_id":"0f36e83f4342bd76397187b15bb9fbbb0c0cd072"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"444784bb_aee71fc5","updated":"2026-05-11 11:27:44.000000000","message":"A few comments inline","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7f33904e12b3f6dd78b8d03b39d8d95f3c2abba9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1c344d20_241b00ed","updated":"2026-05-13 07:53:44.000000000","message":"LGTM, thanks for working on this patch, Mikhail!","commit_id":"f774f5b830736fcd77c7a5dcbfb08bb1ee87081c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3445d4ee333c9f8b037f2508417d3aa67f8e7df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b72d37c8_70a71b11","updated":"2026-05-26 09:18:09.000000000","message":"LGTM, we\u0027ve just approved the Designate patch, let\u0027s merge this one as well","commit_id":"adfcff663cb1281606c73b2f1fd7f95629bfa91f"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"de8081d3b773c7820367797e40f4d4c7fc68d021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b2a45a77_a6ae2380","updated":"2026-05-25 10:31:38.000000000","message":"recheck","commit_id":"adfcff663cb1281606c73b2f1fd7f95629bfa91f"}],"designate_tempest_plugin/tests/api/v2/test_recordset.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":true,"context_lines":[{"line_number":887,"context_line":"        )"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":890,"context_line":"    def test_create_TLSA_normalization_and_spaces(self):"},{"line_number":891,"context_line":"        if not versionutils.is_compatible(\u00272.3\u0027, self.api_version,"},{"line_number":892,"context_line":"                                          same_major\u003dFalse):"},{"line_number":893,"context_line":"            raise self.skipException("}],"source_content_type":"text/x-python","patch_set":11,"id":"1ceaa6d6_7a78ed15","line":890,"range":{"start_line":890,"start_character":8,"end_line":890,"end_character":49},"updated":"2026-05-11 11:27:44.000000000","message":"The test name and comment (# Spaces stripped, hex lowercased) are misleading. The Designate API does not normalize record.data — it stores and returns the raw input for all record types. The assertion value happens to be correct, but I think we should rename the test and drop the normalization comment.","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"7344f847769ee96356ee36d1ed3f69f16e36502b","unresolved":true,"context_lines":[{"line_number":887,"context_line":"        )"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":890,"context_line":"    def test_create_TLSA_normalization_and_spaces(self):"},{"line_number":891,"context_line":"        if not versionutils.is_compatible(\u00272.3\u0027, self.api_version,"},{"line_number":892,"context_line":"                                          same_major\u003dFalse):"},{"line_number":893,"context_line":"            raise self.skipException("}],"source_content_type":"text/x-python","patch_set":11,"id":"24eb2584_333d95d9","line":890,"range":{"start_line":890,"start_character":8,"end_line":890,"end_character":49},"in_reply_to":"1ceaa6d6_7a78ed15","updated":"2026-05-11 15:58:27.000000000","message":"Renamed","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        )"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":890,"context_line":"    def test_create_TLSA_normalization_and_spaces(self):"},{"line_number":891,"context_line":"        if not versionutils.is_compatible(\u00272.3\u0027, self.api_version,"},{"line_number":892,"context_line":"                                          same_major\u003dFalse):"},{"line_number":893,"context_line":"            raise self.skipException("}],"source_content_type":"text/x-python","patch_set":11,"id":"eeeb9abc_01b9874b","line":890,"range":{"start_line":890,"start_character":8,"end_line":890,"end_character":49},"in_reply_to":"24eb2584_333d95d9","updated":"2026-05-12 08:21:03.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":true,"context_lines":[{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":890,"context_line":"    def test_create_TLSA_normalization_and_spaces(self):"},{"line_number":891,"context_line":"        if not versionutils.is_compatible(\u00272.3\u0027, self.api_version,"},{"line_number":892,"context_line":"                                          same_major\u003dFalse):"},{"line_number":893,"context_line":"            raise self.skipException("},{"line_number":894,"context_line":"                \u0027TLSA record tests require\u0027"},{"line_number":895,"context_line":"                \u0027 Designate API version 2.3 or newer.\u0027)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        recordset_data \u003d {"},{"line_number":898,"context_line":"            \u0027name\u0027: \"_445._tcp.\" + self.zone[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"6d7efa33_f687733b","line":895,"range":{"start_line":891,"start_character":8,"end_line":895,"end_character":55},"updated":"2026-05-11 11:27:44.000000000","message":"You have put this skip check into _skip_if_tlsa_not_supported in the other file, so I would either use it here as well, or use what we have here in the other file. Also, we have inconsistent skip messages — four different formulations across the 9 occurrences","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"7344f847769ee96356ee36d1ed3f69f16e36502b","unresolved":true,"context_lines":[{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":890,"context_line":"    def test_create_TLSA_normalization_and_spaces(self):"},{"line_number":891,"context_line":"        if not versionutils.is_compatible(\u00272.3\u0027, self.api_version,"},{"line_number":892,"context_line":"                                          same_major\u003dFalse):"},{"line_number":893,"context_line":"            raise self.skipException("},{"line_number":894,"context_line":"                \u0027TLSA record tests require\u0027"},{"line_number":895,"context_line":"                \u0027 Designate API version 2.3 or newer.\u0027)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        recordset_data \u003d {"},{"line_number":898,"context_line":"            \u0027name\u0027: \"_445._tcp.\" + self.zone[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"cef02df7_31c1b837","line":895,"range":{"start_line":891,"start_character":8,"end_line":895,"end_character":55},"in_reply_to":"6d7efa33_f687733b","updated":"2026-05-11 15:58:27.000000000","message":"Done. Check in parent class now","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":false,"context_lines":[{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":890,"context_line":"    def test_create_TLSA_normalization_and_spaces(self):"},{"line_number":891,"context_line":"        if not versionutils.is_compatible(\u00272.3\u0027, self.api_version,"},{"line_number":892,"context_line":"                                          same_major\u003dFalse):"},{"line_number":893,"context_line":"            raise self.skipException("},{"line_number":894,"context_line":"                \u0027TLSA record tests require\u0027"},{"line_number":895,"context_line":"                \u0027 Designate API version 2.3 or newer.\u0027)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        recordset_data \u003d {"},{"line_number":898,"context_line":"            \u0027name\u0027: \"_445._tcp.\" + self.zone[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"3d623519_18911a40","line":895,"range":{"start_line":891,"start_character":8,"end_line":895,"end_character":55},"in_reply_to":"cef02df7_31c1b837","updated":"2026-05-12 08:21:03.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":true,"context_lines":[{"line_number":927,"context_line":"            \u0027type\u0027: \"TLSA\","},{"line_number":928,"context_line":"            \u0027records\u0027: tlsa_record,"},{"line_number":929,"context_line":"        }"},{"line_number":930,"context_line":"        self.client.create_recordset("},{"line_number":931,"context_line":"            self.zone[\u0027id\u0027],"},{"line_number":932,"context_line":"            recordset_data"},{"line_number":933,"context_line":"        )"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @decorators.idempotent_id(\u0027f4e1a6f4-7c2a-4c91-9f5d-1d2c9c1e0004\u0027)"},{"line_number":936,"context_line":"    def test_create_recordset_invalid_TLSA_usage_overflow(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"0f7a5648_b070f95d","line":933,"range":{"start_line":930,"start_character":0,"end_line":933,"end_character":9},"updated":"2026-05-11 11:27:44.000000000","message":"do we want to assert any value after creating the recordset?","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"7344f847769ee96356ee36d1ed3f69f16e36502b","unresolved":true,"context_lines":[{"line_number":927,"context_line":"            \u0027type\u0027: \"TLSA\","},{"line_number":928,"context_line":"            \u0027records\u0027: tlsa_record,"},{"line_number":929,"context_line":"        }"},{"line_number":930,"context_line":"        self.client.create_recordset("},{"line_number":931,"context_line":"            self.zone[\u0027id\u0027],"},{"line_number":932,"context_line":"            recordset_data"},{"line_number":933,"context_line":"        )"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @decorators.idempotent_id(\u0027f4e1a6f4-7c2a-4c91-9f5d-1d2c9c1e0004\u0027)"},{"line_number":936,"context_line":"    def test_create_recordset_invalid_TLSA_usage_overflow(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a76a05a_77ec65e5","line":933,"range":{"start_line":930,"start_character":0,"end_line":933,"end_character":9},"in_reply_to":"0f7a5648_b070f95d","updated":"2026-05-11 15:58:27.000000000","message":"Fixed","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c72c19808e7d30e9eb3d1a9e81a0e9eb75252b3f","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            \u0027type\u0027: \"TLSA\","},{"line_number":928,"context_line":"            \u0027records\u0027: tlsa_record,"},{"line_number":929,"context_line":"        }"},{"line_number":930,"context_line":"        self.client.create_recordset("},{"line_number":931,"context_line":"            self.zone[\u0027id\u0027],"},{"line_number":932,"context_line":"            recordset_data"},{"line_number":933,"context_line":"        )"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    @decorators.idempotent_id(\u0027f4e1a6f4-7c2a-4c91-9f5d-1d2c9c1e0004\u0027)"},{"line_number":936,"context_line":"    def test_create_recordset_invalid_TLSA_usage_overflow(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ccb1835_e886d35b","line":933,"range":{"start_line":930,"start_character":0,"end_line":933,"end_character":9},"in_reply_to":"3a76a05a_77ec65e5","updated":"2026-05-12 10:42:02.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":true,"context_lines":[{"line_number":942,"context_line":""},{"line_number":943,"context_line":"        # Use a valid _port._proto name so the name check does not mask"},{"line_number":944,"context_line":"        # the intended usage-overflow validation"},{"line_number":945,"context_line":"        self._test_create_recordset_invalid("},{"line_number":946,"context_line":"            \"_443._tcp\","},{"line_number":947,"context_line":"            \u0027TLSA\u0027,"},{"line_number":948,"context_line":"            [\"256 1 1 aabbccdd\"]"},{"line_number":949,"context_line":"        )"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    @decorators.idempotent_id(\u0027c7f4a6f7-7c2a-4c91-9f5d-1d2c9c1e0007\u0027)"},{"line_number":952,"context_line":"    def test_create_recordset_invalid_TLSA_certificate_hex(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"76b2c4cd_6b31a2bd","line":949,"range":{"start_line":945,"start_character":8,"end_line":949,"end_character":9},"updated":"2026-05-11 11:27:44.000000000","message":"If I understand correctly, the intent is to test that usage\u003d256 overflows the 0-255 range. But the certificate aabbccdd is 8 hex chars, and matching_type\u003d1 requires 64 hex chars. The length check runs before self.usage \u003d int(usage), so the request is rejected for wrong certificate length, not usage overflow","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7f33904e12b3f6dd78b8d03b39d8d95f3c2abba9","unresolved":false,"context_lines":[{"line_number":942,"context_line":""},{"line_number":943,"context_line":"        # Use a valid _port._proto name so the name check does not mask"},{"line_number":944,"context_line":"        # the intended usage-overflow validation"},{"line_number":945,"context_line":"        self._test_create_recordset_invalid("},{"line_number":946,"context_line":"            \"_443._tcp\","},{"line_number":947,"context_line":"            \u0027TLSA\u0027,"},{"line_number":948,"context_line":"            [\"256 1 1 aabbccdd\"]"},{"line_number":949,"context_line":"        )"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    @decorators.idempotent_id(\u0027c7f4a6f7-7c2a-4c91-9f5d-1d2c9c1e0007\u0027)"},{"line_number":952,"context_line":"    def test_create_recordset_invalid_TLSA_certificate_hex(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"d74ce289_fd268b2b","line":949,"range":{"start_line":945,"start_character":8,"end_line":949,"end_character":9},"in_reply_to":"76b2c4cd_6b31a2bd","updated":"2026-05-13 07:53:44.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":true,"context_lines":[{"line_number":671,"context_line":"            lambda: self.client.show_recordset(zone[\u0027id\u0027], record[\u0027id\u0027]))"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"class RecordsetsNegativeTest(BaseRecordsetsTest):"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    credentials \u003d [\"admin\", \"primary\", \"alt\"]"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"977446f6_2bc5a0f5","line":674,"range":{"start_line":674,"start_character":0,"end_line":674,"end_character":49},"updated":"2026-05-12 08:21:03.000000000","message":"I don\u0027t see much value in the duplication. test_recordset.py tests run against the full deployed API with backends — they\u0027re the \"real\" functional tests. test_recordset_validation.py is for input validation. I\u0027d keep:\n- Positive CRUD (create/update/delete) in test_recordset.py only — that\u0027s where all other record types test their lifecycle\n- Negative validation (bad hex, wrong length, bare domain, port overflow) in test_recordset_validation.py only — that\u0027s where the other validation tests live\n- The multiline and sha256/sha512 create variants fit test_recordset_validation.py since they\u0027re testing the parser accepts different valid input forms\n\nThat would eliminate the 5 duplicated tests and keep each file focused on its purpose.","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c72c19808e7d30e9eb3d1a9e81a0e9eb75252b3f","unresolved":false,"context_lines":[{"line_number":671,"context_line":"            lambda: self.client.show_recordset(zone[\u0027id\u0027], record[\u0027id\u0027]))"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"class RecordsetsNegativeTest(BaseRecordsetsTest):"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    credentials \u003d [\"admin\", \"primary\", \"alt\"]"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3e33a1d3_2de32c3c","line":674,"range":{"start_line":674,"start_character":0,"end_line":674,"end_character":49},"in_reply_to":"977446f6_2bc5a0f5","updated":"2026-05-12 10:42:02.000000000","message":"Done","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":true,"context_lines":[{"line_number":890,"context_line":"        )"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":893,"context_line":"    def test_create_TLSA_stores_record_as_submitted(self):"},{"line_number":894,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"8e031b77_95589a01","line":893,"range":{"start_line":893,"start_character":8,"end_line":893,"end_character":51},"updated":"2026-05-12 08:21:03.000000000","message":"please add cleanup in this test and on test_create_TLSA_max_values","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"778b4f8b2b0edd6f7bf0915d0ff902c84ccf1860","unresolved":true,"context_lines":[{"line_number":890,"context_line":"        )"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":893,"context_line":"    def test_create_TLSA_stores_record_as_submitted(self):"},{"line_number":894,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"ca00dc0b_b93911b8","line":893,"range":{"start_line":893,"start_character":8,"end_line":893,"end_character":51},"in_reply_to":"25168c8f_fbc67aa6","updated":"2026-05-12 11:00:40.000000000","message":"Done","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"aad106547dfc02c7cfc47dbc3b66f2ae7c410c39","unresolved":true,"context_lines":[{"line_number":890,"context_line":"        )"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":893,"context_line":"    def test_create_TLSA_stores_record_as_submitted(self):"},{"line_number":894,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"9331ca9e_21c28b6f","line":893,"range":{"start_line":893,"start_character":8,"end_line":893,"end_character":51},"in_reply_to":"8e031b77_95589a01","updated":"2026-05-12 09:00:42.000000000","message":"Done","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c72c19808e7d30e9eb3d1a9e81a0e9eb75252b3f","unresolved":true,"context_lines":[{"line_number":890,"context_line":"        )"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":893,"context_line":"    def test_create_TLSA_stores_record_as_submitted(self):"},{"line_number":894,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"25168c8f_fbc67aa6","line":893,"range":{"start_line":893,"start_character":8,"end_line":893,"end_character":51},"in_reply_to":"9331ca9e_21c28b6f","updated":"2026-05-12 10:42:02.000000000","message":"Can you add a cleanup in this test too? (test_create_TLSA_stores_record_as_submitted)","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7f33904e12b3f6dd78b8d03b39d8d95f3c2abba9","unresolved":false,"context_lines":[{"line_number":890,"context_line":"        )"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    @decorators.idempotent_id(\u00277e2d2b7f-1234-4c91-9f5d-1d2c9c1e0011\u0027)"},{"line_number":893,"context_line":"    def test_create_TLSA_stores_record_as_submitted(self):"},{"line_number":894,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"20dd8c4b_e7e1796c","line":893,"range":{"start_line":893,"start_character":8,"end_line":893,"end_character":51},"in_reply_to":"ca00dc0b_b93911b8","updated":"2026-05-13 07:53:44.000000000","message":"Done","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":true,"context_lines":[{"line_number":911,"context_line":"        self.assertEqual(\"3 1 0 AA BB CC DD\", recordset[\u0027records\u0027][0])"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    @decorators.idempotent_id(\u00276d1c1a6f-1234-4c91-9f5d-1d2c9c1e0010\u0027)"},{"line_number":914,"context_line":"    def test_create_TLSA_max_values(self):"},{"line_number":915,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        # matching_type\u003d255 is not in MATCHING_TYPE_LENGTHS so no fixed-length"}],"source_content_type":"text/x-python","patch_set":13,"id":"d9f30dbc_c2d051fa","line":914,"range":{"start_line":914,"start_character":8,"end_line":914,"end_character":35},"updated":"2026-05-12 08:21:03.000000000","message":"we could assert created / updated records as well where that assertion is missing","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7f33904e12b3f6dd78b8d03b39d8d95f3c2abba9","unresolved":false,"context_lines":[{"line_number":911,"context_line":"        self.assertEqual(\"3 1 0 AA BB CC DD\", recordset[\u0027records\u0027][0])"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    @decorators.idempotent_id(\u00276d1c1a6f-1234-4c91-9f5d-1d2c9c1e0010\u0027)"},{"line_number":914,"context_line":"    def test_create_TLSA_max_values(self):"},{"line_number":915,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        # matching_type\u003d255 is not in MATCHING_TYPE_LENGTHS so no fixed-length"}],"source_content_type":"text/x-python","patch_set":13,"id":"f80a56a5_514bf4f8","line":914,"range":{"start_line":914,"start_character":8,"end_line":914,"end_character":35},"in_reply_to":"26a88483_ceada4f4","updated":"2026-05-13 07:53:44.000000000","message":"Done","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c72c19808e7d30e9eb3d1a9e81a0e9eb75252b3f","unresolved":true,"context_lines":[{"line_number":911,"context_line":"        self.assertEqual(\"3 1 0 AA BB CC DD\", recordset[\u0027records\u0027][0])"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    @decorators.idempotent_id(\u00276d1c1a6f-1234-4c91-9f5d-1d2c9c1e0010\u0027)"},{"line_number":914,"context_line":"    def test_create_TLSA_max_values(self):"},{"line_number":915,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        # matching_type\u003d255 is not in MATCHING_TYPE_LENGTHS so no fixed-length"}],"source_content_type":"text/x-python","patch_set":13,"id":"dde7f074_fc0b36b9","line":914,"range":{"start_line":914,"start_character":8,"end_line":914,"end_character":35},"in_reply_to":"3292b1ca_2bf5db10","updated":"2026-05-12 10:42:02.000000000","message":"The 202 response body already contains the full records field — only status is PENDING, not the data. No extra API call is needed. You have already implemented it on test_create_TLSA_stores_record_as_submitted and test_update_TLSA, we know it will pass.","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"aad106547dfc02c7cfc47dbc3b66f2ae7c410c39","unresolved":true,"context_lines":[{"line_number":911,"context_line":"        self.assertEqual(\"3 1 0 AA BB CC DD\", recordset[\u0027records\u0027][0])"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    @decorators.idempotent_id(\u00276d1c1a6f-1234-4c91-9f5d-1d2c9c1e0010\u0027)"},{"line_number":914,"context_line":"    def test_create_TLSA_max_values(self):"},{"line_number":915,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        # matching_type\u003d255 is not in MATCHING_TYPE_LENGTHS so no fixed-length"}],"source_content_type":"text/x-python","patch_set":13,"id":"3292b1ca_2bf5db10","line":914,"range":{"start_line":914,"start_character":8,"end_line":914,"end_character":35},"in_reply_to":"d9f30dbc_c2d051fa","updated":"2026-05-12 09:00:42.000000000","message":"What is purpose here to have assert on created/updated records? I\u0027m not agree to go with extra assert by two reasons:\n1. We already check that zone in active state by wait_until argument\n2. To check it with assert we will need to get zone status again, because with a first call it return status PENDING.\nI can add this if you are not trust to wait_until and want to have one more extra call to get zone from API.","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"778b4f8b2b0edd6f7bf0915d0ff902c84ccf1860","unresolved":true,"context_lines":[{"line_number":911,"context_line":"        self.assertEqual(\"3 1 0 AA BB CC DD\", recordset[\u0027records\u0027][0])"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    @decorators.idempotent_id(\u00276d1c1a6f-1234-4c91-9f5d-1d2c9c1e0010\u0027)"},{"line_number":914,"context_line":"    def test_create_TLSA_max_values(self):"},{"line_number":915,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        # matching_type\u003d255 is not in MATCHING_TYPE_LENGTHS so no fixed-length"}],"source_content_type":"text/x-python","patch_set":13,"id":"26a88483_ceada4f4","line":914,"range":{"start_line":914,"start_character":8,"end_line":914,"end_character":35},"in_reply_to":"dde7f074_fc0b36b9","updated":"2026-05-12 11:00:40.000000000","message":"Ah, ok looks like you want to check not zone status but recordset data, my misunderstanding, sorry. Added.","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"}],"designate_tempest_plugin/tests/api/v2/test_recordset_validation.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        waiters.wait_for_recordset_status("},{"line_number":285,"context_line":"            self.recordset_client, self.zone[\u0027id\u0027],"},{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"}],"source_content_type":"text/x-python","patch_set":11,"id":"b121de93_210ed8ea","line":287,"updated":"2026-05-11 11:27:44.000000000","message":"Can you add a negative test for port \u003e65535?","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        waiters.wait_for_recordset_status("},{"line_number":285,"context_line":"            self.recordset_client, self.zone[\u0027id\u0027],"},{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"}],"source_content_type":"text/x-python","patch_set":11,"id":"c7d501d5_e8dd9be3","line":287,"updated":"2026-05-11 11:27:44.000000000","message":"Can you add coverage for update or delete operations?","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        waiters.wait_for_recordset_status("},{"line_number":285,"context_line":"            self.recordset_client, self.zone[\u0027id\u0027],"},{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"}],"source_content_type":"text/x-python","patch_set":11,"id":"a9702291_783c9218","line":287,"in_reply_to":"207a8938_7127215f","updated":"2026-05-12 08:21:03.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"7344f847769ee96356ee36d1ed3f69f16e36502b","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        waiters.wait_for_recordset_status("},{"line_number":285,"context_line":"            self.recordset_client, self.zone[\u0027id\u0027],"},{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"}],"source_content_type":"text/x-python","patch_set":11,"id":"cfe949eb_4d696e44","line":287,"in_reply_to":"b121de93_210ed8ea","updated":"2026-05-11 15:58:27.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"7344f847769ee96356ee36d1ed3f69f16e36502b","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        waiters.wait_for_recordset_status("},{"line_number":285,"context_line":"            self.recordset_client, self.zone[\u0027id\u0027],"},{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"}],"source_content_type":"text/x-python","patch_set":11,"id":"207a8938_7127215f","line":287,"in_reply_to":"c7d501d5_e8dd9be3","updated":"2026-05-11 15:58:27.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        waiters.wait_for_recordset_status("},{"line_number":285,"context_line":"            self.recordset_client, self.zone[\u0027id\u0027],"},{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ddb8da53_a83490e2","line":287,"in_reply_to":"cfe949eb_4d696e44","updated":"2026-05-12 08:21:03.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":true,"context_lines":[{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"2e1dfc38_287649cf","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":29},"updated":"2026-05-11 11:27:44.000000000","message":"is this test missing some of its name?","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"a18daf06_8846f07f","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":29},"in_reply_to":"1d29d952_78beca1c","updated":"2026-05-12 08:21:03.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"7344f847769ee96356ee36d1ed3f69f16e36502b","unresolved":true,"context_lines":[{"line_number":286,"context_line":"            recordset[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":289,"context_line":"    def test_create_TLSA_with(self):"},{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"1d29d952_78beca1c","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":29},"in_reply_to":"2e1dfc38_287649cf","updated":"2026-05-11 15:58:27.000000000","message":"Fixed","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7e0f827455e2e3ff9c02fdde35c5176dacb4fda7","unresolved":true,"context_lines":[{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        recordset_data \u003d {"},{"line_number":293,"context_line":"            \u0027name\u0027: \"_443._tcp.\" + self.zone[\u0027name\u0027],"},{"line_number":294,"context_line":"            \u0027type\u0027: \"TLSA\","},{"line_number":295,"context_line":"            # matching_type\u003d1 (SHA-256): exactly 64 hex chars required"},{"line_number":296,"context_line":"            \u0027records\u0027: [\"3 1 1 \" + _TLSA_SHA256],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7154e566_352de37f","line":293,"range":{"start_line":293,"start_character":0,"end_line":293,"end_character":53},"updated":"2026-05-11 11:27:44.000000000","message":"the same name is being used across all tests:\n\u0027name\u0027: \"_443._tcp.\" + self.zone[\u0027name\u0027],\nI wonder if the tests names colide or might colide in the future","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"7344f847769ee96356ee36d1ed3f69f16e36502b","unresolved":true,"context_lines":[{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        recordset_data \u003d {"},{"line_number":293,"context_line":"            \u0027name\u0027: \"_443._tcp.\" + self.zone[\u0027name\u0027],"},{"line_number":294,"context_line":"            \u0027type\u0027: \"TLSA\","},{"line_number":295,"context_line":"            # matching_type\u003d1 (SHA-256): exactly 64 hex chars required"},{"line_number":296,"context_line":"            \u0027records\u0027: [\"3 1 1 \" + _TLSA_SHA256],"}],"source_content_type":"text/x-python","patch_set":11,"id":"748dd234_6ee3b2ba","line":293,"range":{"start_line":293,"start_character":0,"end_line":293,"end_character":53},"in_reply_to":"7154e566_352de37f","updated":"2026-05-11 15:58:27.000000000","message":"Fixed","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        recordset_data \u003d {"},{"line_number":293,"context_line":"            \u0027name\u0027: \"_443._tcp.\" + self.zone[\u0027name\u0027],"},{"line_number":294,"context_line":"            \u0027type\u0027: \"TLSA\","},{"line_number":295,"context_line":"            # matching_type\u003d1 (SHA-256): exactly 64 hex chars required"},{"line_number":296,"context_line":"            \u0027records\u0027: [\"3 1 1 \" + _TLSA_SHA256],"}],"source_content_type":"text/x-python","patch_set":11,"id":"837a87db_1da69b25","line":293,"range":{"start_line":293,"start_character":0,"end_line":293,"end_character":53},"in_reply_to":"748dd234_6ee3b2ba","updated":"2026-05-12 08:21:03.000000000","message":"Done","commit_id":"447a0e968bc37b9c34aeb280764adc7a95415c99"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3b3aab45e10ade21dcdfd3d9b55b63091607a459","unresolved":true,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":282,"context_line":"    def test_create_TLSA_with_sha256(self):"},{"line_number":283,"context_line":"        # Renamed from test_create_TLSA_with to reflect matching_type\u003d1"},{"line_number":284,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"c8e7ec70_405b1a3d","line":283,"range":{"start_line":283,"start_character":8,"end_line":283,"end_character":71},"updated":"2026-05-12 08:21:03.000000000","message":"we can delete this AI-generated comment","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":33685,"name":"Mikhail","display_name":"Mikhail Samoylov","email":"mikhailsamoiloff@gmail.com","username":"mikhails"},"change_message_id":"aad106547dfc02c7cfc47dbc3b66f2ae7c410c39","unresolved":true,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":282,"context_line":"    def test_create_TLSA_with_sha256(self):"},{"line_number":283,"context_line":"        # Renamed from test_create_TLSA_with to reflect matching_type\u003d1"},{"line_number":284,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"dae0cc06_e0ac6ea0","line":283,"range":{"start_line":283,"start_character":8,"end_line":283,"end_character":71},"in_reply_to":"c8e7ec70_405b1a3d","updated":"2026-05-12 09:00:42.000000000","message":"Done","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7f33904e12b3f6dd78b8d03b39d8d95f3c2abba9","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @decorators.idempotent_id(\u0027c1b8a6f1-7c2a-4c91-9f5d-1d2c9c1e0001\u0027)"},{"line_number":282,"context_line":"    def test_create_TLSA_with_sha256(self):"},{"line_number":283,"context_line":"        # Renamed from test_create_TLSA_with to reflect matching_type\u003d1"},{"line_number":284,"context_line":"        self._skip_if_tlsa_not_supported()"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        recordset_data \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"e871be06_d0bd2e58","line":283,"range":{"start_line":283,"start_character":8,"end_line":283,"end_character":71},"in_reply_to":"dae0cc06_e0ac6ea0","updated":"2026-05-13 07:53:44.000000000","message":"Done","commit_id":"0e04bccb8d719a12e28d67d8d8fbda422039bf05"}]}