)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f8da7ba519ba5ac0c99344c048ddf1cb45329e46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ac7a063_0facc122","updated":"2026-05-08 09:55:49.000000000","message":"A few comments inline, but except for those it looks good to me","commit_id":"e37880e4e8619d0c5605835203ca57a3d58c8132"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"29ca02d55cc34d00b831430d43fcc4908ff92b87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7217146d_08c3399f","updated":"2026-05-05 17:22:13.000000000","message":"recheck https://review.opendev.org/c/openstack/designate-tempest-plugin/+/977949 is merged, we could watch the second bind artifacts","commit_id":"e37880e4e8619d0c5605835203ca57a3d58c8132"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"9aa6f77679acfb9216b3e4f6478ac53aa6c0f6f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44bcbb68_c1740672","updated":"2026-05-05 12:33:17.000000000","message":"recheck stable/2024.2 transitioned to EOL and the patch that removed it is now merged","commit_id":"e37880e4e8619d0c5605835203ca57a3d58c8132"}],"designate_tempest_plugin/services/dns/query/query_client.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f8da7ba519ba5ac0c99344c048ddf1cb45329e46","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    \"\"\"A client which queries multiple nameservers\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, nameservers\u003dNone, query_timeout\u003dNone,"},{"line_number":29,"context_line":"                 build_interval\u003dNone, build_timeout\u003dNone,"},{"line_number":30,"context_line":"                 tsig_key_name\u003dNone, tsig_key_secret\u003dNone,"},{"line_number":31,"context_line":"                 tsig_key_algorithm\u003dNone):"},{"line_number":32,"context_line":"        self.nameservers \u003d nameservers or CONF.dns.nameservers"},{"line_number":33,"context_line":"        self.query_timeout \u003d query_timeout or CONF.dns.query_timeout"},{"line_number":34,"context_line":"        self.build_interval \u003d build_interval or CONF.dns.build_interval"},{"line_number":35,"context_line":"        self.build_timeout \u003d build_timeout or CONF.dns.build_timeout"},{"line_number":36,"context_line":"        self.clients \u003d [SingleQueryClient("},{"line_number":37,"context_line":"                            ns, query_timeout\u003dself.query_timeout,"},{"line_number":38,"context_line":"                            tsig_key_name\u003dtsig_key_name,"},{"line_number":39,"context_line":"                            tsig_key_secret\u003dtsig_key_secret,"},{"line_number":40,"context_line":"                            tsig_key_algorithm\u003dtsig_key_algorithm)"},{"line_number":41,"context_line":"                        for ns in self.nameservers]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def query(self, zone_name, rdatatype):"},{"line_number":44,"context_line":"        if not self.nameservers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3f6ffe0_fa4f7db3","line":41,"range":{"start_line":29,"start_character":0,"end_line":41,"end_character":51},"updated":"2026-05-08 09:55:49.000000000","message":"The TSIG key name, secret, and algorithm are threaded as 3 separate parameters through every layer (QueryClient → SingleQueryClient → _dig → _prepare_query). Consider building the keyring and algorithm once in SingleQueryClient.__init__ and storing them as instance attributes — then _dig and _prepare_query don\u0027t need the extra parameters at all.","commit_id":"e37880e4e8619d0c5605835203ca57a3d58c8132"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f8da7ba519ba5ac0c99344c048ddf1cb45329e46","unresolved":true,"context_lines":[{"line_number":129,"context_line":"      tempest_test_regex: ^designate_tempest_plugin.tests.scenario.v2.test_designate_multipool.DesignateMultiPoolTest"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- job:"},{"line_number":132,"context_line":"    name: designate-bind9-split-horizon"},{"line_number":133,"context_line":"    parent: designate-core"},{"line_number":134,"context_line":"    nodeset: openstack-single-node-noble"},{"line_number":135,"context_line":"    vars:"},{"line_number":136,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c8bb7210_9091e82b","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":26},"updated":"2026-05-08 09:55:49.000000000","message":"Now that we have this post-run task available (I merged it this week), let\u0027s use it here, it will help with debugging when needed.\nhttps://opendev.org/openstack/designate-tempest-plugin/src/branch/master/zuul.d/jobs.yaml#L113\n\nWe can just copy paste it as is, it should work\npost-run: playbooks/designate-bind9-multipool/post.yaml","commit_id":"e37880e4e8619d0c5605835203ca57a3d58c8132"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b62bcaef7ddd39d696aa021a3c5c7285b7099342","unresolved":true,"context_lines":[{"line_number":129,"context_line":"      tempest_test_regex: ^designate_tempest_plugin.tests.scenario.v2.test_designate_multipool.DesignateMultiPoolTest"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- job:"},{"line_number":132,"context_line":"    name: designate-bind9-split-horizon"},{"line_number":133,"context_line":"    parent: designate-core"},{"line_number":134,"context_line":"    nodeset: openstack-single-node-noble"},{"line_number":135,"context_line":"    vars:"},{"line_number":136,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bd4e11b6_49c4fd98","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":26},"in_reply_to":"c8bb7210_9091e82b","updated":"2026-05-08 12:22:21.000000000","message":"could also just change its parent job to \"designate-bind9-multipool\" and keep \nvars:\n      devstack_localrc:\n        DESIGNATE_BACKEND_DRIVER: split-horizon-bind9","commit_id":"e37880e4e8619d0c5605835203ca57a3d58c8132"}]}