)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"65ecf1c4282dfef59452e9218ffa80f5e958e364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f89581c1_61717083","updated":"2026-09-03 13:29:03.000000000","message":"I agree on the underlying idea — multiple POOL-scoped TSIG keys per pool is a legitimate setup (say a pool per backend target), and the DB schema has no constraint blocking it.\n\nI tested this patch on a live, two-pool DevStack setup: added two POOL-scoped TSIG keys to the same non-default pool, then confirmed zone create, pool_move_zone, recordset/record creation all go ACTIVE and are diggable against that pool\u0027s nameserver — no BadRequest regressions, and central logs show a clean PENDING to ACTIVE transition for the move too.\n\nLGTM, and it would be great to hear other reviewers opinions as well. Thanks for suggesting the patch, Jiho","commit_id":"90f3f73427a569d0f9202c7a074b26457b3811e3"},{"author":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"change_message_id":"e5dcce9106dde4c7ffba50b96eae19a1c13dd2e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d8ab310_9d66ed43","updated":"2026-09-14 06:47:54.000000000","message":"eoandersson: gentle ping on this one. oschwart +2\u0027d it on 2026-09-03 after\nreproducing it on a live two-pool devstack - zone create, pool_move_zone and\nrecordset writes all went ACTIVE against that pool\u0027s nameserver with no\nBadRequest regressions - and asked to hear another reviewer before it lands.\n\nThe change is small: _validate_pool_tsig_key() looked the key up with\nfind_tsigkey(), which goes through _find(one\u003dTrue) and raises\nTsigKeyNotFound whenever the match count is not exactly one, so a pool with\ntwo POOL-scoped keys is reported as having none. It now uses find_tsigkeys()\nand checks that at least one exists, which is all that validation needs.\nNothing else in the tree resolves a TSIG key by pool: mdns resolves it by its\nunique name and maps tsigkey.resource_id back to pool_id.\n\nHappy to add tests or rebase if anything is missing.","commit_id":"90f3f73427a569d0f9202c7a074b26457b3811e3"},{"author":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"change_message_id":"9f02f03459b0ff164b99c065d56a3c390f48af50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84987798_dcf9a66b","in_reply_to":"f89581c1_61717083","updated":"2026-09-04 01:13:54.000000000","message":"Thanks Omer, and thank you for taking the time to reproduce it on a live\ntwo-pool setup - pool_move_zone was the path I was least able to exercise\non my side, so that check is the one I most wanted to see.\n\nNothing to change from my end; patch set 1 is unchanged and still green.\nI have added Erik for the second pair of eyes you asked for.","commit_id":"90f3f73427a569d0f9202c7a074b26457b3811e3"}]}