)]}'
{"id":"openstack%2Fdesignate~1001773","triplet_id":"openstack%2Fdesignate~master~Id40246cecb7c3896527e73c748d6cb6c58363ff0","project":"openstack/designate","branch":"master","attention_set":{"22623":{"account":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"last_update":"2026-09-04 01:12:36.000000000","reason":"\u003cGERRIT_ACCOUNT_36710\u003e replied on the change","reason_account":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"}}},"removed_from_attention_set":{"31664":{"account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"last_update":"2026-09-03 13:29:03.000000000","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change","reason_account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},"36710":{"account":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"last_update":"2026-09-04 01:12:36.000000000","reason":"\u003cGERRIT_ACCOUNT_36710\u003e replied on the change","reason_account":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"}}},"hashtags":[],"change_id":"Id40246cecb7c3896527e73c748d6cb6c58363ff0","subject":"Allow multiple POOL scoped TSIG keys per pool","status":"NEW","created":"2026-08-21 09:10:51.000000000","updated":"2026-09-04 01:13:54.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9f02f03459b0ff164b99c065d56a3c390f48af50","_number":1001773,"virtual_id_number":1001773,"owner":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-08-21 10:31:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":2,"date":"2026-09-03 13:29:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-21 10:31:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-08-24 00:24:55.000000000","updated_by":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"reviewer":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"state":"REVIEWER"},{"updated":"2026-09-04 01:12:36.000000000","updated_by":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"}],"messages":[{"id":"9f9957445d95aabce2b32260f4ac15dab7189bf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"date":"2026-08-21 09:10:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"56ef052c9ebb3bb970db4e678113279fb197f8ef","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-21 10:31:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a43d07ec74fe4f57bbbc4910a98c3568\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/974abb20dac14f17a0ff7b40897991f4 : SUCCESS in 41m 23s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/0b46422e20c24f509a03e9a38e8e33fc : SUCCESS in 33m 59s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/9880cc843372416eb03de5178ba3571f : SUCCESS in 41m 31s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/13dd480c69ab42a89ed4bfe2bc2d2f46 : SUCCESS in 20m 22s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/3bd9d862df204684810da91bbe71ca8b : SUCCESS in 1h 01m 31s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/fcc85a2f256b49a1acb0c6983c8bfd3f : SUCCESS in 1h 06m 30s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/5b2b7d31b17f459b83f78a0a02e49dd4 : SUCCESS in 1h 10m 06s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/3b092536e4a24beba96c1010890084d2 : SUCCESS in 1h 09m 28s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/efd7d525975e4c0c91ef3300d8f904c8 : SUCCESS in 42m 53s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/d4acf54077c64776b559e8b0b6e86171 : SUCCESS in 44m 45s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/e0d0ea5b18ff4102a77f9727d43ba10c : SUCCESS in 31m 24s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/db1e990fb3fc4ae59cb80acade928024 : SUCCESS in 5m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/78a2147f965e4b6c905a3bba0dfa9248 : SUCCESS in 2m 49s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c131b99019984e079e8e41e164815ebb : SUCCESS in 6m 18s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/579bf9c343104b3da0009602d80c1593 : SUCCESS in 4m 54s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/2e0676f45b7e4586aacbcc56d0eeb9ee : SUCCESS in 8m 36s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d75b540d32514b678b76295d66b141c5 : SUCCESS in 7m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/761f57bac24b458299adddb1c23658a2 : SUCCESS in 6m 25s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/ca3d8c483e0644f48608c8e6a391388b : SUCCESS in 31m 38s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/19d3f94948134189a1de33b49fd9a612 : SUCCESS in 4m 51s","accounts_in_message":[],"_revision_number":1},{"id":"65ecf1c4282dfef59452e9218ffa80f5e958e364","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-09-03 13:29:03.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9f02f03459b0ff164b99c065d56a3c390f48af50","author":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"date":"2026-09-04 01:13:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"90f3f73427a569d0f9202c7a074b26457b3811e3","revisions":{"90f3f73427a569d0f9202c7a074b26457b3811e3":{"kind":"REWORK","_number":1,"created":"2026-08-21 09:10:51.000000000","uploader":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"ref":"refs/changes/73/1001773/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/73/1001773/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/73/1001773/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/73/1001773/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/73/1001773/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/73/1001773/1"}}},"commit":{"parents":[{"commit":"9f82089b2735878966322495beee604c0ffa0e30","subject":"Merge \"Fix newline validation gap in TXT/SPF/NAPTR causing AXFR DoS\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/9f82089b2735878966322495beee604c0ffa0e30"}]}],"author":{"name":"JeongJiho","email":"jiho.jeong@samsung.com","date":"2026-08-18 02:45:23.000000000","tz":540},"committer":{"name":"JeongJiho","email":"jiho.jeong@samsung.com","date":"2026-08-21 09:05:07.000000000","tz":540},"subject":"Allow multiple POOL scoped TSIG keys per pool","message":"Allow multiple POOL scoped TSIG keys per pool\n\n_validate_pool_tsig_key() looks a pool\u0027s TSIG key up with\nstorage.find_tsigkey() and the criterion {\u0027scope\u0027: \u0027POOL\u0027,\n\u0027resource_id\u0027: pool_id}. That helper goes through _find(one\u003dTrue), which\nraises TsigKeyNotFound whenever the number of matching rows is not\nexactly one, so 0 rows and 2+ rows are indistinguishable: a pool with\ntwo or more POOL scoped keys is reported as having none, and every zone\ncreate or pool move targeting it fails with\n\n  Zones in non-default pools require a TSIG key with scope\u003dPOOL for zone\n  transfers. Pool \"\u003cname\u003e\" (ID: \u003cid\u003e) does not have a TSIG key\n  configured.\n\nThe message is misleading as well - it tells the operator to create a\nkey, while the actual condition is that more than one matched.\n\nOnly tsigkeys.name carries a UNIQUE constraint; neither resource_id nor\nthe pair (scope, resource_id) does, and several keys pointing at the\nsame pool is a valid configuration - one key per backend target, or one\nper region. mDNS never looks a key up by pool: dnsmiddleware resolves it\nby its unique name and mdns/handler maps tsigkey.resource_id to pool_id,\nso any of those keys resolves to the same pool.\n\nUse find_tsigkeys() and check that at least one key exists, which is all\nthis validation needs.\n\nThe two central test_basic zone create tests replace storage with a Mock,\nso they now need _validate_pool_tsig_key() stubbed out as well - the\nplural lookup returns a Mock rather than raising, and len() on it fails.\n\nCloses-Bug: #2163721\nRelated-Bug: #2008693\nChange-Id: Id40246cecb7c3896527e73c748d6cb6c58363ff0\nSigned-off-by: JeongJiho \u003cjiho.jeong@samsung.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/90f3f73427a569d0f9202c7a074b26457b3811e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/90f3f73427a569d0f9202c7a074b26457b3811e3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}