)]}'
{"id":"openstack%2Fdesignate~1003042","triplet_id":"openstack%2Fdesignate~master~Ia8582d7bc4aa3a1a11dcfffeaf6a94f290244546","project":"openstack/designate","branch":"master","hashtags":[],"change_id":"Ia8582d7bc4aa3a1a11dcfffeaf6a94f290244546","subject":"Warn against combining attribute and pool_id_attribute filters","status":"NEW","created":"2026-08-31 12:10:48.000000000","updated":"2026-08-31 12:26:41.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3e2aa058cff6d539fbce808a2330d74ef932ca5a","_number":1003042,"virtual_id_number":1003042,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-08-31 12:26:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-31 12:26:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3be654fa11a266c10ad79aaef8f43d1c4d12b697","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-08-31 12:10:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3e2aa058cff6d539fbce808a2330d74ef932ca5a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-31 12:26:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/614744817cd04817ad95ed2ce0dcc3ef\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4b6a39d6a44540528fe0c6cf3bcb9465 : SUCCESS in 4m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8fd4da1ad597435a8093c6bdcf6f0489 : SUCCESS in 9m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f436edc5e556402b8fa12b7e0119823e : SUCCESS in 6m 17s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6d63efb9ba7a182912256393ee6d622d9b391ba2","revisions":{"6d63efb9ba7a182912256393ee6d622d9b391ba2":{"kind":"REWORK","_number":1,"created":"2026-08-31 12:10:48.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/42/1003042/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/42/1003042/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/42/1003042/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/42/1003042/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/42/1003042/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/42/1003042/1"}}},"commit":{"parents":[{"commit":"9f82089b2735878966322495beee604c0ffa0e30","subject":"Merge \"Fix newline validation gap in TXT/SPF/NAPTR causing AXFR DoS\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/9f82089b2735878966322495beee604c0ffa0e30"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-08-31 12:01:35.000000000","tz":120},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-08-31 12:02:00.000000000","tz":120},"subject":"Warn against combining attribute and pool_id_attribute filters","message":"Warn against combining attribute and pool_id_attribute filters\n\nThe attribute scheduler filter requires every candidate pool to define\nevery attribute key present on the zone, including pool_id. Pools never\ndefine a pool_id attribute themselves, so any zone that specifies\npool_id has its target pool removed by the attribute filter before\npool_id_attribute runs, and the zone silently lands on the default pool\ninstead of the one it requested.\n\npool-scheduler.rst\u0027s generic scheduler_filters example combined the two\nfilters together, and devstack/README.rst instructed multipool/\nsplit-horizon contributors to do the same - both examples demonstrate a\ncombination that does not work as shown. Drop pool_id_attribute from\nboth examples and add a warning explaining the interaction, pointing to\nthe two working single-mechanism configurations already documented in\nmultiple-pools.rst.\n\nCloses-Bug: #2160484\nGenerated-By: Claude Code 5 Sonnet\nChange-Id: Ia8582d7bc4aa3a1a11dcfffeaf6a94f290244546\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/6d63efb9ba7a182912256393ee6d622d9b391ba2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/6d63efb9ba7a182912256393ee6d622d9b391ba2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}