)]}'
{"id":"openstack%2Fdesignate~1005205","triplet_id":"openstack%2Fdesignate~master~Id83a17dc94892e77d8c1a01911d3bd3c0ec6daa6","project":"openstack/designate","branch":"master","hashtags":[],"change_id":"Id83a17dc94892e77d8c1a01911d3bd3c0ec6daa6","subject":"Allow project managers to abandon zones in their own project","status":"ABANDONED","created":"2026-09-11 10:23:56.000000000","updated":"2026-09-18 15:28:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"363950955e84ac4a0d7faf7730c2340a272f48df","_number":1005205,"virtual_id_number":1005205,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-09-11 11:38:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-11 11:38:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4b7b5dee70bf1889e92fc57ea01f6b9b26c16db4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-09-11 10:23:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"45b0e64bf8e8a96f6c5499cd09beee44ad2110a1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-11 11:38:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8e3e9f7cc06b476ea9713c6860af0a24\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/291604eb19504e088376a296ee6f1477 : SUCCESS in 35m 57s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/916c67f48af44b1abff64967220b70c2 : SUCCESS in 47m 22s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/351e2196c6d14c9b9f2eb9c91e920d57 : SUCCESS in 34m 16s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/4dde46feb7ff41bc983d3ba0b0c7c408 : SUCCESS in 15m 16s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/4861e6605e3b4cbfb2f45bc1e78cdf8d : SUCCESS in 43m 48s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/6aeb74f23dc14daab722afe64e6cea97 : SUCCESS in 1h 07m 28s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/79bf4b3435b345899ff3c57356221006 : SUCCESS in 48m 47s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/ce95252a511f4a05ab8c76af41b3276d : SUCCESS in 1h 08m 43s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/62e1af81be044be7bbb23885b4a6707b : FAILURE in 55m 57s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/88c04980a9ae4ea3a3b248a786d42d50 : SUCCESS in 36m 53s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/3481d5d3f2d346c7be2b7ede2d12a433 : SUCCESS in 37m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/de4a5f02022943a8b03ba42014f66df4 : SUCCESS in 6m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b19963994e9c4ca898861f2ad33089e9 : SUCCESS in 2m 00s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/77585042422349ac869ae714927ed8e8 : SUCCESS in 3m 02s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/b925c0e031e7487c81594a4455ba2e39 : SUCCESS in 4m 34s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/23ef19f0cc854170b2927139ca938c74 : SUCCESS in 9m 17s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4c2a6e9bb48b4090bd7cf8e4afff2f10 : SUCCESS in 8m 54s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2c0b87af6c6d41a688540d41286759f9 : SUCCESS in 3m 00s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/4eeb09288c674af9897b35e4fce2e847 : SUCCESS in 30m 52s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/24b4c42ab69c47c085b7d4e299dcafa0 : SUCCESS in 5m 07s","accounts_in_message":[],"_revision_number":1},{"id":"363950955e84ac4a0d7faf7730c2340a272f48df","tag":"autogenerated:gerrit:abandon","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-09-18 15:28:18.000000000","message":"Abandoned\n\nA Designate community decision was made about this role, we decided it has limited benefit and hence we don\u0027t need it. The link to the discussion: https://bugs.launchpad.net/ossa/+bug/2154578. Abandoning it","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"01200a379ffcba5413547b59f31b68a5977e1957","revisions":{"01200a379ffcba5413547b59f31b68a5977e1957":{"kind":"REWORK","_number":1,"created":"2026-09-11 10:23:56.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/05/1005205/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/05/1005205/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/05/1005205/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/05/1005205/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/05/1005205/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/05/1005205/1"}}},"commit":{"parents":[{"commit":"0f1c07d2e99b2fe21a09a38d9d02e7dac6e11a32","subject":"Add foundational PROJECT_MANAGER policy rule constants","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/0f1c07d2e99b2fe21a09a38d9d02e7dac6e11a32"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-09-11 10:19:54.000000000","tz":120},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-09-11 10:22:44.000000000","tz":120},"subject":"Allow project managers to abandon zones in their own project","message":"Allow project managers to abandon zones in their own project\n\nAbandoning a zone (deleting it immediately, bypassing the normal\nPENDING/backend-cleanup flow) required the full \"admin\" role. Flip\nabandon_zone\u0027s check_str from ADMIN to ADMIN_OR_PROJECT_MANAGER so a\nproject-scoped \"manager\" can abandon zones in their own project\nwithout needing admin.\n\nThis exposed a latent bug: DesignateContext.abandon\u0027s setter calls\npolicy.check(\u0027abandon_zone\u0027, self) with no target, harmless for a\nplain \"role:admin\" check but now failing closed for every non-admin\ncaller, since the missing project_id can\u0027t match. Fix by passing the\nrequester\u0027s own project_id as the target, so this early gate still\nevaluates the role correctly; the authoritative per-zone check\nremains in central\u0027s delete_zone().\n\nAdd manager-role support to TestContextMiddleware (test-only) and\nreplace test_post_abandon_zone\u0027s allow-all override with real RBAC\ncases: member denied, cross-project manager gets 404 (consistent\nwith existing behavior), same-project manager succeeds.\n\nGenerated-By: Claude Code 5 Sonnet\nRelated-Bug: #2154578\nChange-Id: Id83a17dc94892e77d8c1a01911d3bd3c0ec6daa6\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/01200a379ffcba5413547b59f31b68a5977e1957"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/01200a379ffcba5413547b59f31b68a5977e1957"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}