)]}'
{"id":"openstack%2Fdesignate~1006493","triplet_id":"openstack%2Fdesignate~master~I004be509e19eb17cc2678c344f05fb5945886f81","project":"openstack/designate","branch":"master","hashtags":[],"change_id":"I004be509e19eb17cc2678c344f05fb5945886f81","subject":"Fix zone serial increment on pool_id-only update","status":"NEW","created":"2026-09-21 10:51:11.000000000","updated":"2026-09-21 12:26:01.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bbb52eb93f4814b3935a2352c3e7c969a6c8ecfa","_number":1006493,"virtual_id_number":1006493,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-09-21 12:26:01.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-21 12:26:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3eee9dddb7ff2db5136fbac25a94c569ea755b3d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-09-21 10:51:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bbb52eb93f4814b3935a2352c3e7c969a6c8ecfa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-21 12:26:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/74af7c8635a940608c128795ee0fadce\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/fe13aa524bff48a1a93a58f1bd7e7ec8 : SUCCESS in 43m 13s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/cb59b90b416f40808eb1a7b5a2db1be3 : SUCCESS in 32m 56s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/93bd012c1efc4a998e35245ba53fb2a3 : SUCCESS in 44m 02s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/54d7b096860c409795c6733483f585ba : SUCCESS in 35m 15s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/c3b6242dd7534565ae42ede4de28d2cd : SUCCESS in 1h 09m 17s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/76f2e7900bbe4008a304b68906c2508c : SUCCESS in 1h 17m 20s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/59a77571e5c24fce95c9958b3ef8d1e9 : SUCCESS in 1h 14m 28s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/2ce9d7092415455db8f9654d67426689 : SUCCESS in 1h 14m 43s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/285d25067ff8461184e695a2892ea9a4 : SUCCESS in 47m 33s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/5c9e8d8223f54b5d970d024f3142fc19 : SUCCESS in 38m 19s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/7f1b1813b4364432ab2cf60a551aabd2 : SUCCESS in 37m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9d0aff69845b4efc9eca6d878ee8359c : SUCCESS in 4m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4a694ea53a2e475a9ddb75f1d6b4576a : SUCCESS in 5m 06s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/554a310444b34f6496b9b52db9f03978 : SUCCESS in 3m 53s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/3d128a37aff34a778c847f8d6d073cb9 : SUCCESS in 7m 04s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/b4cf96ce78304f1daa1e038e0681592e : SUCCESS in 5m 11s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3d39d8ccdfe84069b4128d5f7168d17f : SUCCESS in 10m 55s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/229d52385aad41d08098ed6bd895c2f0 : SUCCESS in 7m 23s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/33f56d1f9a404faa9c85d9f7b98688db : SUCCESS in 30m 20s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/655578ec02c64bc98104980da983ad6b : SUCCESS in 5m 04s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9a969b4d36a747a7266ebb25ef28e91723d8f6cf","revisions":{"9a969b4d36a747a7266ebb25ef28e91723d8f6cf":{"kind":"REWORK","_number":1,"created":"2026-09-21 10:51:11.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/93/1006493/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/93/1006493/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/93/1006493/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/93/1006493/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/93/1006493/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/93/1006493/1"}}},"commit":{"parents":[{"commit":"b125e005bbf4d40360b77482981662df97468c84","subject":"Fix zone serial increment on description-only update","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/b125e005bbf4d40360b77482981662df97468c84"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-09-21 10:49:46.000000000","tz":120},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-09-21 10:50:50.000000000","tz":120},"subject":"Fix zone serial increment on pool_id-only update","message":"Fix zone serial increment on pool_id-only update\n\nFollowing the fix for bug 1960487, the zone update endpoint\ndetermined whether to increment the DNS serial using a denylist\n(any changed field except description). This still treated pool_id\nas a DNS-propagated field, even though it is not sent to\nnameservers, causing an unnecessary serial bump and NOTIFY message.\n\nReplace the denylist with an explicit allowlist of the fields that\nare actually propagated to nameservers (email, ttl), added as\nZONE_DNS_FIELDS in designate.common.constants. This also prevents\nany future non-DNS zone field from silently regressing into the\nsame bug.\n\nCloses-Bug: #2167835\nGenerated-By: Claude Code 5 Sonnet\nChange-Id: I004be509e19eb17cc2678c344f05fb5945886f81\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/9a969b4d36a747a7266ebb25ef28e91723d8f6cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/9a969b4d36a747a7266ebb25ef28e91723d8f6cf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}