)]}'
{"designate/central/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"a4d921d559fe7e9323a1c297e28676bc7b191e52","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        self._is_valid_domain_name(context, domain.name)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        # Ensure TTL is above the minimum"},{"line_number":505,"context_line":"        if hasattr(domain, \u0027ttl\u0027) and domain.ttl is not None:"},{"line_number":506,"context_line":"            self._is_valid_ttl(context, domain.ttl)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        # Handle sub-domains appropriately"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4c6b90b8","line":505,"updated":"2014-06-23 21:34:42.000000000","message":"A change similar to the one on line 488 is needed here.","commit_id":"d7d7ca266d47f513aa8130bdc9a4f2636ee46cb2"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"dc1c2c47da8f1e8ec3b23375b3a96beee2d805d9","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        self._is_valid_domain_name(context, domain.name)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        # Ensure TTL is above the minimum"},{"line_number":505,"context_line":"        if hasattr(domain, \u0027ttl\u0027) and domain.ttl is not None:"},{"line_number":506,"context_line":"            self._is_valid_ttl(context, domain.ttl)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        # Handle sub-domains appropriately"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_5f921059","line":505,"in_reply_to":"1ae5cdf2_4c6b90b8","updated":"2014-06-24 14:32:40.000000000","message":"Done","commit_id":"d7d7ca266d47f513aa8130bdc9a4f2636ee46cb2"}],"designate/objects/base.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"a4d921d559fe7e9323a1c297e28676bc7b191e52","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\" Build getter and setter methods for all the objects attributes \"\"\""},{"line_number":29,"context_line":"    cls.FIELDS \u003d list(cls.FIELDS)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    for supercls in cls.mro()[1:-1]:"},{"line_number":32,"context_line":"        if not hasattr(supercls, \u0027FIELDS\u0027):"},{"line_number":33,"context_line":"            continue"},{"line_number":34,"context_line":"        for field in supercls.FIELDS:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c54af25a","line":31,"updated":"2014-06-23 21:34:42.000000000","message":"Is it the metaclass or the class itself at [0] - that you are excluding?","commit_id":"d7d7ca266d47f513aa8130bdc9a4f2636ee46cb2"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"dc1c2c47da8f1e8ec3b23375b3a96beee2d805d9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\" Build getter and setter methods for all the objects attributes \"\"\""},{"line_number":29,"context_line":"    cls.FIELDS \u003d list(cls.FIELDS)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    for supercls in cls.mro()[1:-1]:"},{"line_number":32,"context_line":"        if not hasattr(supercls, \u0027FIELDS\u0027):"},{"line_number":33,"context_line":"            continue"},{"line_number":34,"context_line":"        for field in supercls.FIELDS:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_a81a1bc4","line":31,"in_reply_to":"1ae5cdf2_c54af25a","updated":"2014-06-24 14:32:40.000000000","message":"0 is the current class, and the final item is the base \"object\" class which we skip as it\u0027s never going to have a FIELDS property.","commit_id":"d7d7ca266d47f513aa8130bdc9a4f2636ee46cb2"}],"designate/objects/record.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e57ef3d1c628618b3c2571d4d124c86f2ed5b3ea","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Record, self).__init__(*args, **kwargs)"},{"line_number":29,"context_line":"        if len(self.RRDATA_FIELDS) \u003e 0:"},{"line_number":30,"context_line":"            self.from_text()"},{"line_number":31,"context_line":"            self.to_text()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_532eba8d","line":29,"updated":"2014-06-23 14:15:06.000000000","message":"Did we not remove the RRDATA_FIELDS from the object for each type?","commit_id":"d7d7ca266d47f513aa8130bdc9a4f2636ee46cb2"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"6a7461b9435adac98672a733671a695d26a27aee","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Record, self).__init__(*args, **kwargs)"},{"line_number":29,"context_line":"        if len(self.RRDATA_FIELDS) \u003e 0:"},{"line_number":30,"context_line":"            self.from_text()"},{"line_number":31,"context_line":"            self.to_text()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ff54dbff","line":29,"in_reply_to":"1ae5cdf2_532eba8d","updated":"2014-06-23 20:23:14.000000000","message":"Aha.. Yes, we did..","commit_id":"d7d7ca266d47f513aa8130bdc9a4f2636ee46cb2"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"dc1c2c47da8f1e8ec3b23375b3a96beee2d805d9","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Record, self).__init__(*args, **kwargs)"},{"line_number":29,"context_line":"        if len(self.RRDATA_FIELDS) \u003e 0:"},{"line_number":30,"context_line":"            self.from_text()"},{"line_number":31,"context_line":"            self.to_text()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_160152af","line":29,"in_reply_to":"1ae5cdf2_ff54dbff","updated":"2014-06-24 14:32:40.000000000","message":"Okay - I\u0027ve removed this code for now, as it\u0027s not currently used. My next patchset will re-introduce it.\n\nI\u0027ve made it a separate change, as it will have some other significant changes which don\u0027t belong in this commit.","commit_id":"d7d7ca266d47f513aa8130bdc9a4f2636ee46cb2"}]}