)]}'
{"designate/api/middleware.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"51207edfe077a8b2ab8692b9f5874d0dedd532e5","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def _handle_exception(self, request, e, status\u003d500, response\u003d{}):"},{"line_number":216,"context_line":"        # Log the exception ASAP unless it is a 404 Not Found"},{"line_number":217,"context_line":"        if status !\u003d 404:"},{"line_number":218,"context_line":"            LOG.exception(e)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        headers \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_b95c2b1b","line":217,"updated":"2014-06-23 23:20:43.000000000","message":"Is there a reason not to log 404\u0027s?\nSometimes we see that when the user\u0027s instances are changed but when their programs/links still refer to the old instances, we see 404\u0027s. It would be useful to know about these kinds of errors, especially if they are a lot of such queries.","commit_id":"f43d887eaf27092bf5dad2bb6b3ae940b7261b68"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"eca522ac324db85fc98da73ac72002da0e79c3a3","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def _handle_exception(self, request, e, status\u003d500, response\u003d{}):"},{"line_number":216,"context_line":"        # Log the exception ASAP unless it is a 404 Not Found"},{"line_number":217,"context_line":"        if status !\u003d 404:"},{"line_number":218,"context_line":"            LOG.exception(e)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        headers \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_9a34aee0","line":217,"in_reply_to":"1ae5cdf2_b95c2b1b","updated":"2014-06-24 11:00:37.000000000","message":"404\u0027s are still logged by the API, this just stops us dumping a stack trace into the logs every time there is a 404","commit_id":"f43d887eaf27092bf5dad2bb6b3ae940b7261b68"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"5dd88ff4176064a6c4c263282ec8d537aa786167","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def _handle_exception(self, request, e, status\u003d500, response\u003d{}):"},{"line_number":216,"context_line":"        # Log the exception ASAP unless it is a 404 Not Found"},{"line_number":217,"context_line":"        if not e.expected:"},{"line_number":218,"context_line":"            LOG.exception(e)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        headers \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_10878db7","line":217,"updated":"2014-06-24 19:06:17.000000000","message":"With other exceptions I see the following error in the log\n\u003c\u003c\u003cRest of the stack trace snipped \u003e\u003e\u003e\n  File \"/home/vagrant/designate/designate_src/designate/api/middleware.py\", line 217, in _handle_exception\n    if not e.expected:\nAttributeError: \u0027InvalidObject\u0027 object has no attribute \u0027expected\u0027","commit_id":"4ade9463f83a5ba15cf3407fa7cb9ef98890a5b5"}]}