)]}'
{"designate/api/v1/domains.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"43e0c8f1788fc3dc51f6a49e7cfd459081fff6b9","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"@blueprint.route(\u0027/domains\u0027, methods\u003d[\u0027POST\u0027])"},{"line_number":52,"context_line":"def create_domain():"},{"line_number":53,"context_line":"    unwanted_attributes \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027id\u0027, \u0027serial\u0027]"},{"line_number":54,"context_line":"    context \u003d flask.request.environ.get(\u0027context\u0027)"},{"line_number":55,"context_line":"    values \u003d flask.request.json"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_051c3876","line":53,"updated":"2014-07-26 16:17:08.000000000","message":"Instead of defining unwanted_attributes - could you delete valid values and then check for valid values similar to what we do in v2 - see https://github.com/openstack/designate/blob/master/designate/api/v2/views/base.py#L97-109.  Also when you make updates and upload the new changes - please ensure that the changeid is the same.  See https://wiki.openstack.org/wiki/GerritWorkflow#Updating_a_Change for more details on this.  This makes it easy to compare the different patchsets","commit_id":"cc1faca248a2c8e7c33f8c9f70f4ec9e986860c0"}]}