)]}'
{"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"095e61127a16fe35809553616a237f5884ac6ee2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            extra \u003d {}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            if map is not None:"},{"line_number":63,"context_line":"                extra \u003d map(model)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"            obj.objects.append("},{"line_number":66,"context_line":"                _set_object_from_model(obj.LIST_ITEM_TYPE(), model, **extra))"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_bb453317","line":63,"updated":"2014-07-15 20:53:48.000000000","message":"minor - not necessary to fix.  could the name map be changed to something else so that it does not conflict with the built-in function map?","commit_id":"ee371f0873e02afae127f0801677c879d4f13387"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ba8ebabc3ef8df5014aa294ca38530e465eb52c0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            extra \u003d {}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            if map is not None:"},{"line_number":63,"context_line":"                extra \u003d map(model)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"            obj.objects.append("},{"line_number":66,"context_line":"                _set_object_from_model(obj.LIST_ITEM_TYPE(), model, **extra))"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a3468f79","line":63,"in_reply_to":"baada198_bb453317","updated":"2014-07-17 14:15:33.000000000","message":"Done","commit_id":"ee371f0873e02afae127f0801677c879d4f13387"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"095e61127a16fe35809553616a237f5884ac6ee2","unresolved":false,"context_lines":[{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        if recordset.obj_attr_is_set(\u0027records\u0027):"},{"line_number":559,"context_line":"            for record in recordset.records:"},{"line_number":560,"context_line":"                self.create_record(context, domain_id, storage_recordset.id,"},{"line_number":561,"context_line":"                                   record)"},{"line_number":562,"context_line":"        else:"},{"line_number":563,"context_line":"            recordset.records \u003d objects.RecordList()"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_fbbecbad","line":560,"updated":"2014-07-15 20:53:48.000000000","message":"Are the records and recordsets created in a single transaction?  If there is some issue with the records, would the recordset creation be rolled back?","commit_id":"ee371f0873e02afae127f0801677c879d4f13387"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ba8ebabc3ef8df5014aa294ca38530e465eb52c0","unresolved":false,"context_lines":[{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        if recordset.obj_attr_is_set(\u0027records\u0027):"},{"line_number":559,"context_line":"            for record in recordset.records:"},{"line_number":560,"context_line":"                self.create_record(context, domain_id, storage_recordset.id,"},{"line_number":561,"context_line":"                                   record)"},{"line_number":562,"context_line":"        else:"},{"line_number":563,"context_line":"            recordset.records \u003d objects.RecordList()"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_031f3bb8","line":560,"in_reply_to":"baada198_fbbecbad","updated":"2014-07-17 14:15:33.000000000","message":"Yes, the TX is managed by central, and lasts the length of the RPC call to central.","commit_id":"ee371f0873e02afae127f0801677c879d4f13387"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"095e61127a16fe35809553616a237f5884ac6ee2","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        if recordset.obj_attr_is_set(\u0027records\u0027):"},{"line_number":559,"context_line":"            for record in recordset.records:"},{"line_number":560,"context_line":"                self.create_record(context, domain_id, storage_recordset.id,"},{"line_number":561,"context_line":"                                   record)"},{"line_number":562,"context_line":"        else:"},{"line_number":563,"context_line":"            recordset.records \u003d objects.RecordList()"},{"line_number":564,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_7b855b06","line":561,"updated":"2014-07-15 20:53:48.000000000","message":"In this case, instead of setting records to what is passed in recordset.records, it should be set to the output(s) of self.create_record","commit_id":"ee371f0873e02afae127f0801677c879d4f13387"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ba8ebabc3ef8df5014aa294ca38530e465eb52c0","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        if recordset.obj_attr_is_set(\u0027records\u0027):"},{"line_number":559,"context_line":"            for record in recordset.records:"},{"line_number":560,"context_line":"                self.create_record(context, domain_id, storage_recordset.id,"},{"line_number":561,"context_line":"                                   record)"},{"line_number":562,"context_line":"        else:"},{"line_number":563,"context_line":"            recordset.records \u003d objects.RecordList()"},{"line_number":564,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a3d3efd3","line":561,"in_reply_to":"baada198_7b855b06","updated":"2014-07-17 14:15:33.000000000","message":"It looks weird, and I\u0027ll add a note here about it, but we\u0027re already doing that.\n\nSince the objects are a mutable type, the changes made by the create_record method (like setting the id field, or timestamps etc) are applied to the original list.\n\nIf we explicitly did a replace of the list item for the return value, we would literally be swapping the value for itself.","commit_id":"ee371f0873e02afae127f0801677c879d4f13387"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"095e61127a16fe35809553616a237f5884ac6ee2","unresolved":false,"context_lines":[{"line_number":652,"context_line":"            self.session.refresh(storage_recordset)"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        return _set_object_from_model(recordset, storage_recordset,"},{"line_number":655,"context_line":"                                      records\u003drecordset.records)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    def delete_recordset(self, context, recordset_id):"},{"line_number":658,"context_line":"        recordset \u003d self._find_recordsets(context, {\u0027id\u0027: recordset_id},"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_9355abfc","line":655,"updated":"2014-07-15 20:53:48.000000000","message":"Again here recordset.records seems to be the input that is returned and not what is in storage.","commit_id":"ee371f0873e02afae127f0801677c879d4f13387"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"ba8ebabc3ef8df5014aa294ca38530e465eb52c0","unresolved":false,"context_lines":[{"line_number":652,"context_line":"            self.session.refresh(storage_recordset)"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        return _set_object_from_model(recordset, storage_recordset,"},{"line_number":655,"context_line":"                                      records\u003drecordset.records)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    def delete_recordset(self, context, recordset_id):"},{"line_number":658,"context_line":"        recordset \u003d self._find_recordsets(context, {\u0027id\u0027: recordset_id},"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_03e49baa","line":655,"in_reply_to":"baada198_9355abfc","updated":"2014-07-17 14:15:33.000000000","message":"See above, also adding a note here.","commit_id":"ee371f0873e02afae127f0801677c879d4f13387"}]}