)]}'
{"designate/backend/impl_powerdns/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"594796d8568a66e813054e5e1f20f815f826d3c3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        global LOCAL_STORE"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if not hasattr(self.local_store, \u0027session\u0027):"},{"line_number":78,"context_line":"            self.local_store.session \u003d session.get_session(self.name)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return self.local_store.session"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6ff42387","line":78,"updated":"2014-07-25 00:32:58.000000000","message":"Now that you have an __init__, could you set self.local_store.session in there, so we need not do the if check everytime?","commit_id":"2e0f77d9c665be514241e871d354da233a97af0c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c1ce965484af8d067059f272f3b8bc9be8cd5285","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        global LOCAL_STORE"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if not hasattr(self.local_store, \u0027session\u0027):"},{"line_number":78,"context_line":"            self.local_store.session \u003d session.get_session(self.name)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return self.local_store.session"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0586f864","line":78,"in_reply_to":"baada198_6ff42387","updated":"2014-07-26 12:27:52.000000000","message":"No - that would re-introduce the original bug :)\n\n__init__ is ran once per process, while we need the session to be an per-thread thing","commit_id":"2e0f77d9c665be514241e871d354da233a97af0c"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"594796d8568a66e813054e5e1f20f815f826d3c3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        #       leads to bad things happening."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if not hasattr(self.local_store, \u0027session\u0027):"},{"line_number":93,"context_line":"            self.local_store.session \u003d session.get_session(self.name)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return self.local_store.session"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0f08077f","line":93,"updated":"2014-07-25 00:32:58.000000000","message":"Now that you set self.local_store in __init__, could you set self.local_store.session in there, so we need not do the if check everytime?","commit_id":"2e0f77d9c665be514241e871d354da233a97af0c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c1ce965484af8d067059f272f3b8bc9be8cd5285","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        #       leads to bad things happening."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if not hasattr(self.local_store, \u0027session\u0027):"},{"line_number":93,"context_line":"            self.local_store.session \u003d session.get_session(self.name)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return self.local_store.session"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_25793c82","line":93,"in_reply_to":"baada198_0f08077f","updated":"2014-07-26 12:27:52.000000000","message":"No - that would re-introduce the original bug :)\n\n__init__ is ran once per process, while we need the session to be an per-thread thing","commit_id":"2e0f77d9c665be514241e871d354da233a97af0c"}]}