)]}'
{"designate/central/service.py":[{"author":{"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"},"change_message_id":"6061e293ed88c3b15db16ea7528a7251b4944d08","unresolved":false,"context_lines":[{"line_number":947,"context_line":"        # NOTE(kiall): Set the Record recordset_id to match the recordset_id"},{"line_number":948,"context_line":"        #              supplied, this should be pushed out to the API layer"},{"line_number":949,"context_line":"        #              in another review."},{"line_number":950,"context_line":"        record.recordset_id \u003d recordset_id"},{"line_number":951,"context_line":""},{"line_number":952,"context_line":"        # Ensure the tenant has enough quota to continue"},{"line_number":953,"context_line":"        self._enforce_record_quota(context, domain, recordset)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b8c75545","line":950,"updated":"2014-08-01 16:34:01.000000000","message":"Can\u0027t we do the same for domain_id (and/or tenant_id) which are available in this method? Since that information is also available when calling create_record from create_recordset in sqlalchemy. This could save 2 queries for every record create.","commit_id":"60400f4aba252da92e2271cb48ba021836d870c0"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"},"change_message_id":"9fbbdff883c35e2a99e4f80114ddae2a50ffd6fd","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        record.tenant_id \u003d select([tables.recordsets.c.tenant_id]).\\"},{"line_number":699,"context_line":"            where(tables.recordsets.c.id \u003d\u003d record.recordset_id).\\"},{"line_number":700,"context_line":"            limit(1)"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        record.domain_id \u003d select([tables.recordsets.c.domain_id]).\\"},{"line_number":703,"context_line":"            where(tables.recordsets.c.id \u003d\u003d record.recordset_id).\\"},{"line_number":704,"context_line":"            limit(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0b938a00","line":701,"updated":"2014-08-01 18:33:49.000000000","message":"I don\u0027t have enough experience with SQLAlchemy but is it possible to reduce these 2 queries to a single one since the same row is going to be returned? (Please ignore if irrelevant) :)","commit_id":"60400f4aba252da92e2271cb48ba021836d870c0"}]}