)]}'
{"designate/central/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"907b053de68d506bfa3537606abf8a20a947004c","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        elevated_context.all_tenants \u003d True"},{"line_number":509,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":510,"context_line":"        # Create a new NS recordset for for every zone"},{"line_number":511,"context_line":"        for z in zones:"},{"line_number":512,"context_line":"            self._add_ns(elevated_context, z, server)"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        return created_server"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_3eab64d7","line":511,"updated":"2014-09-02 19:24:03.000000000","message":"create_server updates the NS records but the serial is not updated - _add_ns, could call update_recordset with increment_serial\u003dTrue (Line 418)","commit_id":"47047f6bd868c568d8e44b0deff00c0ea97382d4"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"eb4f54eed33d915520b9ea0ff624a046ecdbbc98","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        elevated_context.all_tenants \u003d True"},{"line_number":509,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":510,"context_line":"        # Create a new NS recordset for for every zone"},{"line_number":511,"context_line":"        for z in zones:"},{"line_number":512,"context_line":"            self._add_ns(elevated_context, z, server)"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        return created_server"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_3e47e41e","line":511,"in_reply_to":"fa98f980_3eab64d7","updated":"2014-09-02 19:29:19.000000000","message":"If creating a server should update the serial number, then I think that call should be made inside the create_server function. I don\u0027t think that exposing the SOA/NS records should change the behavior of the existing code.","commit_id":"47047f6bd868c568d8e44b0deff00c0ea97382d4"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"907b053de68d506bfa3537606abf8a20a947004c","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        elevated_context.all_tenants \u003d True"},{"line_number":548,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":549,"context_line":"        for z in zones:"},{"line_number":550,"context_line":"            self._update_ns(elevated_context, z, orig_server_name,"},{"line_number":551,"context_line":"                            new_server_name)"},{"line_number":552,"context_line":"            # Also Update the SOA recordset"},{"line_number":553,"context_line":"            self._update_soa(context, z)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_3b5a9650","line":550,"updated":"2014-09-02 19:24:03.000000000","message":"Similar to create_server\n\nupdate_server updates the NS and SOA records but the serial is not updated - _update_ns, could call update_recordset with increment_serial\u003dTrue (Line 403)\n\nIn that case we need not call _update_soa below","commit_id":"47047f6bd868c568d8e44b0deff00c0ea97382d4"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"eb4f54eed33d915520b9ea0ff624a046ecdbbc98","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        elevated_context.all_tenants \u003d True"},{"line_number":548,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":549,"context_line":"        for z in zones:"},{"line_number":550,"context_line":"            self._update_ns(elevated_context, z, orig_server_name,"},{"line_number":551,"context_line":"                            new_server_name)"},{"line_number":552,"context_line":"            # Also Update the SOA recordset"},{"line_number":553,"context_line":"            self._update_soa(context, z)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_de5978ff","line":550,"in_reply_to":"fa98f980_3b5a9650","updated":"2014-09-02 19:29:19.000000000","message":"Same as above. If an action needs to update the serial number, it should be doing that separately from the NS recordset.","commit_id":"47047f6bd868c568d8e44b0deff00c0ea97382d4"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"907b053de68d506bfa3537606abf8a20a947004c","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        elevated_context \u003d context.elevated()"},{"line_number":571,"context_line":"        elevated_context.all_tenants \u003d True"},{"line_number":572,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":573,"context_line":"        for z in zones:"},{"line_number":574,"context_line":"            self._delete_ns(elevated_context, z, server)"},{"line_number":575,"context_line":"            # Also, update the SOA recordset"},{"line_number":576,"context_line":"            self._update_soa(context, z)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_1e42203e","line":573,"updated":"2014-09-02 19:24:03.000000000","message":"Similar to create_server and update_server\n\ndelete_server updates the NS and SOA records but the serial is not updated - _delete_ns, could call update_recordset with increment_serial\u003dTrue (Line 430)\n\nIn that case we need not call _update_soa below","commit_id":"47047f6bd868c568d8e44b0deff00c0ea97382d4"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"eb4f54eed33d915520b9ea0ff624a046ecdbbc98","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        elevated_context \u003d context.elevated()"},{"line_number":571,"context_line":"        elevated_context.all_tenants \u003d True"},{"line_number":572,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":573,"context_line":"        for z in zones:"},{"line_number":574,"context_line":"            self._delete_ns(elevated_context, z, server)"},{"line_number":575,"context_line":"            # Also, update the SOA recordset"},{"line_number":576,"context_line":"            self._update_soa(context, z)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_9e0610cd","line":573,"in_reply_to":"fa98f980_1e42203e","updated":"2014-09-02 19:29:19.000000000","message":"Same as above. Since those functions don\u0027t currently update the serial number on their own, I don\u0027t think the NS recordset should do that.","commit_id":"47047f6bd868c568d8e44b0deff00c0ea97382d4"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"907b053de68d506bfa3537606abf8a20a947004c","unresolved":false,"context_lines":[{"line_number":996,"context_line":"        # Only increment the serial # if records exist and"},{"line_number":997,"context_line":"        # increment_serial \u003d True"},{"line_number":998,"context_line":"        if len(recordset.records) \u003e 0:"},{"line_number":999,"context_line":"            if increment_serial:"},{"line_number":1000,"context_line":"                self._increment_domain_serial(context, domain.id)"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        # Get the correct format for priority"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_3b69b625","line":999,"updated":"2014-09-02 19:24:03.000000000","message":"Minor - Exchanging these if tests makes better sense for me  i.e\n\nif increment_serial:\n    if len(recordset.records) \u003e  0:","commit_id":"47047f6bd868c568d8e44b0deff00c0ea97382d4"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"eb4f54eed33d915520b9ea0ff624a046ecdbbc98","unresolved":false,"context_lines":[{"line_number":996,"context_line":"        # Only increment the serial # if records exist and"},{"line_number":997,"context_line":"        # increment_serial \u003d True"},{"line_number":998,"context_line":"        if len(recordset.records) \u003e 0:"},{"line_number":999,"context_line":"            if increment_serial:"},{"line_number":1000,"context_line":"                self._increment_domain_serial(context, domain.id)"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        # Get the correct format for priority"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_be0914df","line":999,"in_reply_to":"fa98f980_3b69b625","updated":"2014-09-02 19:29:19.000000000","message":"True. I\u0027ll fix that.","commit_id":"47047f6bd868c568d8e44b0deff00c0ea97382d4"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"9bd8500a3910fad2f8ff66c464369b63381d13f6","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        for r in ns.records:"},{"line_number":401,"context_line":"            if r.data \u003d\u003d orig_name:"},{"line_number":402,"context_line":"                r.data \u003d new_name"},{"line_number":403,"context_line":"                self.update_recordset(context, ns, increment_serial\u003dFalse)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def _add_ns(self, context, zone, server):"},{"line_number":406,"context_line":"        # Get NS recordset"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_850bfe28","line":403,"updated":"2014-09-03 12:50:29.000000000","message":"I think the `increment_serial\u003dFalse` should be removed here to fully fix the bug.","commit_id":"66869ae109128e5a5123b8d39cce250db2e014c0"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"9bd8500a3910fad2f8ff66c464369b63381d13f6","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        ns.records.append(new_record)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        self.update_recordset(context, ns, increment_serial\u003dFalse)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def _delete_ns(self, context, zone, server):"},{"line_number":421,"context_line":"        ns \u003d self.find_recordset(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_2511725d","line":418,"updated":"2014-09-03 12:50:29.000000000","message":"I think the `increment_serial\u003dFalse` should be removed here to fully fix the bug.","commit_id":"66869ae109128e5a5123b8d39cce250db2e014c0"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"9bd8500a3910fad2f8ff66c464369b63381d13f6","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            if r.data \u003d\u003d server.name:"},{"line_number":428,"context_line":"                ns.records.remove(r)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        self.update_recordset(context, ns, increment_serial\u003dFalse)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    # Quota Enforcement Methods"},{"line_number":433,"context_line":"    def _enforce_domain_quota(self, context, tenant_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_650e1a3d","line":430,"updated":"2014-09-03 12:50:29.000000000","message":"I think the `increment_serial\u003dFalse` should be removed here to fully fix the bug.","commit_id":"66869ae109128e5a5123b8d39cce250db2e014c0"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"68df0864e103074cac3b95e8233d6a0a1e60ce7e","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        # Update NS recordsets for all zones"},{"line_number":507,"context_line":"        elevated_context \u003d context.elevated()"},{"line_number":508,"context_line":"        elevated_context.all_tenants \u003d True"},{"line_number":509,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":510,"context_line":"        # Create a new NS recordset for for every zone"},{"line_number":511,"context_line":"        for z in zones:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_9c3994d9","line":508,"updated":"2014-09-03 15:38:10.000000000","message":"Just a comment - When there are no domains, I thought this would throw a DomainNotFound exception which would fail the create_server call. But we actually return an empty list - so everything works correctly","commit_id":"dd4f5d31a850cda10ffd2464da4fc9666be9398f"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"68df0864e103074cac3b95e8233d6a0a1e60ce7e","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        for z in zones:"},{"line_number":550,"context_line":"            self._update_ns(elevated_context, z, orig_server_name,"},{"line_number":551,"context_line":"                            new_server_name)"},{"line_number":552,"context_line":"            # Also Update the SOA recordset"},{"line_number":553,"context_line":"            self._update_soa(context, z)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        return server"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_66137d0d","line":552,"updated":"2014-09-03 15:38:10.000000000","message":"_update_ns increments the serial number, which in turn calls _update_soa - so there is no need to call _update_soa again here.","commit_id":"dd4f5d31a850cda10ffd2464da4fc9666be9398f"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"bfeeddfe8757ef1232368fec8160e7f4453e017d","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        for z in zones:"},{"line_number":550,"context_line":"            self._update_ns(elevated_context, z, orig_server_name,"},{"line_number":551,"context_line":"                            new_server_name)"},{"line_number":552,"context_line":"            # Also Update the SOA recordset"},{"line_number":553,"context_line":"            self._update_soa(context, z)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        return server"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_1c33e463","line":552,"in_reply_to":"fa98f980_66137d0d","updated":"2014-09-03 15:45:03.000000000","message":"Done","commit_id":"dd4f5d31a850cda10ffd2464da4fc9666be9398f"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"68df0864e103074cac3b95e8233d6a0a1e60ce7e","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":573,"context_line":"        for z in zones:"},{"line_number":574,"context_line":"            self._delete_ns(elevated_context, z, server)"},{"line_number":575,"context_line":"            # Also, update the SOA recordset"},{"line_number":576,"context_line":"            self._update_soa(context, z)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        # Update backend with the new server.."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_26db3551","line":575,"updated":"2014-09-03 15:38:10.000000000","message":"_delete_ns increments the serial number, which in turn calls _update_soa - so there is no need to call _update_soa again here.","commit_id":"dd4f5d31a850cda10ffd2464da4fc9666be9398f"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"bfeeddfe8757ef1232368fec8160e7f4453e017d","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        zones \u003d self.find_domains(elevated_context)"},{"line_number":573,"context_line":"        for z in zones:"},{"line_number":574,"context_line":"            self._delete_ns(elevated_context, z, server)"},{"line_number":575,"context_line":"            # Also, update the SOA recordset"},{"line_number":576,"context_line":"            self._update_soa(context, z)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        # Update backend with the new server.."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_bcf01892","line":575,"in_reply_to":"fa98f980_26db3551","updated":"2014-09-03 15:45:03.000000000","message":"Done","commit_id":"dd4f5d31a850cda10ffd2464da4fc9666be9398f"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"68df0864e103074cac3b95e8233d6a0a1e60ce7e","unresolved":false,"context_lines":[{"line_number":996,"context_line":"        # Only increment the serial # if records exist and"},{"line_number":997,"context_line":"        # increment_serial \u003d True"},{"line_number":998,"context_line":"        if increment_serial:"},{"line_number":999,"context_line":"            LOG.debug(\"Increment serial is True\")"},{"line_number":1000,"context_line":"            if len(recordset.records) \u003e 0:"},{"line_number":1001,"context_line":"                self._increment_domain_serial(context, domain.id)"},{"line_number":1002,"context_line":"                LOG.debug(\"Call increment serial number\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_c6e50939","line":999,"updated":"2014-09-03 15:38:10.000000000","message":"Are the debug statements needed?","commit_id":"dd4f5d31a850cda10ffd2464da4fc9666be9398f"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"bfeeddfe8757ef1232368fec8160e7f4453e017d","unresolved":false,"context_lines":[{"line_number":996,"context_line":"        # Only increment the serial # if records exist and"},{"line_number":997,"context_line":"        # increment_serial \u003d True"},{"line_number":998,"context_line":"        if increment_serial:"},{"line_number":999,"context_line":"            LOG.debug(\"Increment serial is True\")"},{"line_number":1000,"context_line":"            if len(recordset.records) \u003e 0:"},{"line_number":1001,"context_line":"                self._increment_domain_serial(context, domain.id)"},{"line_number":1002,"context_line":"                LOG.debug(\"Call increment serial number\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_7c4150a8","line":999,"in_reply_to":"fa98f980_c6e50939","updated":"2014-09-03 15:45:03.000000000","message":"Removed","commit_id":"dd4f5d31a850cda10ffd2464da4fc9666be9398f"}]}