)]}'
{"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"bcbbbaad84516123216d8159107c73fb3c824a26","unresolved":false,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    # RecordSet Methods"},{"line_number":544,"context_line":"    def _find_recordsets(self, context, criterion, one\u003dFalse, marker\u003dNone,"},{"line_number":545,"context_line":"                         limit\u003dNone, sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":546,"context_line":"        query \u003d None"},{"line_number":547,"context_line":"        if criterion is None or \u0027domain_id\u0027 not in criterion:"},{"line_number":548,"context_line":"            # Ensure that we return only active recordsets"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_369e8764","line":545,"updated":"2014-09-08 11:58:46.000000000","message":"actually - can we change the domain_id \u003d None test to a new parameter in the _find_recordsets() call ? \n\ndomains_deleted\u003dTrue? - and if it is set to false then do the custom query? \n\nthis will keep the API consistent, and will be similar to what we will have when we implement soft delete on the recordsets table","commit_id":"4f4e80b3fc56a8fa09bcc7a44dc168d840fd1680"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"fc00d4c16fd626763dfb9241821c118fa77f57dd","unresolved":false,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    # RecordSet Methods"},{"line_number":544,"context_line":"    def _find_recordsets(self, context, criterion, one\u003dFalse, marker\u003dNone,"},{"line_number":545,"context_line":"                         limit\u003dNone, sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":546,"context_line":"        query \u003d None"},{"line_number":547,"context_line":"        if criterion is None or \u0027domain_id\u0027 not in criterion:"},{"line_number":548,"context_line":"            # Ensure that we return only active recordsets"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_7df0e7c9","line":545,"in_reply_to":"fa98f980_369e8764","updated":"2014-09-08 15:53:19.000000000","message":"I called the parameter deleted_recordsets to make the intent more clear.","commit_id":"4f4e80b3fc56a8fa09bcc7a44dc168d840fd1680"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7b79d59a725c7611be0ffe8f8462ec9215161f0e","unresolved":false,"context_lines":[{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        return recordsets"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def find_recordset(self, context, criterion, deleted_recordsets\u003dTrue):"},{"line_number":610,"context_line":"        recordset \u003d self._find_recordsets("},{"line_number":611,"context_line":"            context, criterion, one\u003dTrue,"},{"line_number":612,"context_line":"            deleted_recordsets\u003ddeleted_recordsets)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_2817fb52","line":609,"updated":"2014-09-08 16:08:40.000000000","message":"Humm, this is still adding an API change to storage, which I was really hoping to avoid. \n\nI think what Graham was suggesting was to keep the current method API, and when \"\u0027deleted_domain\u0027: True\" is in in the criterion dictionary, we trigger the SQL join. Similar to you first patchset, but triggering on this:\n\n    if criterion is not None or \u0027domain_deleted\u0027 in criterion:\n\nrather than:\n\n    if criterion is None or \u0027domain_id\u0027 not in criterion:\n\nThis avoids adding new special purpose / temporary parameters to the method, and will allow for removing the JOIN if we decide the denormalize the domain\u0027s \"deleted\" column into the recordsets \"domain_deleted\" column.","commit_id":"8e8f514936b6494ea078fcf963a2cee8e1485700"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"4538892956c311d70fa7f51abd7fc3d37ff43755","unresolved":false,"context_lines":[{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        return recordsets"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def find_recordset(self, context, criterion, deleted_recordsets\u003dTrue):"},{"line_number":610,"context_line":"        recordset \u003d self._find_recordsets("},{"line_number":611,"context_line":"            context, criterion, one\u003dTrue,"},{"line_number":612,"context_line":"            deleted_recordsets\u003ddeleted_recordsets)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_43718076","line":609,"in_reply_to":"fa98f980_2817fb52","updated":"2014-09-08 16:16:48.000000000","message":"Not what I was suggesting but, it should work.\n\ndomain_deleted is more descriptive - as it should be about when domains are deleted, not recordsets.","commit_id":"8e8f514936b6494ea078fcf963a2cee8e1485700"}]}