)]}'
{"designate/backend/impl_powerdns/__init__.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a074553161df6db420d8c6138684e9df69bf9f38","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"            # Update the Records TTLs where necessary"},{"line_number":308,"context_line":"            query \u003d tables.records.update()\\"},{"line_number":309,"context_line":"                .where(tables.records.c.domain_id \u003d\u003d domain_ref[\u0027id\u0027])\\"},{"line_number":310,"context_line":"                .values(ttl\u003ddomain[\u0027ttl\u0027])"},{"line_number":311,"context_line":"            self.session.execute(query)"},{"line_number":312,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_0a25da09","line":309,"updated":"2014-09-08 10:00:49.000000000","message":"You dropped the where inherit_ttl\u003dTrue","commit_id":"8bb1e135dc167aafb6302d39c6e72069c9acd36f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bc7d474bf1d8d42ef6fe8cbbe7937edfc579aa41","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            # Delete this TSIG Key itself"},{"line_number":218,"context_line":"            self._delete("},{"line_number":219,"context_line":"                tables.tsigkeys, tsigkey[\u0027id\u0027],"},{"line_number":220,"context_line":"                exc_notfound\u003dexceptions.TsigKeyNotFound)"},{"line_number":221,"context_line":"        except exceptions.TsigKeyNotFound:"},{"line_number":222,"context_line":"            # If the TSIG Key is already gone, that\u0027s ok. We\u0027re deleting it"},{"line_number":223,"context_line":"            # anyway, so just log and continue."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_8cc002e2","line":220,"updated":"2014-09-08 18:49:07.000000000","message":"This needs an id_col, right?","commit_id":"bee547646e523214e2fb394852283f9c74cb768f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"efb582ef660627f6af94a5614015e7fd7389856d","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        return content"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def _sanitize_uuid_str(self, uuid):"},{"line_number":446,"context_line":"        return uuid.replace(\"-\", \"\")"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _build_soa_content(self, domain, servers):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_9f04e315","line":445,"updated":"2014-09-15 12:25:30.000000000","message":"Looks like this method is a merge-leftover, it was removed as it\u0027s unused.","commit_id":"47531198ff1f031bd6c13e86b6a5154ad59fac9b"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"efb582ef660627f6af94a5614015e7fd7389856d","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    def _sanitize_uuid_str(self, uuid):"},{"line_number":446,"context_line":"        return uuid.replace(\"-\", \"\")"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _build_soa_content(self, domain, servers):"},{"line_number":449,"context_line":"        return \"%s %s. %d %d %d %d %d\" % (servers[0][\u0027name\u0027],"},{"line_number":450,"context_line":"                                          domain[\u0027email\u0027].replace(\"@\", \".\"),"},{"line_number":451,"context_line":"                                          domain[\u0027serial\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_bf07e716","line":448,"updated":"2014-09-15 12:25:30.000000000","message":"Looks like this method is a merge-leftover, it was removed as it should be unused now.","commit_id":"47531198ff1f031bd6c13e86b6a5154ad59fac9b"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        results \u003d resultproxy.fetchall()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if len(results) !\u003d 1:"},{"line_number":127,"context_line":"            raise exc_notfound()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Map col keys to values in result"},{"line_number":130,"context_line":"        return _map_col(query.columns.keys(), results[0])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_5cc0377c","line":127,"updated":"2014-09-24 21:00:56.000000000","message":"What if exc_notfound is None?","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a7142468fa9da9187f221f4c8bff36530139576e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        results \u003d resultproxy.fetchall()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if len(results) !\u003d 1:"},{"line_number":127,"context_line":"            raise exc_notfound()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Map col keys to values in result"},{"line_number":130,"context_line":"        return _map_col(query.columns.keys(), results[0])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_9b7c53b7","line":127,"in_reply_to":"da9df570_5cc0377c","updated":"2014-09-25 13:08:54.000000000","message":"Done","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        resultproxy \u003d self.session.execute(query)"},{"line_number":140,"context_line":"        if resultproxy.rowcount !\u003d 1:"},{"line_number":141,"context_line":"            raise exc_notfound()"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    # TSIG Key Methods"},{"line_number":144,"context_line":"    def create_tsigkey(self, context, tsigkey):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_bc3843a1","line":141,"updated":"2014-09-24 21:00:56.000000000","message":"What if exc_notfound is None?","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a7142468fa9da9187f221f4c8bff36530139576e","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        resultproxy \u003d self.session.execute(query)"},{"line_number":140,"context_line":"        if resultproxy.rowcount !\u003d 1:"},{"line_number":141,"context_line":"            raise exc_notfound()"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    # TSIG Key Methods"},{"line_number":144,"context_line":"    def create_tsigkey(self, context, tsigkey):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_7b7fafab","line":141,"in_reply_to":"da9df570_bc3843a1","updated":"2014-09-25 13:08:54.000000000","message":"Done","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if content not in values:"},{"line_number":415,"context_line":"                if delete:"},{"line_number":416,"context_line":"                    LOG.debug(\u0027Deleting stale domain metadata: %r\u0027 %"},{"line_number":417,"context_line":"                              (domain_id, kind, content))"},{"line_number":418,"context_line":"                    # Delete no longer necessary values"},{"line_number":419,"context_line":"                    self._delete(tables.c.domain_metadata, metadata_id)"},{"line_number":420,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_9cb53f33","line":417,"updated":"2014-09-24 21:00:56.000000000","message":"This debug statement has more arguments than specified in the format string","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a7142468fa9da9187f221f4c8bff36530139576e","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if content not in values:"},{"line_number":415,"context_line":"                if delete:"},{"line_number":416,"context_line":"                    LOG.debug(\u0027Deleting stale domain metadata: %r\u0027 %"},{"line_number":417,"context_line":"                              (domain_id, kind, content))"},{"line_number":418,"context_line":"                    # Delete no longer necessary values"},{"line_number":419,"context_line":"                    self._delete(tables.c.domain_metadata, metadata_id)"},{"line_number":420,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_bb9d97be","line":417,"in_reply_to":"da9df570_9cb53f33","updated":"2014-09-25 13:08:54.000000000","message":"Done","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                    LOG.debug(\u0027Deleting stale domain metadata: %r\u0027 %"},{"line_number":417,"context_line":"                              (domain_id, kind, content))"},{"line_number":418,"context_line":"                    # Delete no longer necessary values"},{"line_number":419,"context_line":"                    self._delete(tables.c.domain_metadata, metadata_id)"},{"line_number":420,"context_line":"            else:"},{"line_number":421,"context_line":"                # Remove pre-existing values from the list of values to insert"},{"line_number":422,"context_line":"                values.remove(content)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_9ca9bf7d","line":419,"updated":"2014-09-24 21:00:56.000000000","message":"the 1st argument should be tables.domain_metadata?","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a7142468fa9da9187f221f4c8bff36530139576e","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                    LOG.debug(\u0027Deleting stale domain metadata: %r\u0027 %"},{"line_number":417,"context_line":"                              (domain_id, kind, content))"},{"line_number":418,"context_line":"                    # Delete no longer necessary values"},{"line_number":419,"context_line":"                    self._delete(tables.c.domain_metadata, metadata_id)"},{"line_number":420,"context_line":"            else:"},{"line_number":421,"context_line":"                # Remove pre-existing values from the list of values to insert"},{"line_number":422,"context_line":"                values.remove(content)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_dbf09b00","line":419,"in_reply_to":"da9df570_9ca9bf7d","updated":"2014-09-25 13:08:54.000000000","message":"Done","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        # Insert new values"},{"line_number":425,"context_line":"        for value in values:"},{"line_number":426,"context_line":"            LOG.debug(\u0027Inserting new domain metadata: %r\u0027 %"},{"line_number":427,"context_line":"                      (domain_id, kind, value))"},{"line_number":428,"context_line":"            self._create("},{"line_number":429,"context_line":"                tables.domain_metadata,"},{"line_number":430,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_bc83e354","line":427,"updated":"2014-09-24 21:00:56.000000000","message":"This debug statement has more arguments than specified in the format string","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a7142468fa9da9187f221f4c8bff36530139576e","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        # Insert new values"},{"line_number":425,"context_line":"        for value in values:"},{"line_number":426,"context_line":"            LOG.debug(\u0027Inserting new domain metadata: %r\u0027 %"},{"line_number":427,"context_line":"                      (domain_id, kind, value))"},{"line_number":428,"context_line":"            self._create("},{"line_number":429,"context_line":"                tables.domain_metadata,"},{"line_number":430,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_dba25bfc","line":427,"in_reply_to":"da9df570_bc83e354","updated":"2014-09-25 13:08:54.000000000","message":"Done","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"}],"designate/backend/impl_powerdns/tables.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012-2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Kiall Mac Innes \u003ckiall@hp.com\u003e"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_5c3677e8","line":3,"updated":"2014-09-24 21:00:56.000000000","message":"Do you want to claim authorship? :-)","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    Column(\u0027id\u0027, Integer, primary_key\u003dTrue, autoincrement\u003dTrue),"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Column(\u0027designate_id\u0027, UUID, nullable\u003dFalse),"},{"line_number":33,"context_line":"    Column(\u0027name\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":34,"context_line":"    Column(\u0027algorithm\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":35,"context_line":"    Column(\u0027secret\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":36,"context_line":"    mysql_engine\u003d\u0027InnboDB\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_f6b58cee","line":33,"updated":"2014-09-24 21:00:56.000000000","message":"For later - can name, algorithm and secret be nullable?  Also should name and secret be unique?","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    Column(\u0027name\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":34,"context_line":"    Column(\u0027algorithm\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":35,"context_line":"    Column(\u0027secret\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":36,"context_line":"    mysql_engine\u003d\u0027InnboDB\u0027,"},{"line_number":37,"context_line":"    mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"domain_metadata \u003d Table("}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_56e3b804","line":36,"updated":"2014-09-24 21:00:56.000000000","message":"Typo in InnoDb here and at other places below","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a7142468fa9da9187f221f4c8bff36530139576e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    Column(\u0027name\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":34,"context_line":"    Column(\u0027algorithm\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":35,"context_line":"    Column(\u0027secret\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":36,"context_line":"    mysql_engine\u003d\u0027InnboDB\u0027,"},{"line_number":37,"context_line":"    mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"domain_metadata \u003d Table("}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_bb4cb79f","line":36,"in_reply_to":"da9df570_56e3b804","updated":"2014-09-25 13:08:54.000000000","message":"Done","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Column(\u0027domain_id\u0027, Integer(), nullable\u003dFalse),"},{"line_number":44,"context_line":"    Column(\u0027kind\u0027, String(16), default\u003dNone, nullable\u003dTrue),"},{"line_number":45,"context_line":"    Column(\u0027content\u0027, Text()),"},{"line_number":46,"context_line":"    mysql_engine\u003d\u0027InnboDB\u0027,"},{"line_number":47,"context_line":"    mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_3696344d","line":45,"updated":"2014-09-24 21:00:56.000000000","message":"content here specifies Text() whereas content in records table specifies just Text.  Wonder what is the difference?","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a7142468fa9da9187f221f4c8bff36530139576e","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Column(\u0027domain_id\u0027, Integer(), nullable\u003dFalse),"},{"line_number":44,"context_line":"    Column(\u0027kind\u0027, String(16), default\u003dNone, nullable\u003dTrue),"},{"line_number":45,"context_line":"    Column(\u0027content\u0027, Text()),"},{"line_number":46,"context_line":"    mysql_engine\u003d\u0027InnboDB\u0027,"},{"line_number":47,"context_line":"    mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_3b27e7cb","line":45,"in_reply_to":"da9df570_3696344d","updated":"2014-09-25 13:08:54.000000000","message":"SQLA treats them the same in the end, if a instance is passed in.. it use it, if a class it passed it, it creates an instance and use it..\n\nFor the sake of consistency, I\u0027ve updated all of them to match.","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"c617d9858223daf90212be3a4360d858ebce0df2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    Column(\u0027prio\u0027, Integer, default\u003dNone, nullable\u003dTrue),"},{"line_number":75,"context_line":"    Column(\u0027change_date\u0027, Integer, default\u003dNone, nullable\u003dTrue),"},{"line_number":76,"context_line":"    Column(\u0027ordername\u0027, String(255), default\u003dNone, nullable\u003dTrue),"},{"line_number":77,"context_line":"    Column(\u0027auth\u0027, Boolean(), default\u003dNone, nullable\u003dTrue),"},{"line_number":78,"context_line":"    Column(\u0027inherit_ttl\u0027, Boolean(), default\u003dTrue),"},{"line_number":79,"context_line":"    mysql_engine\u003d\u0027InnboDB\u0027,"},{"line_number":80,"context_line":"    mysql_charset\u003d\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9df570_5678182b","line":77,"updated":"2014-09-24 21:00:56.000000000","message":"similar to the Text() vs Text question above - what is the difference between specifying Boolean vs Boolean()?","commit_id":"4522fd499fcc9028741bd2c4bde6010eefc2284d"}]}