)]}'
{"designate/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"fbefffc7d3257a90899aa861effde70622d2cf63","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.endpoints \u003d endpoints or [self]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def start(self):"},{"line_number":66,"context_line":"        super(RPCService, self).start()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        version_string \u003d version.version_info.version_string()"},{"line_number":69,"context_line":"        LOG.info(_(\u0027Starting %(topic)s node (version %(version_string)s)\u0027) %"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_bbb34209","line":66,"updated":"2014-09-08 11:23:35.000000000","message":"This is a belt+braces addition, the parent start() methods currently are no-ops, but this  should have been here regardless.","commit_id":"3202447e548856e8e8492b289ba5ca4408a3edb3"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"2dc8ac715e266d46fb124095d3f9ea2a5b0009f8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.service_name \u003d service_name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        policy.init()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # TODO(ekarlso): change this to be loadable via mod import or"},{"line_number":57,"context_line":"        # stevedore?"},{"line_number":58,"context_line":"        self.endpoints \u003d endpoints or [self]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_10097295","side":"PARENT","line":55,"updated":"2014-09-08 22:40:36.000000000","message":"Does policy.init now need to be called by either RPCService or the api and central?","commit_id":"aadfa1fdaef3b1b5d6a7e1fc24538aa55e2d3694"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"24ccae488f9357e8523d5b34b0a9890849ca0426","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.service_name \u003d service_name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        policy.init()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # TODO(ekarlso): change this to be loadable via mod import or"},{"line_number":57,"context_line":"        # stevedore?"},{"line_number":58,"context_line":"        self.endpoints \u003d endpoints or [self]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_d96707e9","side":"PARENT","line":55,"in_reply_to":"fa98f980_10097295","updated":"2014-09-09 11:41:46.000000000","message":"policy.init() is now called in the base Service class\u0027s __init__ - L43 on the right hand side. RPCService (and WSGIService, in the next review) both extend this.","commit_id":"aadfa1fdaef3b1b5d6a7e1fc24538aa55e2d3694"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"3d0f481be76debd07f817be5ea7a3f1c1b84c67f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.service_name \u003d service_name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        policy.init()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # TODO(ekarlso): change this to be loadable via mod import or"},{"line_number":57,"context_line":"        # stevedore?"},{"line_number":58,"context_line":"        self.endpoints \u003d endpoints or [self]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_e7afbd29","side":"PARENT","line":55,"in_reply_to":"fa98f980_d96707e9","updated":"2014-09-09 14:27:17.000000000","message":"Oops missed that.","commit_id":"aadfa1fdaef3b1b5d6a7e1fc24538aa55e2d3694"}]}