)]}'
{"designate/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"7d46caa634e31306989c75143c66c8674cd281c5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    Service class to be shared by all Designate WSGI Services"},{"line_number":134,"context_line":"    \"\"\""},{"line_number":135,"context_line":"    def __init__(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d4096,"},{"line_number":136,"context_line":"                 threads\u003d1000):"},{"line_number":137,"context_line":"        # NOTE(kiall): We avoid calling super(cls, self) here, as our parent"},{"line_number":138,"context_line":"        #              classes have different argspecs. Additionally, if we"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_706c7e37","line":135,"updated":"2014-09-08 22:45:40.000000000","message":"In api the default backlog is 128, here it is 4096.  Should they have the same default value?","commit_id":"66a1ea920d1e847af48cc49f3a331f940daa2be2"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b4583dc71bfa561f97187318270b72d51dd8330b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":"    Service class to be shared by all Designate WSGI Services"},{"line_number":134,"context_line":"    \"\"\""},{"line_number":135,"context_line":"    def __init__(self, application, port, host\u003d\u00270.0.0.0\u0027, backlog\u003d4096,"},{"line_number":136,"context_line":"                 threads\u003d1000):"},{"line_number":137,"context_line":"        # NOTE(kiall): We avoid calling super(cls, self) here, as our parent"},{"line_number":138,"context_line":"        #              classes have different argspecs. Additionally, if we"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_194b4f5a","line":135,"in_reply_to":"fa98f980_706c7e37","updated":"2014-09-09 11:40:20.000000000","message":"I copied this from the original wsgi.Service class which this extends, where the defaults are 4096 etc:\n\nhttps://github.com/openstack/designate/blob/master/designate/openstack/deprecated/wsgi.py#L77\n\nI think it makes sense to keep the defaults for the wsgi.Service (Now WSGIService) class unchanged..","commit_id":"66a1ea920d1e847af48cc49f3a331f940daa2be2"}]}