)]}'
{"designate/tests/test_storage/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"        actual \u003d self.storage.find_blacklists(self.admin_context)"},{"line_number":1688,"context_line":"        self.assertEqual(1, len(actual))"},{"line_number":1689,"context_line":""},{"line_number":1690,"context_line":"        self.assertEqual(blacklist[\u0027pattern\u0027], actual[0][\u0027pattern\u0027])"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"    def test_find_blacklists_paging(self):"},{"line_number":1693,"context_line":"        # Create 10 Blacklists"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_d2a35d4d","line":1690,"updated":"2014-09-23 16:14:35.000000000","message":"We are actually comparing 2 values returned by storage.  Instead can we compare actual to fixture?  Other places indicated below with (*\u0026@!$@!:-) also need the same fix.\n\nCould you also do the same fix for test_find_tlds?","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"d526556f7783bf0a6017196ba16295bf9d4c1a9d","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"        actual \u003d self.storage.find_blacklists(self.admin_context)"},{"line_number":1688,"context_line":"        self.assertEqual(1, len(actual))"},{"line_number":1689,"context_line":""},{"line_number":1690,"context_line":"        self.assertEqual(blacklist[\u0027pattern\u0027], actual[0][\u0027pattern\u0027])"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"    def test_find_blacklists_paging(self):"},{"line_number":1693,"context_line":"        # Create 10 Blacklists"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_8809a2df","line":1690,"in_reply_to":"da9df570_d2a35d4d","updated":"2014-09-23 16:34:31.000000000","message":"This is creating a blacklist, retrieving the blacklist from storage with the storage.find_blacklists and then compares the two. I see your point, that maybe we should use the fixture value instead, but this is the way ALL of these tests in storage are done (domains, recordsets, records, etc.) \n\nSame comment for the rest of them.","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1703,"context_line":"        blacklist_two \u003d self.create_blacklist(fixture\u003d1)"},{"line_number":1704,"context_line":""},{"line_number":1705,"context_line":"        # Verify blacklist_one"},{"line_number":1706,"context_line":"        criterion \u003d dict(pattern\u003dblacklist_one[\u0027pattern\u0027])"},{"line_number":1707,"context_line":""},{"line_number":1708,"context_line":"        results \u003d self.storage.find_blacklists(self.admin_context,"},{"line_number":1709,"context_line":"                                               criterion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_b50a431f","line":1706,"updated":"2014-09-23 16:14:35.000000000","message":"Could you do the pattern search based on fixture, rather than blacklist_one?","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"        results \u003d self.storage.find_blacklists(self.admin_context,"},{"line_number":1709,"context_line":"                                               criterion)"},{"line_number":1710,"context_line":"        self.assertEqual(len(results), 1)"},{"line_number":1711,"context_line":"        self.assertEqual(results[0][\u0027pattern\u0027], blacklist_one[\u0027pattern\u0027])"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"        # Verify blacklist_two"},{"line_number":1714,"context_line":"        criterion \u003d dict(pattern\u003dblacklist_two[\u0027pattern\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_9530df9f","line":1711,"updated":"2014-09-23 16:14:35.000000000","message":"(*\u0026@!$@!:-)","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1711,"context_line":"        self.assertEqual(results[0][\u0027pattern\u0027], blacklist_one[\u0027pattern\u0027])"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"        # Verify blacklist_two"},{"line_number":1714,"context_line":"        criterion \u003d dict(pattern\u003dblacklist_two[\u0027pattern\u0027])"},{"line_number":1715,"context_line":""},{"line_number":1716,"context_line":"        results \u003d self.storage.find_blacklists(self.admin_context,"},{"line_number":1717,"context_line":"                                               criterion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_b5dec33d","line":1714,"updated":"2014-09-23 16:14:35.000000000","message":"Could you do the pattern search based on fixture, rather than blacklist_two?","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1716,"context_line":"        results \u003d self.storage.find_blacklists(self.admin_context,"},{"line_number":1717,"context_line":"                                               criterion)"},{"line_number":1718,"context_line":"        self.assertEqual(len(results), 1)"},{"line_number":1719,"context_line":"        self.assertEqual(results[0][\u0027pattern\u0027], blacklist_two[\u0027pattern\u0027])"},{"line_number":1720,"context_line":""},{"line_number":1721,"context_line":"    def test_get_blacklist(self):"},{"line_number":1722,"context_line":"        expected \u003d self.create_blacklist(fixture\u003d0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_75d45b20","line":1719,"updated":"2014-09-23 16:14:35.000000000","message":"(*\u0026@!$@!:-)","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"        expected \u003d self.create_blacklist(fixture\u003d0)"},{"line_number":1723,"context_line":"        actual \u003d self.storage.get_blacklist(self.admin_context, expected[\u0027id\u0027])"},{"line_number":1724,"context_line":""},{"line_number":1725,"context_line":"        self.assertEqual(actual[\u0027pattern\u0027], expected[\u0027pattern\u0027])"},{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"    def test_get_blacklist_missing(self):"},{"line_number":1728,"context_line":"        with testtools.ExpectedException(exceptions.BlacklistNotFound):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_35c9f378","line":1725,"updated":"2014-09-23 16:14:35.000000000","message":"(*\u0026@!$@!:-)","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1733,"context_line":"        blacklist_one \u003d self.create_blacklist(fixture\u003d0)"},{"line_number":1734,"context_line":"        blacklist_two \u003d self.create_blacklist(fixture\u003d1)"},{"line_number":1735,"context_line":""},{"line_number":1736,"context_line":"        criterion \u003d dict(pattern\u003dblacklist_one[\u0027pattern\u0027])"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"        result \u003d self.storage.find_blacklist(self.admin_context, criterion)"},{"line_number":1739,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_95a53fb7","line":1736,"updated":"2014-09-23 16:14:35.000000000","message":"(*\u0026@!$@!:-)","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"        result \u003d self.storage.find_blacklist(self.admin_context, criterion)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"        self.assertEqual(result[\u0027pattern\u0027], blacklist_one[\u0027pattern\u0027])"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"        criterion \u003d dict(pattern\u003dblacklist_two[\u0027pattern\u0027])"},{"line_number":1743,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_15914f52","line":1740,"updated":"2014-09-23 16:14:35.000000000","message":"(*\u0026@!$@!:-)","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"        self.assertEqual(result[\u0027pattern\u0027], blacklist_one[\u0027pattern\u0027])"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"        criterion \u003d dict(pattern\u003dblacklist_two[\u0027pattern\u0027])"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"        result \u003d self.storage.find_blacklist(self.admin_context, criterion)"},{"line_number":1745,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_f57ccb22","line":1742,"updated":"2014-09-23 16:14:35.000000000","message":"(*\u0026@!$@!:-)","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"85bdc14e84972c4e2f02e89c1d5b015f5dca54bb","unresolved":false,"context_lines":[{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"        result \u003d self.storage.find_blacklist(self.admin_context, criterion)"},{"line_number":1745,"context_line":""},{"line_number":1746,"context_line":"        self.assertEqual(result[\u0027pattern\u0027], blacklist_two[\u0027pattern\u0027])"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"    def test_find_blacklist_criterion_missing(self):"},{"line_number":1749,"context_line":"        expected \u003d self.create_blacklist(fixture\u003d0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_3577333c","line":1746,"updated":"2014-09-23 16:14:35.000000000","message":"(*\u0026@!$@!:-)","commit_id":"f9e2a0a98f4703a0e6f3124d403bffa3ba636ffa"}]}