)]}'
{"designate/backend/impl_powerdns/migrate_repo/versions/009_cascade_domain_deletes.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"868e3836ff3fcbe2c172e7ba6efad45a06a033cc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"from sqlalchemy import MetaData, Table"},{"line_number":17,"context_line":"from migrate.changeset.constraint import ForeignKeyConstraint"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"meta \u003d MetaData()"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_c6cf5b56","line":17,"updated":"2014-10-09 18:18:26.000000000","message":"For my understanding - why isn\u0027t sqlalchemy\u0027s ForeignKeyConstraint used here?","commit_id":"a88d95717afcfb5f570101a99b2333abaab5ee5a"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"73c4a5d8125e3c9f20f1497019d988d6ef6d3e1c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"from sqlalchemy import MetaData, Table"},{"line_number":17,"context_line":"from migrate.changeset.constraint import ForeignKeyConstraint"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"meta \u003d MetaData()"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_86d0f3ca","line":17,"in_reply_to":"baa201ad_c6cf5b56","updated":"2014-10-09 18:28:30.000000000","message":"sqlalchemy\u0027s ForeignKeyConstraint doesn\u0027t have a create/delete method - sqlalchemy migrate extended it to add those methods.","commit_id":"a88d95717afcfb5f570101a99b2333abaab5ee5a"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"868e3836ff3fcbe2c172e7ba6efad45a06a033cc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    domainmetadata_fk \u003d ForeignKeyConstraint("},{"line_number":38,"context_line":"        [domainmetadata_table.c.domain_id],"},{"line_number":39,"context_line":"        [domains_table.c.id],"},{"line_number":40,"context_line":"        ondelete\u003d\"CASCADE\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    domainmetadata_fk.create()"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_c6f67b90","line":40,"updated":"2014-10-09 18:18:26.000000000","message":"Wouldn\u0027t this already be accomplished by https://github.com/openstack/designate/blob/master/designate/backend/impl_powerdns/__init__.py#L309-312","commit_id":"a88d95717afcfb5f570101a99b2333abaab5ee5a"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"73c4a5d8125e3c9f20f1497019d988d6ef6d3e1c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    domainmetadata_fk \u003d ForeignKeyConstraint("},{"line_number":38,"context_line":"        [domainmetadata_table.c.domain_id],"},{"line_number":39,"context_line":"        [domains_table.c.id],"},{"line_number":40,"context_line":"        ondelete\u003d\"CASCADE\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    domainmetadata_fk.create()"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_46944be8","line":40,"in_reply_to":"baa201ad_c6f67b90","updated":"2014-10-09 18:28:30.000000000","message":"Yes, for the existing powerDNS driver, that code is redundant but harmless now.. For the mDNS based PowerDNS driver (in the next commit in this chain) - it only knows about the domains table, so adding the cascade deletes let\u0027s us keep it that way.","commit_id":"a88d95717afcfb5f570101a99b2333abaab5ee5a"}]}