)]}'
{"designate/objects/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"a093990ca8068dd5e9da0836b5c7692dca56401d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from designate.objects.blacklist import Blacklist, BlacklistList  # noqa"},{"line_number":21,"context_line":"from designate.objects.domain import Domain, DomainList  # noqa"},{"line_number":22,"context_line":"from designate.objects.pool_manager_status import PoolManagerStatus  # noqa"},{"line_number":23,"context_line":"from designate.objects.pool_manager_status import PoolManagerStatusList  # noqa"},{"line_number":24,"context_line":"from designate.objects.quota import Quota, QuotaList  # noqa"},{"line_number":25,"context_line":"from designate.objects.rrdata_a import RRData_A  # noqa"},{"line_number":26,"context_line":"from designate.objects.rrdata_aaaa import RRData_AAAA  # noqa"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_20733a81","line":23,"updated":"2014-10-15 18:38:31.000000000","message":"Similar to the other imports in this file, could you combine these 2 imports into 1 line?","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4bce435e59a8a6ecb81c10f9dd95bb391dec3f60","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from designate.objects.blacklist import Blacklist, BlacklistList  # noqa"},{"line_number":21,"context_line":"from designate.objects.domain import Domain, DomainList  # noqa"},{"line_number":22,"context_line":"from designate.objects.pool_manager_status import PoolManagerStatus  # noqa"},{"line_number":23,"context_line":"from designate.objects.pool_manager_status import PoolManagerStatusList  # noqa"},{"line_number":24,"context_line":"from designate.objects.quota import Quota, QuotaList  # noqa"},{"line_number":25,"context_line":"from designate.objects.rrdata_a import RRData_A  # noqa"},{"line_number":26,"context_line":"from designate.objects.rrdata_aaaa import RRData_AAAA  # noqa"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_31c28653","line":23,"in_reply_to":"baa201ad_20733a81","updated":"2014-10-15 21:59:07.000000000","message":"The #noqa doesn\u0027t work if I do that.","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"}],"designate/objects/pool_manager_status.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"a093990ca8068dd5e9da0836b5c7692dca56401d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class PoolManagerStatus(base.DictObjectMixin, base.PersistentObjectMixin,"},{"line_number":20,"context_line":"                        base.DesignateObject):"},{"line_number":21,"context_line":"    FIELDS \u003d [\u0027server_id\u0027, \u0027domain_id\u0027, \u0027status\u0027, \u0027serial_number\u0027, \u0027action\u0027]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class PoolManagerStatusList(base.ListObjectMixin, base.DesignateObject):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8014e6e9","line":21,"updated":"2014-10-15 18:38:31.000000000","message":"For \u0027action\u0027, at some place we call this task, can we just call this task everywhere?","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4bce435e59a8a6ecb81c10f9dd95bb391dec3f60","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class PoolManagerStatus(base.DictObjectMixin, base.PersistentObjectMixin,"},{"line_number":20,"context_line":"                        base.DesignateObject):"},{"line_number":21,"context_line":"    FIELDS \u003d [\u0027server_id\u0027, \u0027domain_id\u0027, \u0027status\u0027, \u0027serial_number\u0027, \u0027action\u0027]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class PoolManagerStatusList(base.ListObjectMixin, base.DesignateObject):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_71316e59","line":21,"in_reply_to":"baa201ad_8014e6e9","updated":"2014-10-15 21:59:07.000000000","message":"I\u0027d rather change where it is called task to action.  Do you know where that is?","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"5941539f20669e93998d59c0b88c385510db74d1","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class PoolManagerStatus(base.DictObjectMixin, base.PersistentObjectMixin,"},{"line_number":20,"context_line":"                        base.DesignateObject):"},{"line_number":21,"context_line":"    FIELDS \u003d [\u0027server_id\u0027, \u0027domain_id\u0027, \u0027status\u0027, \u0027serial_number\u0027, \u0027action\u0027]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class PoolManagerStatusList(base.ListObjectMixin, base.DesignateObject):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_38e258a0","line":21,"updated":"2014-10-16 13:36:33.000000000","message":"Kiall\u0027s changes to objects has already merged in. These need to be changed to dictionaries. That\u0027s why it won\u0027t compile","commit_id":"b8b2ca43b3362442684df8d52b10d6f738586481"}],"designate/pool_manager/backend_section_name.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"89b298d50648f162062533c5bf5559dcd69856cb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class SectionNameParser(iniparser.BaseParser):"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":"    Used to retrieve the configuration file section names and parse the names."},{"line_number":48,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_3301a705","line":45,"updated":"2014-10-24 17:18:51.000000000","message":"I wonder, can we avoid needing to extend oslo.config by instead of fetching only those sections which match a regex, switching to fetching all sections (there will only ever be a small number of them), and post-filtering with the regex?\n\nMy concern is that iniparser.BaseParser isn\u0027t a \"public API\" as far as I know, so it could be changed from under us at any time!","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"8d4a11c4f86701f3c23f7b96b90bcbbdae5ce8c0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u0027[0-9A-Fa-f]{4}\u0027,"},{"line_number":31,"context_line":"    \u0027[0-9A-Fa-f]{12}\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"])"},{"line_number":34,"context_line":"SECTION_PATTERN \u003d SECTION_NAME_SEPARATOR.join(["},{"line_number":35,"context_line":"    \u0027^%s\u0027 % SECTION_NAME_PREFIX,"},{"line_number":36,"context_line":"    \u0027(.*)\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa7fdbe_eb0b7ad3","line":33,"updated":"2014-10-27 21:19:06.000000000","message":"For later - it would be ideal if the create pool and the config changes for the pool servers for that pool can be done independently of each other.  If the pool id is specified then, the create pool has to happen first and then the config needs to be updated and the pool manager restarted.  If instead we specify the pool name, then we could make the api and config changes in any order.","commit_id":"bc17db433cbb3f3d3c6135db5d747d5a7b0e1c94"}],"designate/pool_manager/database/base.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"89b298d50648f162062533c5bf5559dcd69856cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    \"\"\"Base class for database plugins\"\"\""},{"line_number":27,"context_line":"    __plugin_ns__ \u003d \u0027designate.pool_manager.database\u0027"},{"line_number":28,"context_line":"    __plugin_type__ \u003d \u0027pool_manager\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @abc.abstractmethod"},{"line_number":31,"context_line":"    def create_pool_manager_status(self, context, pool_manager_status):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_f35f1f0d","line":28,"updated":"2014-10-24 17:18:51.000000000","message":"This should probably be pool_manager_database, as PM\u0027s will likely end up with a series of different kinds of plugins?\n\nAlso - Since we\u0027re use this DB as a kinda-sorta-cache, is \"database\" the right word? Ignore this for now, things will likely become clearer as I get further into the review :)","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"}],"designate/pool_manager/database/impl_sqlalchemy/migrate_repo/manage.py":[{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"0e19c623969823d83053499cbc5b4d02c4220684","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2012 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_ce5364e0","line":2,"updated":"2014-10-24 06:50:29.000000000","message":"do you need this header?","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"0e19c623969823d83053499cbc5b4d02c4220684","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2012 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Author: Patrick Galbraith \u003cpatg@hp.com\u003e"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_eefe68ad","line":4,"updated":"2014-10-24 06:50:29.000000000","message":"Copyright 2014 eBay Inc. ?\nAm I wrong?","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"0e19c623969823d83053499cbc5b4d02c4220684","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Copyright 2012 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Author: Patrick Galbraith \u003cpatg@hp.com\u003e"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":10,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_2e34f091","line":7,"updated":"2014-10-24 06:50:29.000000000","message":"not you?","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"89b298d50648f162062533c5bf5559dcd69856cb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Copyright 2012 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Author: Patrick Galbraith \u003cpatg@hp.com\u003e"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":10,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_f3b63f3d","line":7,"in_reply_to":"9aa7fdbe_2e34f091","updated":"2014-10-24 17:18:51.000000000","message":"Copy+Pasted from elsewhere, leaving the original copyright headers is the right thing to do :)","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"}],"designate/pool_manager/rpcapi.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"a093990ca8068dd5e9da0836b5c7692dca56401d","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        1.0 - Initial version"},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":"    RPC_NOTIFY_API_VERSION \u003d \u00271.0\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":40,"context_line":"        topic \u003d topic if topic else cfg.CONF.pool_manager_topic"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_80178644","line":37,"updated":"2014-10-15 18:38:31.000000000","message":"This should correspond to the version mentioned in line 42 below.   Also calling it just RPC_API_VERSION or having pool in the name would be more meaningful","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4bce435e59a8a6ecb81c10f9dd95bb391dec3f60","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        1.0 - Initial version"},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":"    RPC_NOTIFY_API_VERSION \u003d \u00271.0\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":40,"context_line":"        topic \u003d topic if topic else cfg.CONF.pool_manager_topic"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_5189ca24","line":37,"in_reply_to":"baa201ad_80178644","updated":"2014-10-15 21:59:07.000000000","message":"I committed this code prematurely.\n\nIn either case, I fixed it.","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"a093990ca8068dd5e9da0836b5c7692dca56401d","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_domain(self, context, domain):"},{"line_number":46,"context_line":"        LOG.info(_LI(\"create_domain: Calling pool manager\u0027s create_domain.\"))"},{"line_number":47,"context_line":"        return self.notify_client.cast("},{"line_number":48,"context_line":"            context, \u0027create_domain\u0027, domain\u003ddomain)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def delete_domain(self, context, domain):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_e054d2ff","line":47,"updated":"2014-10-15 18:38:31.000000000","message":"It is not notify_client.  Here it is just client (line 43 above)","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4bce435e59a8a6ecb81c10f9dd95bb391dec3f60","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_domain(self, context, domain):"},{"line_number":46,"context_line":"        LOG.info(_LI(\"create_domain: Calling pool manager\u0027s create_domain.\"))"},{"line_number":47,"context_line":"        return self.notify_client.cast("},{"line_number":48,"context_line":"            context, \u0027create_domain\u0027, domain\u003ddomain)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def delete_domain(self, context, domain):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_718ece2f","line":47,"in_reply_to":"baa201ad_e054d2ff","updated":"2014-10-15 21:59:07.000000000","message":"Done","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"}],"designate/pool_manager/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"a093990ca8068dd5e9da0836b5c7692dca56401d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class Service(service.RPCService):"},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Service, self).__init__(*args, **kwargs)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_a083aa54","line":26,"updated":"2014-10-15 18:38:31.000000000","message":"The service should have an rpc version and should calling oslo.messaging.Target(), since this implements create_domain etc.","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4bce435e59a8a6ecb81c10f9dd95bb391dec3f60","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class Service(service.RPCService):"},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Service, self).__init__(*args, **kwargs)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_91fb327a","line":26,"in_reply_to":"baa201ad_a083aa54","updated":"2014-10-15 21:59:07.000000000","message":"Same as my other comment.  Probably committed this prematurely.  In either case, fixed.","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3085b8499e7a5195810e2d0dec1395f967c7bb7c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Get a storage connection"},{"line_number":31,"context_line":"        storage_driver \u003d cfg.CONF[\u0027service:central\u0027].storage_driver"},{"line_number":32,"context_line":"        self.storage \u003d storage.get_storage(storage_driver)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def start(self):"},{"line_number":35,"context_line":"        super(Service, self).start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_60e549a7","line":32,"updated":"2014-10-15 18:17:52.000000000","message":"I honestly can\u0027t remember if this was discussed in the past or not.. But ideally, the pool manager wouldn\u0027t need direct DB access (I know we talked about using the DB as a cache for status data, I believe that should be separate database - similar to how PowerDNS uses a different database)","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4bce435e59a8a6ecb81c10f9dd95bb391dec3f60","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Get a storage connection"},{"line_number":31,"context_line":"        storage_driver \u003d cfg.CONF[\u0027service:central\u0027].storage_driver"},{"line_number":32,"context_line":"        self.storage \u003d storage.get_storage(storage_driver)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def start(self):"},{"line_number":35,"context_line":"        super(Service, self).start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_f1c71e43","line":32,"in_reply_to":"baa201ad_60e549a7","updated":"2014-10-15 21:59:07.000000000","message":"Okay.  I\u0027ll keep working with storage for now and migrate to a separate DB in time.","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"7fd108255ebd8ee72325f72774c5815caa6cfc1f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    API version history:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        API version history:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        1.0 - Initial version"},{"line_number":39,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_5c54ee53","line":36,"updated":"2014-10-21 10:09:38.000000000","message":"Nit: You\u0027ve doubled up here :)","commit_id":"034d04778bc586a059ad08ed5848a53a904c1d55"}],"designate/sqlalchemy/base.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"89b298d50648f162062533c5bf5559dcd69856cb","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.local_store \u003d threading.local()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @abc.abstractmethod"},{"line_number":74,"context_line":"    def get_name(self):"},{"line_number":75,"context_line":"        \"\"\"Get the name.\"\"\""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_f352bfdc","line":73,"updated":"2014-10-24 17:18:51.000000000","message":"For this to have any effect, we\u0027ll need to add the abc.ABCMeta class as a metaclass for this one... \n\n     import six\n     \n     @six.add_metaclass(abc.ABCMeta)\n     class SQLAlchemy(object):\n         ....","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"}],"designate/storage/impl_sqlalchemy/migrate_repo/versions/041_kilo.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3085b8499e7a5195810e2d0dec1395f967c7bb7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baa201ad_4623e4a6","updated":"2014-10-15 18:17:52.000000000","message":"We\u0027ll want to call this 041_add_pool_manager_statuses.py or similar, migrations only get combined into a single \"release\" migration a cycle or two down the line.. e.g. when kilo comes out in 6 months, we\u0027ll squash the Juno migrations into a XX_juno.py file.","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4bce435e59a8a6ecb81c10f9dd95bb391dec3f60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baa201ad_91a8928d","in_reply_to":"baa201ad_4623e4a6","updated":"2014-10-15 21:59:07.000000000","message":"Done","commit_id":"6c35198a8c0f32cafdf51cb1dfcc86f26eec0ca0"}],"designate/tests/__init__.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"89b298d50648f162062533c5bf5559dcd69856cb","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            DatabaseFixture.get_fixture(repository))"},{"line_number":339,"context_line":"        self.config("},{"line_number":340,"context_line":"            connection\u003ddb_fixture.url,"},{"line_number":341,"context_line":"            connection_debug\u003d100,"},{"line_number":342,"context_line":"            group\u003d\u0027pool_manager:sqlalchemy\u0027)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    # Config Methods"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa7fdbe_d3a13b95","line":341,"updated":"2014-10-24 17:18:51.000000000","message":"Can we drop this to 50, we recently dropped the main DB to 50 too.. 100 is too noisy.","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"}],"setup.cfg":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"89b298d50648f162062533c5bf5559dcd69856cb","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"designate.manage \u003d"},{"line_number":91,"context_line":"    database \u003d designate.manage.database:DatabaseCommands"},{"line_number":92,"context_line":"    pool_manager_database \u003d designate.manage.pool_manager_database:DatabaseCommands"},{"line_number":93,"context_line":"    powerdns \u003d designate.manage.powerdns:DatabaseCommands"},{"line_number":94,"context_line":"    powerdns-mdns \u003d designate.manage.powerdns_mdns:DatabaseCommands"},{"line_number":95,"context_line":"    tlds \u003d designate.manage.tlds:TLDCommands"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"9aa7fdbe_33dfe70e","line":92,"updated":"2014-10-24 17:18:51.000000000","message":"Can we swap the _\u0027s in the CLI arg for -\u0027s :)","commit_id":"26593d7011f7cea87a1a9fe7a8fd4df27154a81c"}]}