)]}'
{"designate/backend/base.py":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8903ff8a09cd9680cb0d67277c5739d6693279d0","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        :param context: Security context information."},{"line_number":299,"context_line":"        :param domain: the DNS domain."},{"line_number":300,"context_line":"        :raises Backend: if unable to create the domain."},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def update_domain(self, context, domain):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_38bcd2ba","line":300,"updated":"2014-10-28 21:25:39.000000000","message":"Does it raise a Backend ? Put a more specific description and name please.","commit_id":"d9359856aab61f9fe852ad3f60ebe16b70881ef0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4c29d20d626f620e4ece4e83aa23b50e1eef16c9","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        :param context: Security context information."},{"line_number":299,"context_line":"        :param domain: the DNS domain."},{"line_number":300,"context_line":"        :raises Backend: if unable to create the domain."},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def update_domain(self, context, domain):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_cfb77d39","line":300,"in_reply_to":"9aa7fdbe_38bcd2ba","updated":"2014-10-28 22:31:17.000000000","message":"Endre:\n\nThe exception raised is called \u0027Backend\u0027.  I didn\u0027t create the exception, I\u0027m just using it.  We already test for it in the Central Service.  And it will be thrown when the domain cannot be created because of an error or otherwise.\n\nI\u0027m trying to make this exception an implicit part of the contract for a backend.  (If a domain is unable to be created, this exception will be thrown.)  My understanding is this exception was added after many of the backends were written, so it is only used in one backend (as far as I can tell.)\n\nPerhaps you can suggest a better description?","commit_id":"d9359856aab61f9fe852ad3f60ebe16b70881ef0"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8903ff8a09cd9680cb0d67277c5739d6693279d0","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        :param context: Security context information."},{"line_number":312,"context_line":"        :param domain: the DNS domain."},{"line_number":313,"context_line":"        :raises Backend: if unable to delete the domain."},{"line_number":314,"context_line":"        \"\"\""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def create_recordset(self, context, domain, recordset):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_98ccde6b","line":313,"updated":"2014-10-28 21:25:39.000000000","message":"Same as ^","commit_id":"d9359856aab61f9fe852ad3f60ebe16b70881ef0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4c29d20d626f620e4ece4e83aa23b50e1eef16c9","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        :param context: Security context information."},{"line_number":312,"context_line":"        :param domain: the DNS domain."},{"line_number":313,"context_line":"        :raises Backend: if unable to delete the domain."},{"line_number":314,"context_line":"        \"\"\""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    def create_recordset(self, context, domain, recordset):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_8f94958d","line":313,"in_reply_to":"9aa7fdbe_98ccde6b","updated":"2014-10-28 22:31:17.000000000","message":"Same here.","commit_id":"d9359856aab61f9fe852ad3f60ebe16b70881ef0"}],"designate/backend/impl_bind9_pool.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"26efd38ddb367bcb627e0139f36847afb08f0388","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @staticmethod"},{"line_number":51,"context_line":"    def _parse_master(master):"},{"line_number":52,"context_line":"        try:"},{"line_number":53,"context_line":"            (ip_address, port) \u003d master.split(\u0027:\u0027)"},{"line_number":54,"context_line":"            port \u003d int(port)"},{"line_number":55,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_95259b5d","line":52,"updated":"2014-10-28 11:41:43.000000000","message":"It would be nice to validate ip address too.","commit_id":"a92a9dba08dba7f8fca96c90eec003c382e00bd7"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8903ff8a09cd9680cb0d67277c5739d6693279d0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    cfg.ListOpt(\u0027masters\u0027, default\u003d[\u0027127.0.0.1:5354\u0027],"},{"line_number":31,"context_line":"                help\u003d\u0027Comma-separated list of master DNS servers, in \u0027"},{"line_number":32,"context_line":"                     \u0027 \u003cip-address\u003e:\u003cport\u003e format. If \u003cport\u003e is omitted, \u0027"},{"line_number":33,"context_line":"                     \u0027the default 5354 is used.  These are mdns servers.\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027rndc-host\u0027, default\u003d\u0027127.0.0.1\u0027, help\u003d\u0027RNDC Host\u0027),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027rndc-port\u0027, default\u003d953, help\u003d\u0027RNDC Port\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027rndc-config-file\u0027, default\u003dNone, help\u003d\u0027RNDC Config File\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_98fa1e73","line":33,"updated":"2014-10-28 21:25:39.000000000","message":"Isn\u0027t this retrieved from pool?","commit_id":"d9359856aab61f9fe852ad3f60ebe16b70881ef0"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"4c29d20d626f620e4ece4e83aa23b50e1eef16c9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    cfg.ListOpt(\u0027masters\u0027, default\u003d[\u0027127.0.0.1:5354\u0027],"},{"line_number":31,"context_line":"                help\u003d\u0027Comma-separated list of master DNS servers, in \u0027"},{"line_number":32,"context_line":"                     \u0027 \u003cip-address\u003e:\u003cport\u003e format. If \u003cport\u003e is omitted, \u0027"},{"line_number":33,"context_line":"                     \u0027the default 5354 is used.  These are mdns servers.\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027rndc-host\u0027, default\u003d\u0027127.0.0.1\u0027, help\u003d\u0027RNDC Host\u0027),"},{"line_number":35,"context_line":"    cfg.IntOpt(\u0027rndc-port\u0027, default\u003d953, help\u003d\u0027RNDC Port\u0027),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027rndc-config-file\u0027, default\u003dNone, help\u003d\u0027RNDC Config File\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_4f98ed6a","line":33,"in_reply_to":"9aa7fdbe_98fa1e73","updated":"2014-10-28 22:31:17.000000000","message":"The pool has the name servers which will be NS records for the domains.  In BIND9, masters are the servers that are allowed to NOTIFY the slave server of zone updates.  This is similar to \u0027masters\u0027 in the impl_powerdns_mdns backend driver.\n\nIt\u0027s possible \u0027masters\u0027 is going to be something that all backend slave servers need and we didn\u0027t account for them in our pool design.  I\u0027m guessing that will reveal itself as we rewrite the backends for pool manager.","commit_id":"d9359856aab61f9fe852ad3f60ebe16b70881ef0"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d19c7e6ad9ab735aaec828b796c20874ae2dcb73","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.rndc_host \u003d self.get_backend_option(\u0027rndc_host\u0027)"},{"line_number":50,"context_line":"        self.rndc_port \u003d self.get_backend_option(\u0027rndc_port\u0027)"},{"line_number":51,"context_line":"        self.rndc_config_file \u003d self.get_backend_option(\u0027rndc_config_file\u0027)"},{"line_number":52,"context_line":"        self.rndc_key_file \u003d self.get_backend_option(\u0027rndc_key_file\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @staticmethod"},{"line_number":55,"context_line":"    def _parse_master(master):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_f1904997","line":52,"updated":"2014-11-05 13:42:13.000000000","message":"Do you need to support an option for nzf-path similar to the current Bind9 backend (and the operations around it for create/delete domain)?","commit_id":"03d781124066c8f14b49cb1510faaa69a161cab3"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"1401b1d2533805a45071d405a4ce0127186128fb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.rndc_host \u003d self.get_backend_option(\u0027rndc_host\u0027)"},{"line_number":50,"context_line":"        self.rndc_port \u003d self.get_backend_option(\u0027rndc_port\u0027)"},{"line_number":51,"context_line":"        self.rndc_config_file \u003d self.get_backend_option(\u0027rndc_config_file\u0027)"},{"line_number":52,"context_line":"        self.rndc_key_file \u003d self.get_backend_option(\u0027rndc_key_file\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @staticmethod"},{"line_number":55,"context_line":"    def _parse_master(master):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_f434b7df","line":52,"in_reply_to":"7a8c0949_f1904997","updated":"2014-11-05 14:12:21.000000000","message":"Maybe not an nzf path, but probably a path to the directory of the zone files, for the reason below.","commit_id":"03d781124066c8f14b49cb1510faaa69a161cab3"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d19c7e6ad9ab735aaec828b796c20874ae2dcb73","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def _parse_master(master):"},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            (ip_address, port) \u003d master.split(\u0027:\u0027)"},{"line_number":58,"context_line":"        except ValueError:"},{"line_number":59,"context_line":"            ip_address \u003d str(master)"},{"line_number":60,"context_line":"            port \u003d DEFAULT_PORT"},{"line_number":61,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_9e10f4a9","line":58,"updated":"2014-11-05 13:42:13.000000000","message":"You can get ValueError in 2 cases\n\n(1)ValueError: need more than 1 value to unpack\n\n(2)ValueError: too many values to unpack\n\nThis code assumes only the 1st case. We need to be able to handle the 2nd case too here.","commit_id":"03d781124066c8f14b49cb1510faaa69a161cab3"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d19c7e6ad9ab735aaec828b796c20874ae2dcb73","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise exceptions.ConfigurationError("},{"line_number":65,"context_line":"                \u0027Invalid port \"%s\" in masters option.\u0027 % port)"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            socket.inet_pton(socket.AF_INET, ip_address)"},{"line_number":68,"context_line":"        except socket.error:"},{"line_number":69,"context_line":"            raise exceptions.ConfigurationError("},{"line_number":70,"context_line":"                \u0027Invalid IP address \"%s\" in masters option.\u0027 % ip_address)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_5e35acf5","line":67,"updated":"2014-11-05 13:42:13.000000000","message":"could we validate the port too?","commit_id":"03d781124066c8f14b49cb1510faaa69a161cab3"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d19c7e6ad9ab735aaec828b796c20874ae2dcb73","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            masters.append(\u0027%s port %s\u0027 % (ip_address, port))"},{"line_number":84,"context_line":"        rndc_op \u003d ["},{"line_number":85,"context_line":"            \u0027addzone\u0027,"},{"line_number":86,"context_line":"            \u0027%s { type slave; masters { %s;}; file \"slave.%s\"; };\u0027 %"},{"line_number":87,"context_line":"            (domain[\u0027name\u0027], \u0027; \u0027.join(masters), domain[\u0027name\u0027]),"},{"line_number":88,"context_line":"        ]"},{"line_number":89,"context_line":"        self._execute_rndc(rndc_op)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_51be7dd5","line":86,"updated":"2014-11-05 13:42:13.000000000","message":"What is the folder where the slave zonefile is going to? Could we specify an absolute path?","commit_id":"03d781124066c8f14b49cb1510faaa69a161cab3"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"1401b1d2533805a45071d405a4ce0127186128fb","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            masters.append(\u0027%s port %s\u0027 % (ip_address, port))"},{"line_number":84,"context_line":"        rndc_op \u003d ["},{"line_number":85,"context_line":"            \u0027addzone\u0027,"},{"line_number":86,"context_line":"            \u0027%s { type slave; masters { %s;}; file \"slave.%s\"; };\u0027 %"},{"line_number":87,"context_line":"            (domain[\u0027name\u0027], \u0027; \u0027.join(masters), domain[\u0027name\u0027]),"},{"line_number":88,"context_line":"        ]"},{"line_number":89,"context_line":"        self._execute_rndc(rndc_op)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_143063e7","line":86,"in_reply_to":"7a8c0949_51be7dd5","updated":"2014-11-05 14:12:21.000000000","message":"+1\nIt should also be configurable.\n\nALSO:\nI think for these string substitutions we were switching to this type of format, naming the variables in the string, and passing a dict instead of a tuple. Just semantic. \nhttps://github.com/openstack/designate/blob/73b944683d66f118f5e498157e1b3ea91b126fa7/designate/mdns/rpcapi.py#L46","commit_id":"03d781124066c8f14b49cb1510faaa69a161cab3"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"d19c7e6ad9ab735aaec828b796c20874ae2dcb73","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        rndc_op \u003d ["},{"line_number":85,"context_line":"            \u0027addzone\u0027,"},{"line_number":86,"context_line":"            \u0027%s { type slave; masters { %s;}; file \"slave.%s\"; };\u0027 %"},{"line_number":87,"context_line":"            (domain[\u0027name\u0027], \u0027; \u0027.join(masters), domain[\u0027name\u0027]),"},{"line_number":88,"context_line":"        ]"},{"line_number":89,"context_line":"        self._execute_rndc(rndc_op)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_51303d9e","line":87,"updated":"2014-11-05 13:42:13.000000000","message":"Could you add the domain id to the slave file name? This ensures that it is unique and prevents problems in scenarios like create a domain, delete a domain and then again create a domain with the same name as earlier","commit_id":"03d781124066c8f14b49cb1510faaa69a161cab3"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"1401b1d2533805a45071d405a4ce0127186128fb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        rndc_op \u003d ["},{"line_number":85,"context_line":"            \u0027addzone\u0027,"},{"line_number":86,"context_line":"            \u0027%s { type slave; masters { %s;}; file \"slave.%s\"; };\u0027 %"},{"line_number":87,"context_line":"            (domain[\u0027name\u0027], \u0027; \u0027.join(masters), domain[\u0027name\u0027]),"},{"line_number":88,"context_line":"        ]"},{"line_number":89,"context_line":"        self._execute_rndc(rndc_op)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_b4414f3b","line":87,"in_reply_to":"7a8c0949_51303d9e","updated":"2014-11-05 14:12:21.000000000","message":"+1, name-id would be ideal imo.","commit_id":"03d781124066c8f14b49cb1510faaa69a161cab3"}]}
