)]}'
{"contrib/devstack/lib/designate_plugins/backend-bind9_pool":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"622298ab551535d0015b4222e16ff65de61f278a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# wildcard_iniset config-file section option value"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# This function is needed to handle sections that have a wildcard in them."},{"line_number":46,"context_line":"function wildcard_iniset {"},{"line_number":47,"context_line":"    local xtrace\u003d$(set +o | grep xtrace)"},{"line_number":48,"context_line":"    set +o xtrace"},{"line_number":49,"context_line":"    local file\u003d$1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a8c0949_f97224e4","line":46,"updated":"2014-10-31 12:52:46.000000000","message":"Ideally, this function get\u0027s moved into DevStack\u0027s common-functions lib alongside all the other INI file related methods. Not something to do right now - just a note that we\u0027ll want to move it at some point.","commit_id":"79095e7b177e3e164a3305ba75f9acf3a4bcdf58"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"622298ab551535d0015b4222e16ff65de61f278a","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    UUID\u003d`uuidgen`"},{"line_number":118,"context_line":"    iniset $DESIGNATE_CONF backend:bind9_pool:$UUID host $DESIGNATE_SERVICE_HOST"},{"line_number":119,"context_line":"    iniset $DESIGNATE_CONF backend:bind9_pool:$UUID port 53"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    sudo chown $STACK_USER $BIND_CFG_DIR"},{"line_number":122,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a8c0949_190c5042","line":119,"updated":"2014-10-31 12:52:46.000000000","message":"I think this UUID will be needed in the default_pool_id config option too, and it\u0027ll need to be put in before the DB migrations happen (This might already be before the DB migrations, I can\u0027t remember TBH :))\n\nAdditionally, re-running DevStack a second time should result in the same DB and ID\u0027s etc etc.. We\u0027ll probably want to make the pool UUID a input paramater with a default value to ensure this works.. e.g. \n\n    DESIGNATE_DEFAULT_POOL_ID\u003d${DESIGNATE_DEFAULT_POOL_ID:-794ccc2c-d751-44fe-b57f-8894c9f5c842}\n\n(That\u0027s the actual UUID we\u0027ve called the default in designate - https://github.com/openstack/designate/blob/master/designate/central/__init__.py#L45)","commit_id":"79095e7b177e3e164a3305ba75f9acf3a4bcdf58"}],"designate/backend/impl_pool_manager_proxy.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"e173c72f01d91caee025c601497251ba540c2b56","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create_recordset(self, context, domain, recordset):"},{"line_number":78,"context_line":"        LOG.debug(\u0027Create RecordSet\u0027)"},{"line_number":79,"context_line":"        self.pool_manager.update_domain(context, domain)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def update_recordset(self, context, domain, recordset):"},{"line_number":82,"context_line":"        LOG.debug(\u0027Update RecordSet\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_797c9273","line":79,"updated":"2014-11-09 12:38:51.000000000","message":"I\u0027m not sure if the CUD methods for recordsets/domains should call update_domain - without the proxy backend in place, would these methods be called?\n\nShould this be calling some sort of \"Domain Content Has Changed\" method to differentiate it from CUD domain?\n\n(I could be wrong, and update_domain might be that method.. ignore if it is :))","commit_id":"75986db67f2e013be0fa87c04dd189c178aa8066"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"777857b13474d70444c50a1f45a5b24dd489de93","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create_recordset(self, context, domain, recordset):"},{"line_number":78,"context_line":"        LOG.debug(\u0027Create RecordSet\u0027)"},{"line_number":79,"context_line":"        self.pool_manager.update_domain(context, domain)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def update_recordset(self, context, domain, recordset):"},{"line_number":82,"context_line":"        LOG.debug(\u0027Update RecordSet\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_f3185a77","line":79,"in_reply_to":"5a890539_797c9273","updated":"2014-11-12 13:49:19.000000000","message":"that is the right method - we are updating the domain in any case (serial)","commit_id":"75986db67f2e013be0fa87c04dd189c178aa8066"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a76ee927195a2aa606d5eae1e265f64e7c51a9ad","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def create_recordset(self, context, domain, recordset):"},{"line_number":78,"context_line":"        LOG.debug(\u0027Create RecordSet\u0027)"},{"line_number":79,"context_line":"        self.pool_manager.update_domain(context, domain)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def update_recordset(self, context, domain, recordset):"},{"line_number":82,"context_line":"        LOG.debug(\u0027Update RecordSet\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_3930019e","line":79,"in_reply_to":"5a890539_f3185a77","updated":"2014-11-12 14:58:12.000000000","message":"True - But does the pool manager care? At the end of the day, the SOA recordset will be updated with the new serial #.. Anyway, no harm leaving it in.","commit_id":"75986db67f2e013be0fa87c04dd189c178aa8066"}]}