)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"cf59806acd3797fda56f2d9148b3a75b8219398b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  Pool_Attribute API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This adds the pool_attribute api calls to the central layer, as"},{"line_number":10,"context_line":"  well as the associated tests"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  Implements: blueprint server-pools-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3a961159_53b936eb","line":9,"updated":"2014-12-30 19:14:17.000000000","message":"The description needs to be updated.","commit_id":"2bb21087d6e514f7116ada40e3e689cc8e219bad"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"30b024a86a8289408a8b69ef918f796d94130bcf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  Pool_Attribute API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This adds the pool_attribute api calls to the central layer, as"},{"line_number":10,"context_line":"  well as the associated tests"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  Implements: blueprint server-pools-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3a961159_993adfe5","line":9,"in_reply_to":"3a961159_53b936eb","updated":"2014-12-30 21:52:19.000000000","message":"Done","commit_id":"2bb21087d6e514f7116ada40e3e689cc8e219bad"}],"designate/central/rpcapi.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"9d35d2af65ef0772e6c8a62dccd9255ec0591dd2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        4.3 - Add methods for server pool attributes"},{"line_number":51,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e   Pool_Attribute API"},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    RPC_API_VERSION \u003d \u00274.3\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":56,"context_line":"        topic \u003d topic if topic else cfg.CONF.central_topic"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_50517b0c","line":53,"updated":"2014-12-04 21:58:19.000000000","message":"The rpc api version needs to be increased and the diff markers removed.","commit_id":"42f8c9b82f9feb87e25a1feeda8c01ca4442c7bd"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"842524b65ccedb5a2cbf5d89eeebd83e93cb1566","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        4.3 - Add methods for server pool attributes"},{"line_number":51,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e   Pool_Attribute API"},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    RPC_API_VERSION \u003d \u00274.3\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":56,"context_line":"        topic \u003d topic if topic else cfg.CONF.central_topic"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_41f6d9d8","line":53,"in_reply_to":"5a890539_50517b0c","updated":"2014-12-08 23:07:42.000000000","message":"Done","commit_id":"42f8c9b82f9feb87e25a1feeda8c01ca4442c7bd"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"5e66a7f75d2b8cac9dba61a5d215bb119b6b58a8","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            zone_transfer_accept_id\u003dzone_transfer_accept_id)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    # Pool Attributes Methods"},{"line_number":541,"context_line":"    def create_pool_attribute(self, context, pool_attribute):"},{"line_number":542,"context_line":"        LOG.info(_LI(\"create_pool_attribute: Calling central\u0027s \""},{"line_number":543,"context_line":"                     \"create_pool_attribute.\"))"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_eed078f9","line":541,"updated":"2014-12-17 14:31:34.000000000","message":"None of these new methods, bar delete_pool_attribute, are used anywhere. Can we remove them? I also believe it\u0027s the same in central/service.py/\n\nRe the delete_pool_attribute usage in the v1/servers API - I think this can be removed be fetching the pool, removing the matching server entry, and updating the pool.","commit_id":"abc056de9708cf98f765b9b45d49eefc151078de"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"374066a569aef1533977c94970117532abbb898e","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            zone_transfer_accept_id\u003dzone_transfer_accept_id)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    # Pool Attributes Methods"},{"line_number":541,"context_line":"    def create_pool_attribute(self, context, pool_attribute):"},{"line_number":542,"context_line":"        LOG.info(_LI(\"create_pool_attribute: Calling central\u0027s \""},{"line_number":543,"context_line":"                     \"create_pool_attribute.\"))"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_6b2d76a8","line":541,"in_reply_to":"3a961159_eed078f9","updated":"2014-12-29 16:49:16.000000000","message":"Done","commit_id":"abc056de9708cf98f765b9b45d49eefc151078de"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"cf59806acd3797fda56f2d9148b3a75b8219398b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        topic \u003d topic if topic else cfg.CONF.central_topic"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        target \u003d messaging.Target(topic\u003dtopic, version\u003dself.RPC_API_VERSION)"},{"line_number":56,"context_line":"        self.client \u003d rpc.get_client(target, version_cap\u003d\u00274.4\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def get_instance(cls):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_d83f05b4","line":56,"updated":"2014-12-30 19:14:17.000000000","message":"This is not needed now.","commit_id":"2bb21087d6e514f7116ada40e3e689cc8e219bad"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"30b024a86a8289408a8b69ef918f796d94130bcf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        topic \u003d topic if topic else cfg.CONF.central_topic"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        target \u003d messaging.Target(topic\u003dtopic, version\u003dself.RPC_API_VERSION)"},{"line_number":56,"context_line":"        self.client \u003d rpc.get_client(target, version_cap\u003d\u00274.4\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def get_instance(cls):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a961159_3952cb35","line":56,"in_reply_to":"3a961159_d83f05b4","updated":"2014-12-30 21:52:19.000000000","message":"Done.","commit_id":"2bb21087d6e514f7116ada40e3e689cc8e219bad"}],"designate/central/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"9d35d2af65ef0772e6c8a62dccd9255ec0591dd2","unresolved":false,"context_lines":[{"line_number":2291,"context_line":"            context, pool_attribute.pool_id, pool_attribute)"},{"line_number":2292,"context_line":""},{"line_number":2293,"context_line":"        self.notifier.info(context, \u0027dns.pool_attribute.create\u0027,"},{"line_number":2294,"context_line":"                           created_pool_attribute)"},{"line_number":2295,"context_line":""},{"line_number":2296,"context_line":"        return created_pool_attribute"},{"line_number":2297,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_f0ed07f1","line":2294,"updated":"2014-12-04 21:58:19.000000000","message":"Notifications are now done with a decorator @notification.","commit_id":"42f8c9b82f9feb87e25a1feeda8c01ca4442c7bd"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"842524b65ccedb5a2cbf5d89eeebd83e93cb1566","unresolved":false,"context_lines":[{"line_number":2291,"context_line":"            context, pool_attribute.pool_id, pool_attribute)"},{"line_number":2292,"context_line":""},{"line_number":2293,"context_line":"        self.notifier.info(context, \u0027dns.pool_attribute.create\u0027,"},{"line_number":2294,"context_line":"                           created_pool_attribute)"},{"line_number":2295,"context_line":""},{"line_number":2296,"context_line":"        return created_pool_attribute"},{"line_number":2297,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_21d1cdfb","line":2294,"in_reply_to":"5a890539_f0ed07f1","updated":"2014-12-08 23:07:42.000000000","message":"Done","commit_id":"42f8c9b82f9feb87e25a1feeda8c01ca4442c7bd"}],"designate/tests/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"9d35d2af65ef0772e6c8a62dccd9255ec0591dd2","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    pool_attribute_fixtures \u003d ["},{"line_number":281,"context_line":"        {\u0027scope\u0027: \u0027public\u0027},"},{"line_number":282,"context_line":"        {\u0027scope\u0027: \u0027private\u0027},"},{"line_number":283,"context_line":"        {\u0027scope\u0027: \u0027unknown\u0027}"},{"line_number":284,"context_line":"    ]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    name_server_fixtures \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_d0c9eb79","line":283,"updated":"2014-12-04 21:58:19.000000000","message":"Could you see if you can consolidate this pool_attribute_fixtures and the new pool_attributes_fixtures (and the related supporting functions/tests)","commit_id":"42f8c9b82f9feb87e25a1feeda8c01ca4442c7bd"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"842524b65ccedb5a2cbf5d89eeebd83e93cb1566","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    pool_attribute_fixtures \u003d ["},{"line_number":281,"context_line":"        {\u0027scope\u0027: \u0027public\u0027},"},{"line_number":282,"context_line":"        {\u0027scope\u0027: \u0027private\u0027},"},{"line_number":283,"context_line":"        {\u0027scope\u0027: \u0027unknown\u0027}"},{"line_number":284,"context_line":"    ]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    name_server_fixtures \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_41233905","line":283,"in_reply_to":"5a890539_d0c9eb79","updated":"2014-12-08 23:07:42.000000000","message":"I know it\u0027s confusing,, but they are really testing different things and can\u0027t be consolidated. The name_server_fixtures are a convenience for testing pool create/updates. They only want the FQDN, not all that would be needed to actually add a pool_attribute to a db table. The other is a convenience for testing create/updates to a pool_attribute being written directly to a db table, and therefore need all the info of pool-id, key and value.","commit_id":"42f8c9b82f9feb87e25a1feeda8c01ca4442c7bd"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"9d35d2af65ef0772e6c8a62dccd9255ec0591dd2","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        values \u003d values or {}"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        _values \u003d copy.copy(self.pool_attribute_fixtures[fixture])"},{"line_number":541,"context_line":"        _values.update(values)"},{"line_number":542,"context_line":"        return _values"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def get_nameserver_fixture(self, fixture\u003d0, values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_707f5717","line":541,"updated":"2014-12-04 21:58:19.000000000","message":"We have a get_pool_attributes_fixture and get_pool_attribute_fixture. Would be good if we can have only 1.","commit_id":"42f8c9b82f9feb87e25a1feeda8c01ca4442c7bd"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"842524b65ccedb5a2cbf5d89eeebd83e93cb1566","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        values \u003d values or {}"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        _values \u003d copy.copy(self.pool_attribute_fixtures[fixture])"},{"line_number":541,"context_line":"        _values.update(values)"},{"line_number":542,"context_line":"        return _values"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def get_nameserver_fixture(self, fixture\u003d0, values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_9c182686","line":541,"in_reply_to":"5a890539_707f5717","updated":"2014-12-08 23:07:42.000000000","message":"Same as above. The tests server different functions and I think more tests are better than less.","commit_id":"42f8c9b82f9feb87e25a1feeda8c01ca4442c7bd"}],"etc/designate/policy.json":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d37e14e6bb15857153eaa675f0e77857ab5f4aa7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    \"create_pool_attribute\": \"rule:admin\","},{"line_number":81,"context_line":"    \"find_pool_attributes\": \"rule:admin\","},{"line_number":82,"context_line":"    \"find_pool_attribute\": \"rule:admin\","},{"line_number":83,"context_line":"    \"get_pool_attribute\": \"rule:admin\","},{"line_number":84,"context_line":"    \"update_pool_attribute\": \"rule:admin\","},{"line_number":85,"context_line":"    \"delete_pool_attribute\": \"rule:admin\","},{"line_number":86,"context_line":""}],"source_content_type":"application/json","patch_set":10,"id":"3a961159_8722c7a0","line":83,"updated":"2014-12-15 14:35:39.000000000","message":"do normal users not need to be able to get pool attribs (eg name servers? )","commit_id":"103de7ba171b24004c2690b02917a1cbcd74356b"}]}