)]}'
{"designate/api/v2/controllers/zones.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"84d7ba8c93802d8f8e091966e46537c2b27f495e","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        except dnsexception.SyntaxError:"},{"line_number":178,"context_line":"            raise exceptions.BadRequest(\u0027Malformed zonefile.\u0027)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # TODO(artom) This should probably be handled with transactions"},{"line_number":181,"context_line":"        zone \u003d self.central_api.sync(context, domain)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if zone[\u0027status\u0027] \u003d\u003d \u0027PENDING\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_d8affc92","line":180,"updated":"2014-11-12 13:18:50.000000000","message":"I believe the TODO is no longer relevant..","commit_id":"022c25250e8fa0058ca1a9932f239c9d786feaf2"}],"designate/central/rpcapi.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"84d7ba8c93802d8f8e091966e46537c2b27f495e","unresolved":false,"context_lines":[{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def delete_pool(self, context, pool_id):"},{"line_number":406,"context_line":"        LOG.info(_LI(\"delete_pool: Calling central\u0027s delete_pool.\"))"},{"line_number":407,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00274.1\u0027)"},{"line_number":408,"context_line":"        return cctxt.call(context, \u0027delete_pool\u0027, pool_id\u003dpool_id)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    # Pool Manager Integration Methods"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_b8b150e3","line":407,"updated":"2014-11-12 13:18:50.000000000","message":"You\u0027ll want to bump the API version, similar to as was done here for pools - The service side also needs the same bump.","commit_id":"022c25250e8fa0058ca1a9932f239c9d786feaf2"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"84d7ba8c93802d8f8e091966e46537c2b27f495e","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        return cctxt.call(context, \u0027update_status\u0027, domain_id\u003ddomain_id,"},{"line_number":415,"context_line":"                          status\u003dstatus, serial\u003dserial)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def sync(self, context, domain):"},{"line_number":418,"context_line":"        LOG.info(_LI(\"sync: Calling central\u0027s sync.\"))"},{"line_number":419,"context_line":"        return self.client.call(context, \u0027sync\u0027, domain\u003ddomain)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_d89d3c5b","line":417,"updated":"2014-11-12 13:18:50.000000000","message":"This should live under the \"Domain\" methods I reckon, and as discussed, we need to figure a proper name out!","commit_id":"022c25250e8fa0058ca1a9932f239c9d786feaf2"}],"designate/central/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"84d7ba8c93802d8f8e091966e46537c2b27f495e","unresolved":false,"context_lines":[{"line_number":1864,"context_line":"        self.storage.update_domain(context, domain)"},{"line_number":1865,"context_line":""},{"line_number":1866,"context_line":"    @transaction"},{"line_number":1867,"context_line":"    def sync(self, context, domain):"},{"line_number":1868,"context_line":"        zone \u003d self.create_domain(context, domain)"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"        for rrset_data in domain.recordsets:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_38ae4086","line":1867,"updated":"2014-11-12 13:18:50.000000000","message":"Again, should probably be grouped with the other domain methods.","commit_id":"022c25250e8fa0058ca1a9932f239c9d786feaf2"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e5dde150f6ba2765281db3cc54feb7cd5c5b0f80","unresolved":false,"context_lines":[{"line_number":1864,"context_line":"        self.storage.update_domain(context, domain)"},{"line_number":1865,"context_line":""},{"line_number":1866,"context_line":"    @transaction"},{"line_number":1867,"context_line":"    def sync(self, context, domain):"},{"line_number":1868,"context_line":"        zone \u003d self.create_domain(context, domain)"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"        for rrset_data in domain.recordsets:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f3777bd2","line":1867,"in_reply_to":"5a890539_38ae4086","updated":"2014-11-12 13:46:44.000000000","message":"could this be part of the create_domain function - if the domain object passed in has recordsets it does the for loop below?","commit_id":"022c25250e8fa0058ca1a9932f239c9d786feaf2"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"e5dde150f6ba2765281db3cc54feb7cd5c5b0f80","unresolved":false,"context_lines":[{"line_number":1868,"context_line":"        zone \u003d self.create_domain(context, domain)"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"        for rrset_data in domain.recordsets:"},{"line_number":1871,"context_line":"            self.create_recordset(context, zone[\u0027id\u0027], rrset_data)"},{"line_number":1872,"context_line":""},{"line_number":1873,"context_line":"        return zone"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_33abc31e","line":1871,"updated":"2014-11-12 13:46:44.000000000","message":"should we be incrementing the serial for every recordset we are creating?","commit_id":"022c25250e8fa0058ca1a9932f239c9d786feaf2"}],"designate/dnsutils.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"84d7ba8c93802d8f8e091966e46537c2b27f495e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    return rrset"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def _record2json(record_type, rdata):"},{"line_number":80,"context_line":"    if record_type \u003d\u003d \u0027MX\u0027:"},{"line_number":81,"context_line":"        return {"},{"line_number":82,"context_line":"            \u0027data\u0027: \u0027%d %s\u0027 % (rdata.preference, rdata.exchange.to_text())"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f8267815","line":79,"updated":"2014-11-12 13:18:50.000000000","message":"I believe we can ditch this method now, as priority has been moved into the data field.. rdata.to_text() should give is what we want, without needing to code special handling for MX/SRV etc etc","commit_id":"022c25250e8fa0058ca1a9932f239c9d786feaf2"}]}