)]}'
{"designate/rpc.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c00cc29ab217204df0029686b664e46baba66765","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            }"},{"line_number":178,"context_line":"            _context.update({\"trace_info\": trace_info})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        return _context"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def deserialize_context(self, context):"},{"line_number":183,"context_line":"        trace_info \u003d context.pop(\"trace_info\", None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_543efdda","line":180,"updated":"2014-11-17 11:26:22.000000000","message":"Should this and the block below possibly be moved into the DesignateContext class itself? or, is it only ever useful to pass this over RPC?","commit_id":"1f69e779122ee212ed5db17e45da368a6e9df4c5"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"36abfb621a9f6700963bf24239f9d4b7bc1d66fb","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            }"},{"line_number":178,"context_line":"            _context.update({\"trace_info\": trace_info})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        return _context"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def deserialize_context(self, context):"},{"line_number":183,"context_line":"        trace_info \u003d context.pop(\"trace_info\", None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_8d4214ac","line":180,"in_reply_to":"5a890539_543efdda","updated":"2014-11-17 13:08:10.000000000","message":"Hm not sure that I get question. \n\n\nWe need to pass this on EVERY RPC request. It\u0027s very important otherwise we won\u0027t init profiler on some services, that will produce some confusion..","commit_id":"1f69e779122ee212ed5db17e45da368a6e9df4c5"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d81fa4a7b1fed748552a5748485187e642ee0cfb","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            }"},{"line_number":178,"context_line":"            _context.update({\"trace_info\": trace_info})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        return _context"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def deserialize_context(self, context):"},{"line_number":183,"context_line":"        trace_info \u003d context.pop(\"trace_info\", None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_6c0fa688","line":180,"in_reply_to":"5a890539_8d4214ac","updated":"2016-01-14 03:50:12.000000000","message":"I will keep this as is, because it is done in the same way in other projects","commit_id":"1f69e779122ee212ed5db17e45da368a6e9df4c5"}],"designate/service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c00cc29ab217204df0029686b664e46baba66765","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # TODO(ekarlso): change this to be loadable via mod import or"},{"line_number":97,"context_line":"        # stevedore?"},{"line_number":98,"context_line":"        self.endpoints \u003d map(profiler.trace_cls(\"rpc\"), endpoints or [self])"},{"line_number":99,"context_line":"        setup_profiler(binary, host)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f7028b08","line":98,"updated":"2014-11-17 11:26:22.000000000","message":"I\u0027m guessing trace_cls needs a class reference, rather than instance of a class?","commit_id":"1f69e779122ee212ed5db17e45da368a6e9df4c5"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d81fa4a7b1fed748552a5748485187e642ee0cfb","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # TODO(ekarlso): change this to be loadable via mod import or"},{"line_number":97,"context_line":"        # stevedore?"},{"line_number":98,"context_line":"        self.endpoints \u003d map(profiler.trace_cls(\"rpc\"), endpoints or [self])"},{"line_number":99,"context_line":"        setup_profiler(binary, host)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_0c706a0a","line":98,"in_reply_to":"5a890539_f7028b08","updated":"2016-01-14 03:50:12.000000000","message":"Kiall, \n\nafter a lot of investigation, we found the better way to add tracing to all RPC services, without this dirty hack. \n\nWe can just add metaclass to base Manager class, which I am going to do now.","commit_id":"1f69e779122ee212ed5db17e45da368a6e9df4c5"}],"etc/designate/api-paste.ini":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"c00cc29ab217204df0029686b664e46baba66765","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[filter:osprofiler]"},{"line_number":48,"context_line":"paste.filter_factory \u003d osprofiler.web:WsgiMiddleware.factory"},{"line_number":49,"context_line":"hmac_keys \u003d SECRET_KEY"},{"line_number":50,"context_line":"enabled \u003d yes"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5a890539_54eb5d77","line":49,"updated":"2014-11-17 11:26:22.000000000","message":"Copy+Paste from IRC:\n\n    11:15 \u003cKiall\u003e boris-42: feature request for osprofiler - allow the middleware to use oslo.config for it\u0027s settings, like the keystone middleware, most projects including designate have moved settings we expect users to modify outside of the api-paste.ini, to help ensure upgrades are easy\n    11:15 \u003cKiall\u003e And.. Ideally, hmac_keys would default to None, which would in turn disable the profiler, rather than defaulting to \"SECRET_KEY\" ;)\n    11:17 \u003cboris-42\u003e Kiall: no\n    11:17 \u003cKiall\u003e lol\n    11:17 \u003cboris-42\u003e Kiall: it will make my life about 10 harder\n    11:17 \u003cboris-42\u003e 10 times*\n    11:18 \u003cboris-42\u003e \u003d)\n    11:18 \u003cboris-42\u003e Kiall:  it will be turned off by defualt via CONF file\n    11:19 \u003cKiall\u003e At the cost of making `apt-get upgrade` require human interaction to resolve the conflict in api-paste.ini, which was a BIG issue for all OpenStack projects thanks to keystone up until they fixed it ;)\n    11:19 \u003cKiall\u003e (I won\u0027t be the only one who says api-paste.ini is not a config file users should need to edit unless their adding custom middleware!)\n    11:21 \u003cKiall\u003e api-paste\u0027s syntax is something $end_user\u0027s simply don\u0027t understand, resolving the conflicts was a big issue for upgrades \"back in the day\"\n    11:25 \u003cboris-42\u003e Kiall: so the thing is that this stuff is already merged in cinder/glance\n    11:25 \u003cKiall\u003e Wait till the distro guys notice :)\n    11:25 \u003cboris-42\u003e Kiall: I can try to make all this stuff via configs *\n    11:25 \u003cboris-42\u003e Kiall: I already faced one guy+)\n    11:25 \u003cboris-42\u003e Kiall:  but he was agaisnt adding new lib*\n    11:25 \u003cboris-42\u003e lol\n    11:26 \u003cKiall\u003e lol.. the KS middleware supports both api-paste, OR oslo.config setup.. It doesn\u0027t look that hard to make it work ;)","commit_id":"1f69e779122ee212ed5db17e45da368a6e9df4c5"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d81fa4a7b1fed748552a5748485187e642ee0cfb","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[filter:osprofiler]"},{"line_number":48,"context_line":"paste.filter_factory \u003d osprofiler.web:WsgiMiddleware.factory"},{"line_number":49,"context_line":"hmac_keys \u003d SECRET_KEY"},{"line_number":50,"context_line":"enabled \u003d yes"}],"source_content_type":"text/x-properties","patch_set":1,"id":"da6ed579_6c38063e","line":49,"in_reply_to":"5a890539_54eb5d77","updated":"2016-01-14 03:50:12.000000000","message":"Finally we finished work on this, and OSprofiler doesn\u0027t need any changes in api-paste.ini files. \n\nSo I am going to update this patch","commit_id":"1f69e779122ee212ed5db17e45da368a6e9df4c5"}]}