)]}'
{"designate/api/admin/controllers/status.py":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"008024b2d09ad07ae7a4935dd06c11f5ef974dd9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Kiall Mac Innes \u003ckiall@hp.com\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_3e48555b","line":1,"updated":"2015-01-08 13:44:34.000000000","message":"Nit, Rackspace no in the license ? :)","commit_id":"921497000b758f98cc6365d76e1a36f13d08be31"}],"designate/api/v2/controllers/root.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"80f9f181d74053ca1c477c9422e871db0d4a8ffa","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    blacklists \u003d blacklists.BlacklistsController()"},{"line_number":60,"context_line":"    errors \u003d errors.ErrorsController()"},{"line_number":61,"context_line":"    pools \u003d pools.PoolsController()"},{"line_number":62,"context_line":"    status \u003d pool_manager_status.PoolManagerStatusController()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_61113c5d","line":62,"updated":"2014-12-15 20:38:20.000000000","message":"I wonder, should we make this an extension rather than an always-on endpoint?\n\nThe way I see it, optional admin-only extensions are free to change between releases, while always-on stuff is part of the permanent \"fixed API\" that we have to support...","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"986af60890972eeb8c9ed60d5a35bdbec8bd390a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    blacklists \u003d blacklists.BlacklistsController()"},{"line_number":60,"context_line":"    errors \u003d errors.ErrorsController()"},{"line_number":61,"context_line":"    pools \u003d pools.PoolsController()"},{"line_number":62,"context_line":"    status \u003d pool_manager_status.PoolManagerStatusController()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_7334af4a","line":62,"in_reply_to":"3a961159_338ea728","updated":"2014-12-15 20:50:00.000000000","message":"For admin stuff, I think we can... The people with access to this API are the people who decide if/when to upgrade.. Dependent code can be updated at the same time. \n\nWe\u0027re exposing some of the internals of pool manager here, which could easily change as releases go forward.. Committing to supporting this exact representation for the life of the V2 API isn\u0027t something we can do, so either it doesn\u0027t merge, or it\u0027s explicitly marked as something we don\u0027t commit to maintaining cross-release compatibility on.","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a33ff61eddad763f8f5ba09f7b46227cd3df84e4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    blacklists \u003d blacklists.BlacklistsController()"},{"line_number":60,"context_line":"    errors \u003d errors.ErrorsController()"},{"line_number":61,"context_line":"    pools \u003d pools.PoolsController()"},{"line_number":62,"context_line":"    status \u003d pool_manager_status.PoolManagerStatusController()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_338ea728","line":62,"in_reply_to":"3a961159_61113c5d","updated":"2014-12-15 20:46:53.000000000","message":"I personally think for things like ^ where people will be writing code against it, we can\u0027t change without an API increase.\n\nAlso, I have concerns about using the /status endpoint for just this - i think we should have it use something like /status/pool_managers","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"8bd52a7425c7670d4c7be55059d5efca06c0de78","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    blacklists \u003d blacklists.BlacklistsController()"},{"line_number":60,"context_line":"    errors \u003d errors.ErrorsController()"},{"line_number":61,"context_line":"    pools \u003d pools.PoolsController()"},{"line_number":62,"context_line":"    status \u003d pool_manager_status.PoolManagerStatusController()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_1368cb86","line":62,"in_reply_to":"3a961159_61113c5d","updated":"2014-12-15 20:44:01.000000000","message":"That was the question I had for reviewers too :-) I will see if anybody else other inputs","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"2df42e6d610f176434d38254658ebc8bb2a39d0f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    blacklists \u003d blacklists.BlacklistsController()"},{"line_number":60,"context_line":"    errors \u003d errors.ErrorsController()"},{"line_number":61,"context_line":"    pools \u003d pools.PoolsController()"},{"line_number":62,"context_line":"    status \u003d pool_manager_status.PoolManagerStatusController()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_4dc62718","line":62,"in_reply_to":"3a961159_7334af4a","updated":"2014-12-16 08:21:44.000000000","message":"+1 to Kialls comments there. Making it a extension / optional would be better I think ?","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"}],"designate/api/v2/views/base.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"80f9f181d74053ca1c477c9422e871db0d4a8ffa","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if isinstance(items, objects.base.PagedListObjectMixin):"},{"line_number":56,"context_line":"            metadata[\u0027total_count\u0027] \u003d items.total_count"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if metadata:"},{"line_number":59,"context_line":"            result[\u0027metadata\u0027] \u003d metadata"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        if \u0027detail\u0027 in request.GET and request.GET[\u0027detail\u0027] \u003d\u003d \u0027yes\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_0102380b","line":58,"updated":"2014-12-15 20:38:20.000000000","message":"Is this needed? metadata will always have a value, even if it\u0027s an empty dict, so rendering shouldn\u0027t fail..","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"8bd52a7425c7670d4c7be55059d5efca06c0de78","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if isinstance(items, objects.base.PagedListObjectMixin):"},{"line_number":56,"context_line":"            metadata[\u0027total_count\u0027] \u003d items.total_count"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if metadata:"},{"line_number":59,"context_line":"            result[\u0027metadata\u0027] \u003d metadata"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        if \u0027detail\u0027 in request.GET and request.GET[\u0027detail\u0027] \u003d\u003d \u0027yes\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_f3b7bf38","line":58,"in_reply_to":"3a961159_0102380b","updated":"2014-12-15 20:44:01.000000000","message":"For collections other than zones and recordsets, without this change, the response includes and empty metadata section. With this change, the response includes metadata only if it is not an empty dict","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3ba1e9e1dbd441d13c0acbf8572e2d297e76fe6f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if isinstance(items, objects.base.PagedListObjectMixin):"},{"line_number":56,"context_line":"            metadata[\u0027total_count\u0027] \u003d items.total_count"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if metadata:"},{"line_number":59,"context_line":"            result[\u0027metadata\u0027] \u003d metadata"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        if \u0027detail\u0027 in request.GET and request.GET[\u0027detail\u0027] \u003d\u003d \u0027yes\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_d377233a","line":58,"in_reply_to":"3a961159_f3b7bf38","updated":"2014-12-15 20:46:16.000000000","message":"Ah, okay.. Yea, I suppose that makes sense :) Ignore ^ comment then..","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"}],"designate/pool_manager/rpcapi.py":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"2df42e6d610f176434d38254658ebc8bb2a39d0f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            context, \u0027update_status\u0027, domain\u003ddomain, destination\u003ddestination,"},{"line_number":82,"context_line":"            status\u003dstatus, actual_serial\u003dactual_serial)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def get_pool_manager_status(self, context, status_id):"},{"line_number":85,"context_line":"        LOG.info(_LI(\"get_pool_manager_status: \\"},{"line_number":86,"context_line":"                     Calling pool manager\u0027s get_pool_manager_status.\"))"},{"line_number":87,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.1\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8de72fac","line":84,"updated":"2014-12-16 08:21:44.000000000","message":"get_status since we have update_status?","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"2df42e6d610f176434d38254658ebc8bb2a39d0f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            \u0027get_pool_manager_status\u0027,"},{"line_number":91,"context_line":"            status_id\u003dstatus_id)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def find_pool_manager_statuses(self, context, criterion\u003dNone, marker\u003dNone,"},{"line_number":94,"context_line":"                                   limit\u003dNone, sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":95,"context_line":"        LOG.info(_LI(\"find_pool_manager_statuses: \\"},{"line_number":96,"context_line":"                     Calling pool manager\u0027s find_pool_manager_statuses.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_2df8fb48","line":93,"updated":"2014-12-16 08:21:44.000000000","message":"Same here ?","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"}],"designate/pool_manager/service.py":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"2df42e6d610f176434d38254658ebc8bb2a39d0f","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            if error_serial \u003e consensus_serial:"},{"line_number":269,"context_line":"                self.central_api.update_status("},{"line_number":270,"context_line":"                    context, domain.id, ERROR_STATUS, error_serial)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_pool_manager_status(self, context, status_id):"},{"line_number":273,"context_line":"        policy.check(\u0027get_pool_manager_status\u0027, context)"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8db56f80","line":271,"updated":"2014-12-16 08:21:44.000000000","message":"get_status since update_status?","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"2df42e6d610f176434d38254658ebc8bb2a39d0f","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        return self.cache.get_pool_manager_status(context, status_id)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def find_pool_manager_statuses(self, context, criterion\u003dNone, marker\u003dNone,"},{"line_number":278,"context_line":"                                   limit\u003dNone, sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":279,"context_line":"        policy.check(\u0027find_pool_manager_statuses\u0027, context)"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_2da63b54","line":277,"updated":"2014-12-16 08:21:44.000000000","message":"Same as for above ? ^","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"}],"etc/designate/policy.json":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"2df42e6d610f176434d38254658ebc8bb2a39d0f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"delete_pool\": \"rule:admin\","},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    \"find_pool_manager_statuses\": \"rule:admin\","},{"line_number":81,"context_line":"    \"get_pool_manager_status\": \"rule:admin\","},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    \"diagnostics_ping\": \"rule:admin\","},{"line_number":84,"context_line":"    \"diagnostics_sync_domains\": \"rule:admin\","}],"source_content_type":"application/json","patch_set":3,"id":"3a961159_cd5cd74f","line":81,"updated":"2014-12-16 08:21:44.000000000","message":"Same here, we have update_status already, wouldn\u0027t it be better to have get / find_status vs the ones used here?","commit_id":"f634e6c1aa84673421a9935a0bc724f341e56ab3"}]}