)]}'
{"designate/api/__init__.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"da45925115f9942d8b2d93d3c574cfd1a16b3a61","unresolved":false,"context_lines":[{"line_number":43,"context_line":"CENTRAL_API \u003d None"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def get_central_api():"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    The rpc.get_client() which is called upon the API object initialization"},{"line_number":49,"context_line":"    will cause a assertion error if the designate.rpc.TRANSPORT isn\u0027t setup by"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_102a042c","side":"PARENT","line":46,"updated":"2014-12-10 23:20:42.000000000","message":"How about defining central_api as a property here or in v1/__init__.py so that you do not have to do the following in all the v1 files.\n\ncentral_api \u003d central_rpcapi.CentralAPI.get_instance()","commit_id":"b805f73bc1d8b44910f6b972912f0242d89bba59"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"8640ec9a1684b35a5cfdaec021368071b06bcd79","unresolved":false,"context_lines":[{"line_number":43,"context_line":"CENTRAL_API \u003d None"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def get_central_api():"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    The rpc.get_client() which is called upon the API object initialization"},{"line_number":49,"context_line":"    will cause a assertion error if the designate.rpc.TRANSPORT isn\u0027t setup by"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e2bcc0de","side":"PARENT","line":46,"in_reply_to":"3a961159_102a042c","updated":"2014-12-11 10:46:35.000000000","message":"Agree - That makes sense and will keep things a bit cleaner","commit_id":"b805f73bc1d8b44910f6b972912f0242d89bba59"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"1877bdfecdb1871ec0786c49dc89894273996ff5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"CENTRAL_API \u003d None"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def get_central_api():"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    The rpc.get_client() which is called upon the API object initialization"},{"line_number":49,"context_line":"    will cause a assertion error if the designate.rpc.TRANSPORT isn\u0027t setup by"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_d81b3071","side":"PARENT","line":46,"in_reply_to":"3a961159_e2bcc0de","updated":"2014-12-11 13:00:45.000000000","message":"This is not possible since if you do that as you propose you will get a AssertionError or alike becuase the rpc transport hasn\u0027t been initialized yet.","commit_id":"b805f73bc1d8b44910f6b972912f0242d89bba59"}],"designate/api/v1/limits.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"8dc39da9dd48583ee44e613d8cdb93885ae5e1bb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def get_limits():"},{"line_number":35,"context_line":"    context \u003d flask.request.environ.get(\u0027context\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    central \u003d central_rpcapi.CentralAPI.get_instance()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    absolute_limits \u003d central.get_absolute_limits(context)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6b38faa0","line":37,"updated":"2014-12-09 14:46:52.000000000","message":"I know you\u0027ll kill me due to the number of places - But I think it\u0027s better to name these variables \"*_api\" - e.g. \"central_api\" - so it\u0027s clear at a glance it\u0027s an interface to another part of the system..\n\nThis also lines the names up with these methods:\n\n    @property\n    def central_api(self);\n        # foo","commit_id":"ca1476d48b0b43699f71b67bd063aefeded1217c"}]}