)]}'
{"designate/agent/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"7f2863826bc3ff2a45305554c6f4809bfae6451f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        LOG.info(_LI(\"Started Agent Service\"))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def stop(self):"},{"line_number":36,"context_line":"        super(Service, self).stop()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_1c2de1fd","line":36,"updated":"2015-01-13 21:57:38.000000000","message":"Minor - Since you log the service start, could you also log the service stop","commit_id":"3e7667bbad0e556477fe32489ee06e3d96baee08"}],"designate/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"7f2863826bc3ff2a45305554c6f4809bfae6451f","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    \"\"\""},{"line_number":135,"context_line":"    def __init__(self, host\u003dNone, binary\u003dNone, service_name\u003dNone,"},{"line_number":136,"context_line":"                 endpoints\u003dNone, workers\u003d1000):"},{"line_number":137,"context_line":"        Service.__init__(self, workers)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.host \u003d host"},{"line_number":140,"context_line":"        self.binary \u003d binary"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_af656eb0","line":137,"updated":"2015-01-13 21:57:38.000000000","message":"How about calling the parent init through super (similar to what we do at other places) rather than calling it directly?","commit_id":"3e7667bbad0e556477fe32489ee06e3d96baee08"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"7f2863826bc3ff2a45305554c6f4809bfae6451f","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        :param host: defaults to CONF.host"},{"line_number":151,"context_line":"        :param binary: defaults to basename of executable"},{"line_number":152,"context_line":"        :param topic: defaults to bin_name - \u0027cinder-\u0027 part"},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        if not host:"},{"line_number":155,"context_line":"            host \u003d CONF.host"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_3d0b777e","line":152,"updated":"2015-01-13 21:57:38.000000000","message":"This comment is not valid.","commit_id":"3e7667bbad0e556477fe32489ee06e3d96baee08"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"7f2863826bc3ff2a45305554c6f4809bfae6451f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                          endpoints\u003dendpoints)"},{"line_number":161,"context_line":"        return service_obj"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def start(self):"},{"line_number":164,"context_line":"        for e in self.endpoints:"},{"line_number":165,"context_line":"            if e !\u003d self and hasattr(e, \u0027start\u0027):"},{"line_number":166,"context_line":"                e.start()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_4fe5ea08","line":163,"updated":"2015-01-13 21:57:38.000000000","message":"Wouldn\u0027t you want to call the parent class\u0027s start (and stop in the stop function below) method?","commit_id":"3e7667bbad0e556477fe32489ee06e3d96baee08"}]}