)]}'
{"designate/agent/axfr.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"14929d74de6ab0255a54d4b5299074c47b796cad","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                 {\u0027name\u0027: zone_name, \u0027host\u0027: master})"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        xfr \u003d dns.query.xfr(master[\u0027ip\u0027], zone_name, relativize\u003dFalse,"},{"line_number":52,"context_line":"                            port\u003dmaster[\u0027port\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        raw_zone \u003d dns.zone.from_xfr(xfr, relativize\u003dFalse)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_41254bc0","line":52,"updated":"2015-01-16 17:04:53.000000000","message":"Setting the timeout would help detect any config errors.\nAlso catching and logging dns.exception.FormError would be useful.","commit_id":"9ef352c8cb085b92e379693a89a9bcee7910d229"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"d8c5fdc4da9f5632b6419bfc3e084f7c3714886b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                 {\u0027name\u0027: zone_name, \u0027host\u0027: master})"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        xfr \u003d dns.query.xfr(master[\u0027ip\u0027], zone_name, relativize\u003dFalse,"},{"line_number":52,"context_line":"                            port\u003dmaster[\u0027port\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        raw_zone \u003d dns.zone.from_xfr(xfr, relativize\u003dFalse)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_f79dbc6d","line":52,"in_reply_to":"3a961159_41254bc0","updated":"2015-01-20 18:42:38.000000000","message":"Agreed. Timeout should be a config value.","commit_id":"9ef352c8cb085b92e379693a89a9bcee7910d229"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"14929d74de6ab0255a54d4b5299074c47b796cad","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        domain \u003d dnsutils.from_dnspython_zone(raw_zone)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Call into a backend now"},{"line_number":59,"context_line":"        if domain.name \u003d\u003d zone_name:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"%(name)s AXFR SUCCESSFUL\") % {\u0027name\u0027: zone_name})"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_1c572802","line":59,"updated":"2015-01-16 17:04:53.000000000","message":"Would there be a case where this is not true? If so we should log a warning and discard it.","commit_id":"9ef352c8cb085b92e379693a89a9bcee7910d229"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"d8c5fdc4da9f5632b6419bfc3e084f7c3714886b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        domain \u003d dnsutils.from_dnspython_zone(raw_zone)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Call into a backend now"},{"line_number":59,"context_line":"        if domain.name \u003d\u003d zone_name:"},{"line_number":60,"context_line":"            LOG.info(_LI(\"%(name)s AXFR SUCCESSFUL\") % {\u0027name\u0027: zone_name})"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_37ad8485","line":59,"in_reply_to":"3a961159_1c572802","updated":"2015-01-20 18:42:38.000000000","message":"This is just a sanity check for this commit. It\u0027s removed when there is actually a backend call: https://review.openstack.org/#/c/140819/8/designate/agent/axfr.py","commit_id":"9ef352c8cb085b92e379693a89a9bcee7910d229"}],"designate/agent/handler.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"14929d74de6ab0255a54d4b5299074c47b796cad","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        :param request: DNS Request Message"},{"line_number":37,"context_line":"        :return: DNS Response Message"},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":"        if request.opcode() \u003d\u003d dns.opcode.NOTIFY:"},{"line_number":40,"context_line":"            response \u003d self._handle_notify(request)"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            # Unhandled OpCode\u0027s include STATUS, QUERY, IQUERY, UPDATE"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_1c3ba8ea","line":39,"updated":"2015-01-16 17:04:53.000000000","message":"To be a little more robust, it would be good to check the other fields other than opcode too - e.g. rdclass (IN for a regular notify).","commit_id":"9ef352c8cb085b92e379693a89a9bcee7910d229"}]}