)]}'
{"designate/tests/test_api/test_v1/test_domains.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"aad8945db605801ea057900e1128cc5d0e65fd60","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        domain \u003d self.create_domain()"},{"line_number":197,"context_line":"        response \u003d self.get(\u0027domains/%s/servers\u0027 % domain[\u0027id\u0027])"},{"line_number":198,"context_line":"        # Verify list servers for a domain"},{"line_number":199,"context_line":"        self.assertIsNotNone(len(response.json[\u0027servers\u0027]))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @patch.object(central_service.Service, \u0027find_domains\u0027,"},{"line_number":202,"context_line":"                  side_effect\u003dmessaging.MessagingTimeout())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_d7e06498","line":199,"updated":"2014-12-11 10:26:45.000000000","message":"I think this will always pass, and len() will return a number rather than None for an empty list. Our tests always have 1 server created by default, so we can ensure here the len() is 1","commit_id":"8ad83bdd29f4e40bbef1e18b3e4e710d3b439bcd"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"122d29c873a0f640aa88541305c519ca2e4817d8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        domain \u003d self.create_domain()"},{"line_number":197,"context_line":"        response \u003d self.get(\u0027domains/%s/servers\u0027 % domain[\u0027id\u0027])"},{"line_number":198,"context_line":"        # Verify list servers for a domain"},{"line_number":199,"context_line":"        self.assertIsNotNone(len(response.json[\u0027servers\u0027]))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @patch.object(central_service.Service, \u0027find_domains\u0027,"},{"line_number":202,"context_line":"                  side_effect\u003dmessaging.MessagingTimeout())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ce009f04","line":199,"in_reply_to":"3a961159_d7e06498","updated":"2014-12-12 15:51:09.000000000","message":"Done","commit_id":"8ad83bdd29f4e40bbef1e18b3e4e710d3b439bcd"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"c27c519fe19e49e994face23a09215e49236b360","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        response \u003d self.get(\u0027domains/%s/servers\u0027 % domain[\u0027id\u0027])"},{"line_number":198,"context_line":"        # Verify list servers for a domain"},{"line_number":199,"context_line":"        self.assertIsNotNone(len(response.json[\u0027servers\u0027]))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @patch.object(central_service.Service, \u0027find_domains\u0027,"},{"line_number":202,"context_line":"                  side_effect\u003dmessaging.MessagingTimeout())"},{"line_number":203,"context_line":"    def test_get_domains_timeout(self, _):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6319a8d6","line":200,"updated":"2014-12-11 16:32:05.000000000","message":"Also, I would suggest calling the test: test_get_domain_servers() as it more closely resembles the uri for it","commit_id":"8ad83bdd29f4e40bbef1e18b3e4e710d3b439bcd"},{"author":{"_account_id":2222,"name":"meenakshi-m","username":"meenakshi-m"},"change_message_id":"122d29c873a0f640aa88541305c519ca2e4817d8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        response \u003d self.get(\u0027domains/%s/servers\u0027 % domain[\u0027id\u0027])"},{"line_number":198,"context_line":"        # Verify list servers for a domain"},{"line_number":199,"context_line":"        self.assertIsNotNone(len(response.json[\u0027servers\u0027]))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @patch.object(central_service.Service, \u0027find_domains\u0027,"},{"line_number":202,"context_line":"                  side_effect\u003dmessaging.MessagingTimeout())"},{"line_number":203,"context_line":"    def test_get_domains_timeout(self, _):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_29091d2c","line":200,"in_reply_to":"3a961159_6319a8d6","updated":"2014-12-12 15:51:09.000000000","message":"Done","commit_id":"8ad83bdd29f4e40bbef1e18b3e4e710d3b439bcd"}]}