)]}'
{"designate/backend/base.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"06eeb9569c50a66e50bd11f53298d3f98a3192c1","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        value \u003d None"},{"line_number":270,"context_line":"        try:"},{"line_number":271,"context_line":"            value \u003d cfg.CONF[server_section_name].get(key)"},{"line_number":272,"context_line":"        except cfg.NoSuchOptError:"},{"line_number":273,"context_line":"            pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if value is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_3438983c","line":272,"updated":"2014-12-12 13:03:19.000000000","message":"Should this be checking for None as well?","commit_id":"a6fa705ef814c0cc84f843d313755d80cf750828"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"8347e1b5e1588663d5e2997e75d37e8e4030e24b","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        value \u003d None"},{"line_number":270,"context_line":"        try:"},{"line_number":271,"context_line":"            value \u003d cfg.CONF[server_section_name].get(key)"},{"line_number":272,"context_line":"        except cfg.NoSuchOptError:"},{"line_number":273,"context_line":"            pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if value is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_345df879","line":272,"in_reply_to":"3a961159_3438983c","updated":"2014-12-12 13:04:49.000000000","message":"No need, if the value is None it will fall through to the next section.","commit_id":"a6fa705ef814c0cc84f843d313755d80cf750828"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"99a3268438f7dca61f80977c84b388ae71976b48","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        value \u003d None"},{"line_number":270,"context_line":"        try:"},{"line_number":271,"context_line":"            value \u003d cfg.CONF[server_section_name].get(key)"},{"line_number":272,"context_line":"        except cfg.NoSuchOptError:"},{"line_number":273,"context_line":"            pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if value is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_971cee6b","line":272,"in_reply_to":"3a961159_345df879","updated":"2014-12-12 13:11:01.000000000","message":"yup - it will... /me cannot the brain today","commit_id":"a6fa705ef814c0cc84f843d313755d80cf750828"}],"designate/backend/impl_bind9_pool.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"06eeb9569c50a66e50bd11f53298d3f98a3192c1","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"CFG_GROUP \u003d \u0027backend:bind9_pool\u0027"},{"line_number":29,"context_line":"DEFAULT_PORT \u003d 5354"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_dedcd4e6","line":28,"updated":"2014-12-12 13:03:19.000000000","message":"What are these 2 used for? - they don\u0027t seem to be constant across all backends","commit_id":"a6fa705ef814c0cc84f843d313755d80cf750828"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"8347e1b5e1588663d5e2997e75d37e8e4030e24b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"CFG_GROUP \u003d \u0027backend:bind9_pool\u0027"},{"line_number":29,"context_line":"DEFAULT_PORT \u003d 5354"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_f47ff0dd","line":28,"in_reply_to":"3a961159_dedcd4e6","updated":"2014-12-12 13:04:49.000000000","message":"Leftovers - Should be removed :)","commit_id":"a6fa705ef814c0cc84f843d313755d80cf750828"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"99a3268438f7dca61f80977c84b388ae71976b48","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"CFG_GROUP \u003d \u0027backend:bind9_pool\u0027"},{"line_number":29,"context_line":"DEFAULT_PORT \u003d 5354"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_b4000803","line":28,"in_reply_to":"3a961159_f47ff0dd","updated":"2014-12-12 13:11:01.000000000","message":"they should probably be cleaned up across the board - seen as you are making config changes anyway ;)","commit_id":"a6fa705ef814c0cc84f843d313755d80cf750828"}],"designate/backend/impl_dynect.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"3a931c30521b5901dcc1e012b886a1c44d03fe88","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"CFG_GROUP \u003d \u0027backend:dynect\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class DynClientError(exceptions.Backend):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_77e5c207","line":33,"updated":"2014-12-12 13:18:47.000000000","message":"None of the new backends use ^. We should be consistant across all the backends","commit_id":"06c12b94ccd839469c20b0e91bb24fab05f4589f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"dadd0cbcf2549e719d54cf434e4682168e757869","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"CFG_GROUP \u003d \u0027backend:dynect\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class DynClientError(exceptions.Backend):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_57a606af","line":33,"in_reply_to":"3a961159_77e5c207","updated":"2014-12-12 13:21:47.000000000","message":"The pool backends don\u0027t need this value, hence they don\u0027t have it. As these are converted to pool backends, it will no longer be necessary and can be removed then. In the meantime, the config group is used in a couple of places below.","commit_id":"06c12b94ccd839469c20b0e91bb24fab05f4589f"}],"designate/backend/impl_multi.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"3a931c30521b5901dcc1e012b886a1c44d03fe88","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"CFG_GROUP \u003d \u0027backend:multi\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class MultiBackend(base.Backend):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_d7bd96d9","line":27,"updated":"2014-12-12 13:18:47.000000000","message":"None of the new backends use ^. We should be consistant across all the backends","commit_id":"06c12b94ccd839469c20b0e91bb24fab05f4589f"}],"designate/backend/impl_nsd4slave.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"3a931c30521b5901dcc1e012b886a1c44d03fe88","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CFG_GROUP \u003d \u0027backend:nsd4slave\u0027"},{"line_number":32,"context_line":"DEFAULT_PORT \u003d 8952"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_17b47ef0","line":31,"updated":"2014-12-12 13:18:47.000000000","message":"None of the new backends use ^. We should be consistant across all the backends","commit_id":"06c12b94ccd839469c20b0e91bb24fab05f4589f"}],"designate/backend/impl_powerdns/__init__.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"3a931c30521b5901dcc1e012b886a1c44d03fe88","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":"TSIG_SUPPORTED_ALGORITHMS \u003d [\u0027hmac-md5\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_57d1a621","line":37,"updated":"2014-12-12 13:18:47.000000000","message":"None of the new backends use ^. We should be consistant across all the backends","commit_id":"06c12b94ccd839469c20b0e91bb24fab05f4589f"}],"designate/backend/impl_powerdns_mdns/__init__.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"3a931c30521b5901dcc1e012b886a1c44d03fe88","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from designate.sqlalchemy import session"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def _map_col(keys, col):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_1782beff","line":31,"updated":"2014-12-12 13:18:47.000000000","message":"None of the new backends use ^. We should be consistant across all the backends","commit_id":"06c12b94ccd839469c20b0e91bb24fab05f4589f"}]}