)]}'
{"designate/api/v2/controllers/recordsets.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"74b85223b3997dd0890dc33bd84abdcc9de98a6a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            recordset.records.append(Record(data\u003drecord))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Persist the resource"},{"line_number":187,"context_line":"        recordset \u003d self.central_api.update_recordset(context, recordset)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        response.status_int \u003d 200"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8d739ab3","line":187,"updated":"2014-12-16 18:18:01.000000000","message":"So now is it worth the effort for the api to do these calculations, when storage would be doing them again?","commit_id":"95e824993db148a867ce2eeb839fcb9d90173d53"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"19bc605c90ff792fa7361fc7349dd34860e0cb73","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            recordset.records.append(Record(data\u003drecord))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Persist the resource"},{"line_number":187,"context_line":"        recordset \u003d self.central_api.update_recordset(context, recordset)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        response.status_int \u003d 200"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_6a6e5798","line":187,"updated":"2014-12-16 16:38:07.000000000","message":"storage\u0027s update_recordset tries to do the same thing. Can we optimize here and ensure that storage\u0027s update_recordset does not try to do the computations again if everything is done already?","commit_id":"95e824993db148a867ce2eeb839fcb9d90173d53"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"e218a7d07e0e15edaa2ca7c7bebbf9eb6b91e785","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            recordset.records.append(Record(data\u003drecord))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Persist the resource"},{"line_number":187,"context_line":"        recordset \u003d self.central_api.update_recordset(context, recordset)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        response.status_int \u003d 200"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_eae167d1","line":187,"in_reply_to":"3a961159_2a87ef10","updated":"2014-12-16 16:47:14.000000000","message":"Well - We could in theory have list objects track their changes better, letting us just do it once at the edge (well, inside the objects code).. But, this would certainly need some thought to make sure it always works for our use cases.. Probably best to call that a Feature for later in the cycle","commit_id":"95e824993db148a867ce2eeb839fcb9d90173d53"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"492f1cd8cf1edbe17d6488373a3011bf09c9fe7b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            recordset.records.append(Record(data\u003drecord))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Persist the resource"},{"line_number":187,"context_line":"        recordset \u003d self.central_api.update_recordset(context, recordset)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        response.status_int \u003d 200"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_2a87ef10","line":187,"in_reply_to":"3a961159_6a6e5798","updated":"2014-12-16 16:43:23.000000000","message":"Unfortunately not, with the current objects code. The update could come from an AFXR / designate-sink / etc and we still need to do that check at the storage level. We have to do additional checks here, as the id\u0027s of the records are not available (they are not sent as part of the API request, so we have to manually match based on data.) The storage code is based on what records have ID\u0027s. and data changed.","commit_id":"95e824993db148a867ce2eeb839fcb9d90173d53"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2861af255612979a876041c095a1a89339a8a8e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            recordset.records.append(Record(data\u003drecord))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # Persist the resource"},{"line_number":187,"context_line":"        recordset \u003d self.central_api.update_recordset(context, recordset)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        response.status_int \u003d 200"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_e2d7c4eb","line":187,"in_reply_to":"3a961159_8d739ab3","updated":"2014-12-16 21:16:39.000000000","message":"unfortunately yes - as the API currently breaks the information that storage layer needs to do the calculations.","commit_id":"95e824993db148a867ce2eeb839fcb9d90173d53"}]}