)]}'
{"designate/objects/domain.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"843223dc7be7dc2729d87298b75173c5e3dcc5e3","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def __str__(self):"},{"line_number":200,"context_line":"        return (_(\"%(type)s domain %(name)s with id %(id)s in pool\""},{"line_number":201,"context_line":"                  \" %(pool_id)s, serial %(serial)s currently %(action)s \""},{"line_number":202,"context_line":"                  \"%(status)s\")"},{"line_number":203,"context_line":"                % self)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_dc0df1e9","line":202,"updated":"2015-03-25 12:23:18.000000000","message":"I like the general idea, but as these will end up in the logs, we\u0027ll end up with some really odd looking/reading logs \"Updating PRIMARY domain foo.com with id \u003cUUID\u003e and status \u003cSTATUS\u003e to \u003cSAME_STATUS\u003e etc\"\n\nI think we would be better off not making __str__ a human readable sentence, and instead doing a pattern like:\n\n    \u003cDomain {name} id\u003d{id}\u003e\n\nThis leaves a clear demarcation between the log message, which has the context of what\u0027s happening, and the thing being acted on\u003e\n\nI\u0027ve also intentionally left out much of the other detail - as the log messages around this in 90% of cases already provide the detail, while this will have ambiguous detail (e.g. the status field - is that before or after the transition from CREATING -\u003e None etc?).","commit_id":"43447261c7c02fc13617b7d22d557cbf6dc65e9e"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"f558e1f6b543b72a0652a0cff2671690b671d798","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def __str__(self):"},{"line_number":200,"context_line":"        return (_(\"%(type)s domain %(name)s with id %(id)s in pool\""},{"line_number":201,"context_line":"                  \" %(pool_id)s, serial %(serial)s currently %(action)s \""},{"line_number":202,"context_line":"                  \"%(status)s\")"},{"line_number":203,"context_line":"                % self)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_68bc3707","line":202,"in_reply_to":"1a6ced46_dc0df1e9","updated":"2015-03-25 13:53:59.000000000","message":"Done","commit_id":"43447261c7c02fc13617b7d22d557cbf6dc65e9e"}]}