)]}'
{"designate/pool_manager/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"b143222c459d2f717f4bb6b4c0b0ff416062718a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        # whereas BIND9 does an AXFR implicitly after the domain is created."},{"line_number":179,"context_line":"        # Sending a NOTIFY for all cases."},{"line_number":180,"context_line":"        self._notify_servers_zone_changed(context, domain)"},{"line_number":181,"context_line":"        self._poll_servers_for_serial_number(context, domain)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @execute_on_pool(cfg.CONF[\u0027service:pool_manager\u0027].pool_id)"},{"line_number":184,"context_line":"    def delete_domain(self, context, domain):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_3285e4ac","line":181,"updated":"2015-01-08 16:44:36.000000000","message":"We end up notifying and polling all servers - even those in error. Instead  could we notify and poll only the success servers - at line 165 above.","commit_id":"67ba506c851cb0de192fca3fe7af423cdc48dd19"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"1c89924d262a0e30ce8ca33ed6a21e88720840dd","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        # whereas BIND9 does an AXFR implicitly after the domain is created."},{"line_number":179,"context_line":"        # Sending a NOTIFY for all cases."},{"line_number":180,"context_line":"        self._notify_servers_zone_changed(context, domain)"},{"line_number":181,"context_line":"        self._poll_servers_for_serial_number(context, domain)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @execute_on_pool(cfg.CONF[\u0027service:pool_manager\u0027].pool_id)"},{"line_number":184,"context_line":"    def delete_domain(self, context, domain):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_d36d7f04","line":181,"in_reply_to":"3a961159_3285e4ac","updated":"2015-01-08 19:14:57.000000000","message":"Agreed.  Will fix this.","commit_id":"67ba506c851cb0de192fca3fe7af423cdc48dd19"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"b143222c459d2f717f4bb6b4c0b0ff416062718a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        status \u003d ERROR_STATUS"},{"line_number":206,"context_line":"        if self._is_delete_consensus(context, domain):"},{"line_number":207,"context_line":"            status \u003d SUCCESS_STATUS"},{"line_number":208,"context_line":"        self.central_api.update_status("},{"line_number":209,"context_line":"            context, domain.id, status, domain.serial)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @execute_on_pool(cfg.CONF[\u0027service:pool_manager\u0027].pool_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_32ac0435","line":208,"updated":"2015-01-08 16:44:36.000000000","message":"For another patchset - delete domain could potentially have the same issue as create domain.","commit_id":"67ba506c851cb0de192fca3fe7af423cdc48dd19"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"1c89924d262a0e30ce8ca33ed6a21e88720840dd","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        status \u003d ERROR_STATUS"},{"line_number":206,"context_line":"        if self._is_delete_consensus(context, domain):"},{"line_number":207,"context_line":"            status \u003d SUCCESS_STATUS"},{"line_number":208,"context_line":"        self.central_api.update_status("},{"line_number":209,"context_line":"            context, domain.id, status, domain.serial)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @execute_on_pool(cfg.CONF[\u0027service:pool_manager\u0027].pool_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_339083ec","line":208,"in_reply_to":"3a961159_32ac0435","updated":"2015-01-08 19:14:57.000000000","message":"It doesn\u0027t.","commit_id":"67ba506c851cb0de192fca3fe7af423cdc48dd19"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"b143222c459d2f717f4bb6b4c0b0ff416062718a","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        for server_backend in self.server_backends:"},{"line_number":340,"context_line":"            server \u003d server_backend[\u0027server\u0027]"},{"line_number":341,"context_line":"            update_status \u003d self._retrieve_from_cache("},{"line_number":342,"context_line":"                context, server, domain, UPDATE_ACTION)"},{"line_number":343,"context_line":"            if update_status.serial_number \u003c domain.serial:"},{"line_number":344,"context_line":"                self._notify_zone_changed(context, domain, server)"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_9f06a01a","line":342,"updated":"2015-01-08 16:44:36.000000000","message":"Here the assumption is that the cache always reflects the state of the server correctly.  How accurate would that be in a production environment?","commit_id":"67ba506c851cb0de192fca3fe7af423cdc48dd19"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"1c89924d262a0e30ce8ca33ed6a21e88720840dd","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        for server_backend in self.server_backends:"},{"line_number":340,"context_line":"            server \u003d server_backend[\u0027server\u0027]"},{"line_number":341,"context_line":"            update_status \u003d self._retrieve_from_cache("},{"line_number":342,"context_line":"                context, server, domain, UPDATE_ACTION)"},{"line_number":343,"context_line":"            if update_status.serial_number \u003c domain.serial:"},{"line_number":344,"context_line":"                self._notify_zone_changed(context, domain, server)"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_b3b39398","line":342,"in_reply_to":"3a961159_9f06a01a","updated":"2015-01-08 19:14:57.000000000","message":"For the current implementation, accurate.","commit_id":"67ba506c851cb0de192fca3fe7af423cdc48dd19"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"b143222c459d2f717f4bb6b4c0b0ff416062718a","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def _periodic_poll_servers_for_serial_number(self, context, domains):"},{"line_number":361,"context_line":"        for domain in domains:"},{"line_number":362,"context_line":"            self._poll_servers_for_serial_number(context, domain)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _get_server_backend(self, server_id):"},{"line_number":365,"context_line":"        for server_backend in self.server_backends:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_5f4ef86f","line":362,"updated":"2015-01-08 16:44:36.000000000","message":"Do we need these 1 or 2 line functions? I find trying to trace through a function to see what happens more difficult.","commit_id":"67ba506c851cb0de192fca3fe7af423cdc48dd19"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"1c89924d262a0e30ce8ca33ed6a21e88720840dd","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def _periodic_poll_servers_for_serial_number(self, context, domains):"},{"line_number":361,"context_line":"        for domain in domains:"},{"line_number":362,"context_line":"            self._poll_servers_for_serial_number(context, domain)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _get_server_backend(self, server_id):"},{"line_number":365,"context_line":"        for server_backend in self.server_backends:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_f3b0bb8c","line":362,"in_reply_to":"3a961159_5f4ef86f","updated":"2015-01-08 19:14:57.000000000","message":"So we disagree on style...","commit_id":"67ba506c851cb0de192fca3fe7af423cdc48dd19"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"28b43f80f37766482dfe2ebfb405d6bd3f5628a3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                update_status.status \u003d ERROR_STATUS"},{"line_number":175,"context_line":"                self._store_in_cache(context, update_status)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if create_status.status \u003d\u003d SUCCESS_STATUS:"},{"line_number":178,"context_line":"                # PowerDNS needs to explicitly send a NOTIFY for the AXFR to"},{"line_number":179,"context_line":"                # happen whereas BIND9 does an AXFR implicitly after the domain"},{"line_number":180,"context_line":"                # is created.  Sending a NOTIFY for all cases."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_89674a24","line":177,"updated":"2015-01-08 20:24:11.000000000","message":"If the below lines go after line 165 above, the check for status being success need not be done.","commit_id":"b663062ebf6095c9312515ccb3e37cdb103b1589"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"b597d487f67c6d37bbe32b34a08faf58733e10f8","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                update_status.status \u003d ERROR_STATUS"},{"line_number":175,"context_line":"                self._store_in_cache(context, update_status)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if create_status.status \u003d\u003d SUCCESS_STATUS:"},{"line_number":178,"context_line":"                # PowerDNS needs to explicitly send a NOTIFY for the AXFR to"},{"line_number":179,"context_line":"                # happen whereas BIND9 does an AXFR implicitly after the domain"},{"line_number":180,"context_line":"                # is created.  Sending a NOTIFY for all cases."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_eaab5d1b","line":177,"in_reply_to":"3a961159_89674a24","updated":"2015-01-08 21:43:59.000000000","message":"Vinod, the code in the finally block is needed for this to work.\n\nI understand we want to rewrite this to not persist the status messages.  This patch is not addressing that.  I promise you, I will straighten that out.","commit_id":"b663062ebf6095c9312515ccb3e37cdb103b1589"}]}