)]}'
{"designate/pool_manager/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"7521fc87c8cfc90a65e6e47d2b78e011d7a46847","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            self.server_backends.append(server_backend)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if not self.server_backends:"},{"line_number":118,"context_line":"            raise exceptions.NoServersConfigured()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.thread_group \u003d threadgroup.ThreadGroup()"},{"line_number":121,"context_line":"        self.admin_context \u003d DesignateContext.get_admin_context("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_e4f9d3c8","line":118,"updated":"2015-01-08 20:45:47.000000000","message":"We seem to throw the same exception when nameservers are not configured and pool backend servers are not configured. It could be confusing to figure out which ones the error is referring to. It would be good to either log extra information here - to indicate that we are referring to pool backends or throw a different exception.","commit_id":"0a5eb1f54ace509b1a628a11389c4115ffc05cc7"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"56f90afafad3fc4bbb2ea583e159a47f2e2082df","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            self.server_backends.append(server_backend)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if not self.server_backends:"},{"line_number":118,"context_line":"            raise exceptions.NoServersConfigured()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.thread_group \u003d threadgroup.ThreadGroup()"},{"line_number":121,"context_line":"        self.admin_context \u003d DesignateContext.get_admin_context("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_474ebb6f","line":118,"in_reply_to":"3a961159_ca25c1c2","updated":"2015-01-13 16:34:42.000000000","message":"Calling this as something like NoPoolBackendServersConfigured would make things easier.\n\nWe now have 2 servers - nameservers and pool backend servers. The central refers to nameservers and here we refer to pool backend servers. It is much easier to tell support what action to take based on the exception, rather than say look at the exception and then look at the stack.","commit_id":"0a5eb1f54ace509b1a628a11389c4115ffc05cc7"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"cb7ea82772c8bf84f40c0e13879c703ce8fc7624","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            self.server_backends.append(server_backend)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if not self.server_backends:"},{"line_number":118,"context_line":"            raise exceptions.NoServersConfigured()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.thread_group \u003d threadgroup.ThreadGroup()"},{"line_number":121,"context_line":"        self.admin_context \u003d DesignateContext.get_admin_context("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_ca25c1c2","line":118,"in_reply_to":"3a961159_e4f9d3c8","updated":"2015-01-08 21:50:18.000000000","message":"Are you referencing to this error being thrown in another component (namely Central)?  Isn\u0027t the context in which these are being thrown enough?","commit_id":"0a5eb1f54ace509b1a628a11389c4115ffc05cc7"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"5e94395e52853fc14e4b63a6c99d59e106fbef56","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                return server"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @staticmethod"},{"line_number":397,"context_line":"    def _percentage(count, total_count):"},{"line_number":398,"context_line":"        return (float(count) / float(total_count)) * 100.0"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def _exceed_or_meet_threshold(self, count, total_count):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_874e5c6d","line":397,"updated":"2015-01-08 15:16:20.000000000","message":"total_count could still potentially be zero, when you do not find any matching entries in the cache.","commit_id":"0a5eb1f54ace509b1a628a11389c4115ffc05cc7"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"cb7ea82772c8bf84f40c0e13879c703ce8fc7624","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                return server"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @staticmethod"},{"line_number":397,"context_line":"    def _percentage(count, total_count):"},{"line_number":398,"context_line":"        return (float(count) / float(total_count)) * 100.0"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def _exceed_or_meet_threshold(self, count, total_count):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_9f9ce00f","line":397,"in_reply_to":"3a961159_874e5c6d","updated":"2015-01-08 21:50:18.000000000","message":"At this point, there is always an entry in the cache.\n\nRemember, everything is still persisted in cache.  We have not modified the code to fix that yet.","commit_id":"0a5eb1f54ace509b1a628a11389c4115ffc05cc7"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"56f90afafad3fc4bbb2ea583e159a47f2e2082df","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                return server"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @staticmethod"},{"line_number":397,"context_line":"    def _percentage(count, total_count):"},{"line_number":398,"context_line":"        return (float(count) / float(total_count)) * 100.0"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def _exceed_or_meet_threshold(self, count, total_count):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_ccd3b2d1","line":397,"in_reply_to":"3a961159_9f9ce00f","updated":"2015-01-13 16:34:42.000000000","message":"https://review.openstack.org/#/c/146246/ would address this.","commit_id":"0a5eb1f54ace509b1a628a11389c4115ffc05cc7"}]}