)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"93c3e0ee16ec3366d80632d2afddd2a019ab9a4a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- The same code is reused to delete domains on failure as is used to delete"},{"line_number":20,"context_line":"  domains the first time."},{"line_number":21,"context_line":"- Unhandled exceptions are trapped if periodic recovery or periodic sync"},{"line_number":22,"context_line":"  encounter them to prevent the threads from dying.  This is logged."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I2ae4a7fdc556ce2d9efd5fd91f73dc005c5a8d00"},{"line_number":25,"context_line":"Closes-Bug: 1406414"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_58095c31","line":22,"updated":"2015-01-12 22:10:15.000000000","message":"Very informative commit message.","commit_id":"758fe8c3775c87ddb03b184e75f82bd91f3c83f9"}],"designate/pool_manager/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"93c3e0ee16ec3366d80632d2afddd2a019ab9a4a","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            try:"},{"line_number":413,"context_line":"                update_status \u003d self._retrieve_from_cache("},{"line_number":414,"context_line":"                    context, server, domain, UPDATE_ACTION)"},{"line_number":415,"context_line":"                if update_status.serial_number \u003c domain.serial:"},{"line_number":416,"context_line":"                    self._notify_zone_changed(context, domain, server)"},{"line_number":417,"context_line":"            except exceptions.PoolManagerStatusNotFound:"},{"line_number":418,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_f89768e9","line":415,"updated":"2015-01-12 22:10:15.000000000","message":"I would think, the update_status.serial number too should be updated here (but not the status), otherwise we may be miss notifying some updates.","commit_id":"758fe8c3775c87ddb03b184e75f82bd91f3c83f9"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"93c3e0ee16ec3366d80632d2afddd2a019ab9a4a","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                    context, server, domain, UPDATE_ACTION)"},{"line_number":415,"context_line":"                if update_status.serial_number \u003c domain.serial:"},{"line_number":416,"context_line":"                    self._notify_zone_changed(context, domain, server)"},{"line_number":417,"context_line":"            except exceptions.PoolManagerStatusNotFound:"},{"line_number":418,"context_line":"                pass"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def _periodic_notify_servers_zone_changed(self, context, domains):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b871600e","line":417,"updated":"2015-01-12 22:10:15.000000000","message":"While the server is not notified if the update status is not found, a poll_for_serial_number is still done. Instead of catching this exception here, if we catch it at the place where we call notify and poll, we can skip both of them.","commit_id":"758fe8c3775c87ddb03b184e75f82bd91f3c83f9"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"b8069e74dff74cc29ff36dfe57088fa4fc9ce373","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                LOG.warn(_LW(\u0027No need to update domain %(domain)s \u0027"},{"line_number":410,"context_line":"                         \u0027on server %(server)s.\u0027) %"},{"line_number":411,"context_line":"                         {\u0027domain\u0027: domain.name,"},{"line_number":412,"context_line":"                          \u0027server\u0027: self._get_destination(server)})"},{"line_number":413,"context_line":"        except exceptions.PoolManagerStatusNotFound:"},{"line_number":414,"context_line":"            pass"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_14f3ca73","line":412,"updated":"2015-01-14 22:02:07.000000000","message":"This warning makes sense for update domain and _period_update_domains_that_failed, but when periodic_sync runs, we would log a warning for every domain that is already present, every time it runs - that seems excessive.","commit_id":"22fd57253a5ab084a60b447c6c992454f5b9c950"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"fb76855a6b23104594e3d3928ada5edcd94d20b8","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                LOG.warn(_LW(\u0027No need to update domain %(domain)s \u0027"},{"line_number":410,"context_line":"                         \u0027on server %(server)s.\u0027) %"},{"line_number":411,"context_line":"                         {\u0027domain\u0027: domain.name,"},{"line_number":412,"context_line":"                          \u0027server\u0027: self._get_destination(server)})"},{"line_number":413,"context_line":"        except exceptions.PoolManagerStatusNotFound:"},{"line_number":414,"context_line":"            pass"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_bd5ad91b","line":412,"in_reply_to":"3a961159_022b8c82","updated":"2015-01-14 23:16:34.000000000","message":"I will.","commit_id":"22fd57253a5ab084a60b447c6c992454f5b9c950"},{"author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"change_message_id":"805bb193a4728be0f7e49bcbf27edea2ec3229ce","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                LOG.warn(_LW(\u0027No need to update domain %(domain)s \u0027"},{"line_number":410,"context_line":"                         \u0027on server %(server)s.\u0027) %"},{"line_number":411,"context_line":"                         {\u0027domain\u0027: domain.name,"},{"line_number":412,"context_line":"                          \u0027server\u0027: self._get_destination(server)})"},{"line_number":413,"context_line":"        except exceptions.PoolManagerStatusNotFound:"},{"line_number":414,"context_line":"            pass"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_b72f5888","line":412,"in_reply_to":"3a961159_14f3ca73","updated":"2015-01-14 22:10:13.000000000","message":"Vinod, the periodic_sync code (and this code) will change slightly when the statuses are removed from the cache.  i will address this at that point if it is still an issue.","commit_id":"22fd57253a5ab084a60b447c6c992454f5b9c950"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"ecc8d35d45999f1d4e78e35227a440874b6418ea","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                LOG.warn(_LW(\u0027No need to update domain %(domain)s \u0027"},{"line_number":410,"context_line":"                         \u0027on server %(server)s.\u0027) %"},{"line_number":411,"context_line":"                         {\u0027domain\u0027: domain.name,"},{"line_number":412,"context_line":"                          \u0027server\u0027: self._get_destination(server)})"},{"line_number":413,"context_line":"        except exceptions.PoolManagerStatusNotFound:"},{"line_number":414,"context_line":"            pass"},{"line_number":415,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_022b8c82","line":412,"in_reply_to":"3a961159_b72f5888","updated":"2015-01-14 22:39:30.000000000","message":"Thanks Ron - If you are making any other changes - could you add a TODO here so that we do not miss it later.","commit_id":"22fd57253a5ab084a60b447c6c992454f5b9c950"}]}