)]}'
{"designate/tests/test_central/test_service.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a8c67979d0cb2a06e45fc53d97665ab6f424c163","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        with patch.object(self.central_service.storage, \u0027find_tlds\u0027,"},{"line_number":46,"context_line":"                return_value\u003dlist):"},{"line_number":47,"context_line":"            self.central_service.start()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_is_valid_domain_name(self):"},{"line_number":50,"context_line":"        self.config(max_domain_name_len\u003d10,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9a541523","line":47,"updated":"2015-01-16 00:33:33.000000000","message":"Can we add this, to ensure it\u0027s triggered correctly?\n\n    self.assertTrue(self.central_service.check_for_tlds)","commit_id":"66299231749a8ed7cc208d75fb12f73949443b5f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a8c67979d0cb2a06e45fc53d97665ab6f424c163","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        with patch.object(self.central_service.storage, \u0027find_tld\u0027,"},{"line_number":80,"context_line":"                return_value\u003dobjects.Tld(name\u003d\u0027z\u0027)):"},{"line_number":81,"context_line":"            with testtools.ExpectedException(exceptions.InvalidDomainName):"},{"line_number":82,"context_line":"                self.central_service._is_valid_domain_name(context, \u0027bi.z.\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_is_valid_recordset_name(self):"},{"line_number":85,"context_line":"        self.config(max_recordset_name_len\u003d18,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3d6ebbc8","line":82,"updated":"2015-01-16 00:33:33.000000000","message":"This should be valid, 99% sure.. central is doing a `.strip(\u0027.\u0027)` instead of a `.rstrip(\u0027.\u0027)` ..","commit_id":"66299231749a8ed7cc208d75fb12f73949443b5f"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a8c67979d0cb2a06e45fc53d97665ab6f424c163","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        domain.id \u003d None"},{"line_number":831,"context_line":"        # Perform the update"},{"line_number":832,"context_line":"        with testtools.ExpectedException(Exception):"},{"line_number":833,"context_line":"            self.central_service.update_domain(self.admin_context, domain)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"    def test_update_domain_without_incrementing_serial(self):"},{"line_number":836,"context_line":"        # Create a domain"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c3fa38b9","line":833,"updated":"2015-01-16 00:33:33.000000000","message":"Nit - Is it possible to make this exception more specific? I\u0027m guessing we spit out a DomainNotFound or InvalidObject?","commit_id":"66299231749a8ed7cc208d75fb12f73949443b5f"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e02edf553b7dc1ee0fdc401ca73636efab7deae1","unresolved":false,"context_lines":[{"line_number":1389,"context_line":"        recordset.ttl \u003d 1800"},{"line_number":1390,"context_line":"        recordset.tenant_id \u003d \u0027other-tenant\u0027"},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"        # Ensure we get a BadRequest if we change the domain_id"},{"line_number":1393,"context_line":"        with testtools.ExpectedException(exceptions.BadRequest):"},{"line_number":1394,"context_line":"            self.central_service.update_recordset("},{"line_number":1395,"context_line":"                self.admin_context, recordset)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_067fd917","line":1392,"updated":"2015-01-16 15:53:53.000000000","message":"Minor - the comment needs to be updated","commit_id":"659f75d2c7cbea42cefc29d5fa6606f24d4aa6cc"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"e02edf553b7dc1ee0fdc401ca73636efab7deae1","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"        recordset.ttl \u003d 1800"},{"line_number":1406,"context_line":"        recordset.type \u003d cname_recordset.type"},{"line_number":1407,"context_line":""},{"line_number":1408,"context_line":"        # Ensure we get a BadRequest if we change the domain_id"},{"line_number":1409,"context_line":"        with testtools.ExpectedException(exceptions.BadRequest):"},{"line_number":1410,"context_line":"            self.central_service.update_recordset("},{"line_number":1411,"context_line":"                self.admin_context, recordset)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8672e947","line":1408,"updated":"2015-01-16 15:53:53.000000000","message":"Minor - the comment needs to be updated","commit_id":"659f75d2c7cbea42cefc29d5fa6606f24d4aa6cc"}]}