)]}'
{"contrib/designate-dashboard/designatedashboard/dashboards/project/dns_domains/tables.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"ba735f7edea04594244e188beb9e9ef5549f2e27","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        return api.designate.record_delete(request, domain_id, record_id)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def allowed(self, request, record\u003dNone):"},{"line_number":122,"context_line":"        return record.type in EDITABLE_RECORD_TYPES"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class BatchDeleteRecord(tables.BatchAction):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_5cf86fe5","line":122,"updated":"2015-02-27 17:05:53.000000000","message":"Can record be None? If so is the exception shown in Horizon or is it caught elsewhere?","commit_id":"094dba75de8f91ed357cadc5b4de55699156aed7"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"dc7172ce0c4643c9fcbd3c8fc28c9a908418dc74","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        return api.designate.record_delete(request, domain_id, record_id)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def allowed(self, request, record\u003dNone):"},{"line_number":122,"context_line":"        return record.type in EDITABLE_RECORD_TYPES"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class BatchDeleteRecord(tables.BatchAction):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_dfe37131","line":122,"in_reply_to":"ba7be1f8_5cf86fe5","updated":"2015-02-27 17:18:19.000000000","message":"It should be caught elsewhere - as far as I know. I was trying to work around pre-existing code, so I am not sure 100%","commit_id":"094dba75de8f91ed357cadc5b4de55699156aed7"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"ba735f7edea04594244e188beb9e9ef5549f2e27","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        return record.type in EDITABLE_RECORD_TYPES"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class BatchDeleteRecord(tables.BatchAction):"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    \u0027\u0027\u0027Batch action for deleting domain records.\u0027\u0027\u0027"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_bcb88b2b","line":125,"updated":"2015-02-27 17:05:53.000000000","message":"When would BatchDeleteRecord be called? Is it needed?","commit_id":"094dba75de8f91ed357cadc5b4de55699156aed7"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"dc7172ce0c4643c9fcbd3c8fc28c9a908418dc74","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        return record.type in EDITABLE_RECORD_TYPES"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class BatchDeleteRecord(tables.BatchAction):"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    \u0027\u0027\u0027Batch action for deleting domain records.\u0027\u0027\u0027"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_7f4a8528","line":125,"in_reply_to":"ba7be1f8_bcb88b2b","updated":"2015-02-27 17:18:19.000000000","message":"whenever we fix the batch actions it will be needed - currently we can\u0027t as the batch actions will appear on the record types that cannot be edited. It needs future work, but there is no point removing the code that will be used (IMHO)","commit_id":"094dba75de8f91ed357cadc5b4de55699156aed7"}],"contrib/designate-dashboard/designatedashboard/exceptions.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"b6f112fc2188471c9280f32c817be065ffa14e9c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    )"},{"line_number":26,"context_line":"UNAUTHORIZED \u003d ("},{"line_number":27,"context_line":"    designateclient.Forbidden,"},{"line_number":28,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_78a6f411","line":28,"updated":"2015-02-23 17:20:11.000000000","message":"this file is wrong - there is a horizon bug that this will cause problems with\n\nIt should be:\n\nNOT_FOUND \u003d exceptions.NOT_FOUND + (\n    designateclient.ResourceNotFound,\n    designateclient.NotFound,\n    )\nRECOVERABLE \u003d exceptions.RECOVERABLE + (\n    designateclient.BadRequest,\n    designateclient.Conflict,\n    )\nUNAUTHORIZED \u003d exceptions.UNAUTHORIZED + (\n    designateclient.Forbidden,\n    )","commit_id":"459eb3c89559e7417c436953a91447c41a76ab55"}]}