)]}'
{"designate/agent/handler.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"fb56aec3fec9d3c25db34cc3a1903dd5e75337f6","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.allow_notify \u003d CONF[\u0027service:agent\u0027].allow_notify"},{"line_number":54,"context_line":"        self.transfer_source \u003d CONF[\u0027service:agent\u0027].transfer_source \\"},{"line_number":55,"context_line":"            or CONF[\u0027service:agent\u0027].host"},{"line_number":56,"context_line":"        backend_driver \u003d cfg.CONF[\u0027service:agent\u0027].backend_driver"},{"line_number":57,"context_line":"        self.backend \u003d agent_backend.get_backend(backend_driver, self)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_94d19359","line":55,"updated":"2015-02-24 10:45:05.000000000","message":"Not sure if this necessary. It may be None by default","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"6993284e1c59427d770685286b0d61fca116c281","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.allow_notify \u003d CONF[\u0027service:agent\u0027].allow_notify"},{"line_number":54,"context_line":"        self.transfer_source \u003d CONF[\u0027service:agent\u0027].transfer_source \\"},{"line_number":55,"context_line":"            or CONF[\u0027service:agent\u0027].host"},{"line_number":56,"context_line":"        backend_driver \u003d cfg.CONF[\u0027service:agent\u0027].backend_driver"},{"line_number":57,"context_line":"        self.backend \u003d agent_backend.get_backend(backend_driver, self)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_55ae2be7","line":55,"in_reply_to":"ba7be1f8_54c9db76","updated":"2015-02-24 15:37:30.000000000","message":"None is definitely better. Will do that.","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"30662132c8248335541b8b26bfc217e0e0e2facc","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.allow_notify \u003d CONF[\u0027service:agent\u0027].allow_notify"},{"line_number":54,"context_line":"        self.transfer_source \u003d CONF[\u0027service:agent\u0027].transfer_source \\"},{"line_number":55,"context_line":"            or CONF[\u0027service:agent\u0027].host"},{"line_number":56,"context_line":"        backend_driver \u003d cfg.CONF[\u0027service:agent\u0027].backend_driver"},{"line_number":57,"context_line":"        self.backend \u003d agent_backend.get_backend(backend_driver, self)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_54c9db76","line":55,"in_reply_to":"ba7be1f8_94d19359","updated":"2015-02-24 10:56:00.000000000","message":"I\u0027m also curious if this is the right thing to do, if None (or 0.0.0.0) is supplied as the source IP, then I expect the standard linux routing stack kicks in to select a source IP based on available routes towards the destination IP.\n\nI personally think we shouldn\u0027t fallback to host..","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"}],"designate/backend/agent_backend/impl_bind9.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"30662132c8248335541b8b26bfc217e0e0e2facc","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # NOTE: Different versions of BIND9 behave differently with a trailing"},{"line_number":107,"context_line":"        #       dot, so we\u0027re just going to take it off."},{"line_number":108,"context_line":"        domain_name \u003d domain.origin.to_text().rstrip(\u0027.\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # NOTE: Only one thread should be working with the Zonefile at a given"},{"line_number":111,"context_line":"        #       time. The sleep(1) below introduces a not insignificant risk"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_b42f77f5","line":108,"updated":"2015-02-24 10:56:00.000000000","message":"Are we sure every version works without the trailing .? (Just checking :))","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"6993284e1c59427d770685286b0d61fca116c281","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # NOTE: Different versions of BIND9 behave differently with a trailing"},{"line_number":107,"context_line":"        #       dot, so we\u0027re just going to take it off."},{"line_number":108,"context_line":"        domain_name \u003d domain.origin.to_text().rstrip(\u0027.\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # NOTE: Only one thread should be working with the Zonefile at a given"},{"line_number":111,"context_line":"        #       time. The sleep(1) below introduces a not insignificant risk"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_952fc387","line":108,"in_reply_to":"ba7be1f8_b42f77f5","updated":"2015-02-24 15:37:30.000000000","message":"Worked in 9.3 and 9.5, and I believe the change was in 9.4. This is what is in the other bind9 plugin too.","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"}],"designate/dnsutils.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"bbf0469bb4643ccecfc46dde2146cdd28da2c74f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                      {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"def do_axfr(zone_name, masters, **kwargs):"},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    Performs an AXFR for a given zone name"},{"line_number":258,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_0a265ece","line":255,"updated":"2015-02-24 11:53:16.000000000","message":"not a great fan of **kwargs here - I think we are better being explict","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"6993284e1c59427d770685286b0d61fca116c281","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                      {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"def do_axfr(zone_name, masters, **kwargs):"},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    Performs an AXFR for a given zone name"},{"line_number":258,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_b5284787","line":255,"in_reply_to":"ba7be1f8_0a265ece","updated":"2015-02-24 15:37:30.000000000","message":"Generally I agree, but that would mean that secondary zones is required to provide this source, which doesn\u0027t really seem to make much sense. There are a ton of other parameters you might want to pass here too: https://github.com/rthalley/dnspython/blob/master/dns/query.py#L328","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"9aa9722c6d55a9207e3030b747576d635c013d57","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                      {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"def do_axfr(zone_name, masters, **kwargs):"},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    Performs an AXFR for a given zone name"},{"line_number":258,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_c476eba3","line":255,"in_reply_to":"ba7be1f8_1502f36e","updated":"2015-02-24 16:55:53.000000000","message":"Fair enough, I don\u0027t feel strongly about it. I\u0027ll change it.","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"77209ea808d2dc88ff89564d227ceb16891d59ec","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                      {\u0027host\u0027: addr[0], \u0027port\u0027: addr[1]})"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"def do_axfr(zone_name, masters, **kwargs):"},{"line_number":256,"context_line":"    \"\"\""},{"line_number":257,"context_line":"    Performs an AXFR for a given zone name"},{"line_number":258,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_1502f36e","line":255,"in_reply_to":"ba7be1f8_b5284787","updated":"2015-02-24 16:52:03.000000000","message":"If we do source\u003dNone, and then \n\n  xfr \u003d dns.query.xfr(master[\u0027ip\u0027], zone_name, relativize\u003dFalse, port\u003dmaster[\u0027port\u0027], source\u003dsource)\n\nI would prefer ^ over **kwargs - I know there is a large list, but we should not have a huge amount of them.","commit_id":"2b9b5ca75ae1c9f3ab07930a856843ef09d8dbd1"}]}