)]}'
{"designate/pool_manager/service.py":[{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"81b2f3357a7327c0b913db1931f253cdb60aa021","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        return len(self._retrieve_from_cache("},{"line_number":547,"context_line":"            context, domain\u003ddomain, action\u003daction)) \u003e 0"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def _retrieve_from_mdns(self, context, server, domain, action):"},{"line_number":550,"context_line":"        (status, actual_serial, retries) \u003d \\"},{"line_number":551,"context_line":"            self.mdns_api.get_serial_number("},{"line_number":552,"context_line":"                context, domain, server, self.timeout, self.retry_interval,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_cebcd709","line":549,"updated":"2015-02-26 20:12:50.000000000","message":"Just a style nitpick. This function is crazy dense. If there were 4 or 5 blank lines in here, and pool_manager_status was renamed pm_status or something, I think this would be much more readable. Just a suggestion, if there is another PS.","commit_id":"83355d10c87607f19fc62c00d8969bf0353a95a7"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"81b2f3357a7327c0b913db1931f253cdb60aa021","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                pool_manager_status.status \u003d \u0027ERROR\u0027"},{"line_number":558,"context_line":"            elif action \u003d\u003d DELETE_ACTION:"},{"line_number":559,"context_line":"                pool_manager_status.status \u003d \u0027SUCCESS\u0027"},{"line_number":560,"context_line":"            # TODO(Ron): Handle this case properly."},{"line_number":561,"context_line":"            elif action \u003d\u003d UPDATE_ACTION:"},{"line_number":562,"context_line":"                pool_manager_status.status \u003d \u0027ERROR\u0027"},{"line_number":563,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_2e09f3dd","line":560,"updated":"2015-02-26 20:12:50.000000000","message":"Are we handling this case properly now, it seems so to me. \n\nWe\u0027re periodically recovering an update that failed, we see that the update didn\u0027t get there, now we\u0027re going to resend the NOTIFY. Should go from ERROR-\u003eACTIVE when we succesfully poll for the serial, yeah?","commit_id":"83355d10c87607f19fc62c00d8969bf0353a95a7"}]}