)]}'
{"designate/tests/test_central/test_service.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"ae08f5baa6ea2dd2cf23cb51c1b2cb6468624ca2","unresolved":false,"context_lines":[{"line_number":1503,"context_line":"        # Create a record"},{"line_number":1504,"context_line":"        record \u003d self.central_service.create_record("},{"line_number":1505,"context_line":"            self.admin_context, domain[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":1506,"context_line":"            objects.Record.from_dict(values))"},{"line_number":1507,"context_line":""},{"line_number":1508,"context_line":"        # Ensure all values have been set correctly"},{"line_number":1509,"context_line":"        self.assertIsNotNone(record[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_3a0c0994","line":1506,"updated":"2015-02-25 17:22:36.000000000","message":"Obviously, this doesn\u0027t effect the functionality, but is there a reason to move from the vertical style to a more inline format? In reading the diff it is a little easier to notice that only the Record instantiation changed.\n\nNow, if you wanted to be sure we were paying attention, then mission accomplished! \n\nI hope this does not come across as too nit-picky. My goal is partially to test to the waters and understand the coding conventions.","commit_id":"363f3d4f1f1ad60d99c6e96d80dcee39a026211b"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d1c9bae1dea27f71ee2259c1d3dc51c2925dd78c","unresolved":false,"context_lines":[{"line_number":1503,"context_line":"        # Create a record"},{"line_number":1504,"context_line":"        record \u003d self.central_service.create_record("},{"line_number":1505,"context_line":"            self.admin_context, domain[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":1506,"context_line":"            objects.Record.from_dict(values))"},{"line_number":1507,"context_line":""},{"line_number":1508,"context_line":"        # Ensure all values have been set correctly"},{"line_number":1509,"context_line":"        self.assertIsNotNone(record[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_0baf76e4","line":1506,"in_reply_to":"ba7be1f8_3a0c0994","updated":"2015-02-28 13:51:27.000000000","message":"Heya - I totally missed this and the other comments on this revision of the patchset.. So, I don\u0027t think we really have a particular style we enforce, but overall I think we tend to use a mix of all on 1 line (if under 80 chars), or this more than any others.. As I was working through this change, I just went ahead and made these particular sections all consistent with each other :)","commit_id":"363f3d4f1f1ad60d99c6e96d80dcee39a026211b"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"ae08f5baa6ea2dd2cf23cb51c1b2cb6468624ca2","unresolved":false,"context_lines":[{"line_number":2403,"context_line":"            self.assertDictContainsSubset("},{"line_number":2404,"context_line":"                values[\u0027nameservers\u0027][k],"},{"line_number":2405,"context_line":"                pool[\u0027nameservers\u0027][k].to_primitive()[\u0027designate_object.data\u0027])"},{"line_number":2406,"context_line":""},{"line_number":2407,"context_line":"    def test_get_pool(self):"},{"line_number":2408,"context_line":"        # Create a server pool"},{"line_number":2409,"context_line":"        expected \u003d self.create_pool(fixture\u003d0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_fa63513f","line":2406,"updated":"2015-02-25 17:22:36.000000000","message":"+1 Much nicer.","commit_id":"363f3d4f1f1ad60d99c6e96d80dcee39a026211b"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"ae08f5baa6ea2dd2cf23cb51c1b2cb6468624ca2","unresolved":false,"context_lines":[{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"        # Compare the actual values of attributes and nameservers"},{"line_number":2451,"context_line":"        expected_attributes \u003d \\"},{"line_number":2452,"context_line":"            values[\u0027attributes\u0027][0]"},{"line_number":2453,"context_line":"        actual_attributes \u003d \\"},{"line_number":2454,"context_line":"            pools[1][\u0027attributes\u0027][0].to_primitive()[\u0027designate_object.data\u0027]"},{"line_number":2455,"context_line":"        for k in expected_attributes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_5ad45dbc","line":2452,"updated":"2015-02-25 17:22:36.000000000","message":"We could probably skip the explicit line breaks since the values[\u0027attributes\u0027][0] is nice and short.","commit_id":"363f3d4f1f1ad60d99c6e96d80dcee39a026211b"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"7a3b124ddd22df69f66300ea97739703b3cb33bc","unresolved":false,"context_lines":[{"line_number":2517,"context_line":""},{"line_number":2518,"context_line":"        # Compare the actual values of attributes and nameservers"},{"line_number":2519,"context_line":"        expected_attributes \u003d \\"},{"line_number":2520,"context_line":"            values[\u0027attributes\u0027][0]"},{"line_number":2521,"context_line":"        actual_attributes \u003d \\"},{"line_number":2522,"context_line":"            pools[1][\u0027attributes\u0027][0].to_primitive()[\u0027designate_object.data\u0027]"},{"line_number":2523,"context_line":"        for k in expected_attributes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_313ee78c","line":2520,"updated":"2015-02-25 20:14:28.000000000","message":"How about:\n\n  expected_attributes \u003d values[\u0027attributes\u0027][0]\n\nI\u0027m pretty sure we\u0027ll be under 80 chars for pep8 purposes.","commit_id":"6f03a19176711855895c67bc563a2f962d68dbb5"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"349fb52ad31815507447b8ff996eb2047091c72d","unresolved":false,"context_lines":[{"line_number":2517,"context_line":""},{"line_number":2518,"context_line":"        # Compare the actual values of attributes and nameservers"},{"line_number":2519,"context_line":"        expected_attributes \u003d \\"},{"line_number":2520,"context_line":"            values[\u0027attributes\u0027][0]"},{"line_number":2521,"context_line":"        actual_attributes \u003d \\"},{"line_number":2522,"context_line":"            pools[1][\u0027attributes\u0027][0].to_primitive()[\u0027designate_object.data\u0027]"},{"line_number":2523,"context_line":"        for k in expected_attributes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_eb7142a9","line":2520,"in_reply_to":"ba7be1f8_313ee78c","updated":"2015-02-28 13:51:32.000000000","message":"Done","commit_id":"6f03a19176711855895c67bc563a2f962d68dbb5"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"7a3b124ddd22df69f66300ea97739703b3cb33bc","unresolved":false,"context_lines":[{"line_number":2524,"context_line":"            self.assertEqual(actual_attributes[k], expected_attributes[k])"},{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        expected_nameservers \u003d \\"},{"line_number":2527,"context_line":"            values[\u0027nameservers\u0027][0]"},{"line_number":2528,"context_line":"        actual_nameservers \u003d \\"},{"line_number":2529,"context_line":"            pools[1][\u0027nameservers\u0027][0].to_primitive()[\u0027designate_object.data\u0027]"},{"line_number":2530,"context_line":"        for k in expected_nameservers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_51419b09","line":2527,"updated":"2015-02-25 20:14:28.000000000","message":"Same here.","commit_id":"6f03a19176711855895c67bc563a2f962d68dbb5"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"349fb52ad31815507447b8ff996eb2047091c72d","unresolved":false,"context_lines":[{"line_number":2524,"context_line":"            self.assertEqual(actual_attributes[k], expected_attributes[k])"},{"line_number":2525,"context_line":""},{"line_number":2526,"context_line":"        expected_nameservers \u003d \\"},{"line_number":2527,"context_line":"            values[\u0027nameservers\u0027][0]"},{"line_number":2528,"context_line":"        actual_nameservers \u003d \\"},{"line_number":2529,"context_line":"            pools[1][\u0027nameservers\u0027][0].to_primitive()[\u0027designate_object.data\u0027]"},{"line_number":2530,"context_line":"        for k in expected_nameservers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_0b6856b9","line":2527,"in_reply_to":"ba7be1f8_51419b09","updated":"2015-02-28 13:51:32.000000000","message":"Done","commit_id":"6f03a19176711855895c67bc563a2f962d68dbb5"}],"designate/tests/test_storage/__init__.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"ae08f5baa6ea2dd2cf23cb51c1b2cb6468624ca2","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"        result \u003d self.storage.create_record("},{"line_number":1205,"context_line":"            self.admin_context, domain[\u0027id\u0027], recordset[\u0027id\u0027],"},{"line_number":1206,"context_line":"            objects.Record.from_dict(values))"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        self.assertIsNotNone(result[\u0027id\u0027])"},{"line_number":1209,"context_line":"        self.assertIsNotNone(result[\u0027created_at\u0027])"},{"line_number":1210,"context_line":"        self.assertIsNotNone(result[\u0027hash\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_5a47fd76","line":1207,"updated":"2015-02-25 17:22:36.000000000","message":"I\u0027m a +1 for: \n\n  result \u003d self.storage.create_record(\n      self.admin_context, \n      domain[\u0027id\u0027],\n      recordset[\u0027id\u0027],\n      record\u003dobjects.Record.from_dict(values)\n  )\n\nThe break after the paren is better, but it makes sense to keep the args on different lines as well.","commit_id":"363f3d4f1f1ad60d99c6e96d80dcee39a026211b"}]}