)]}'
{"designate/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"08904166bb6cf79a9cb0e040274de0ecc2e47ddf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        LOG.info(_(\u0027Stopping %(name)s service\u0027) % {\u0027name\u0027: self.service_name})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        super(Service, self).stop()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class RPCService(object):"},{"line_number":97,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_c00c4d45","line":94,"updated":"2015-03-05 17:41:50.000000000","message":"Does Service need a wait method?","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b18bbe0d536cf9327f9cb0be6e1de6ced4fd266c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        LOG.info(_(\u0027Stopping %(name)s service\u0027) % {\u0027name\u0027: self.service_name})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        super(Service, self).stop()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class RPCService(object):"},{"line_number":97,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_f4f10fce","line":94,"in_reply_to":"9a80dd14_c00c4d45","updated":"2015-03-05 18:19:27.000000000","message":"No, It get\u0027s that from the openstack common Service class, and we don\u0027t need to log anything at that point so skip it.","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"08904166bb6cf79a9cb0e040274de0ecc2e47ddf","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def _rpc_topic(self):"},{"line_number":114,"context_line":"        return self.service_name"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def start(self):"},{"line_number":117,"context_line":"        super(RPCService, self).start()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        LOG.debug(_(\"Starting RPC server on topic \u0027%s\u0027\") % self._rpc_topic)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_20a60954","line":116,"updated":"2015-03-05 17:41:50.000000000","message":"Do you need a call to super here now?","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b18bbe0d536cf9327f9cb0be6e1de6ced4fd266c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def _rpc_topic(self):"},{"line_number":114,"context_line":"        return self.service_name"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def start(self):"},{"line_number":117,"context_line":"        super(RPCService, self).start()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        LOG.debug(_(\"Starting RPC server on topic \u0027%s\u0027\") % self._rpc_topic)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b495d741","line":116,"in_reply_to":"9a80dd14_20a60954","updated":"2015-03-05 18:19:27.000000000","message":"Yes, since this get\u0027s mixed into the Service class, we need to make sure all the various start/stops are called.","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"08904166bb6cf79a9cb0e040274de0ecc2e47ddf","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            self._rpc_server.stop()"},{"line_number":139,"context_line":"        except Exception:"},{"line_number":140,"context_line":"            pass"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        super(RPCService, self).stop()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def wait(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_806ed5ff","line":141,"updated":"2015-03-05 17:41:50.000000000","message":"Do you need a call to super here now?","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b18bbe0d536cf9327f9cb0be6e1de6ced4fd266c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            self._rpc_server.stop()"},{"line_number":139,"context_line":"        except Exception:"},{"line_number":140,"context_line":"            pass"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        super(RPCService, self).stop()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def wait(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_f49f4f5d","line":141,"in_reply_to":"9a80dd14_806ed5ff","updated":"2015-03-05 18:19:27.000000000","message":"As above :)","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"08904166bb6cf79a9cb0e040274de0ecc2e47ddf","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            if e !\u003d self and hasattr(e, \u0027wait\u0027):"},{"line_number":147,"context_line":"                e.wait()"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        super(RPCService, self).wait()"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_c077edd2","line":149,"updated":"2015-03-05 17:41:50.000000000","message":"Do you need a call to super here now?","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b18bbe0d536cf9327f9cb0be6e1de6ced4fd266c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            if e !\u003d self and hasattr(e, \u0027wait\u0027):"},{"line_number":147,"context_line":"                e.wait()"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        super(RPCService, self).wait()"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_149b0373","line":149,"in_reply_to":"9a80dd14_c077edd2","updated":"2015-03-05 18:19:27.000000000","message":"As above :)","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"08904166bb6cf79a9cb0e040274de0ecc2e47ddf","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    def _dns_application(self):"},{"line_number":243,"context_line":"        pass"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def start(self):"},{"line_number":246,"context_line":"        super(DNSService, self).start()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.tg.add_thread("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_43006701","line":245,"updated":"2015-03-05 17:41:50.000000000","message":"Do you need a call to super here now?","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b18bbe0d536cf9327f9cb0be6e1de6ced4fd266c","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    def _dns_application(self):"},{"line_number":243,"context_line":"        pass"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def start(self):"},{"line_number":246,"context_line":"        super(DNSService, self).start()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.tg.add_thread("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_94861312","line":245,"in_reply_to":"9a80dd14_43006701","updated":"2015-03-05 18:19:27.000000000","message":"As above :)","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"08904166bb6cf79a9cb0e040274de0ecc2e47ddf","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            dnsutils.handle_udp, self._dns_sock_udp, self.tg, dnsutils.handle,"},{"line_number":254,"context_line":"            self._dns_application)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def wait(self):"},{"line_number":257,"context_line":"        super(DNSService, self).wait()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def stop(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_830a5f1f","line":256,"updated":"2015-03-05 17:41:50.000000000","message":"Do you need a call to super here now?","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b18bbe0d536cf9327f9cb0be6e1de6ced4fd266c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            dnsutils.handle_udp, self._dns_sock_udp, self.tg, dnsutils.handle,"},{"line_number":254,"context_line":"            self._dns_application)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def wait(self):"},{"line_number":257,"context_line":"        super(DNSService, self).wait()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def stop(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b47cf721","line":256,"in_reply_to":"9a80dd14_830a5f1f","updated":"2015-03-05 18:19:27.000000000","message":"As above :)","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"08904166bb6cf79a9cb0e040274de0ecc2e47ddf","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def stop(self):"},{"line_number":260,"context_line":"        # When the service is stopped, the threads for _handle_tcp and"},{"line_number":261,"context_line":"        # _handle_udp are stopped too."},{"line_number":262,"context_line":"        super(DNSService, self).stop()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_2319b379","line":261,"updated":"2015-03-05 17:41:50.000000000","message":"Do you need a call to super here now?","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b18bbe0d536cf9327f9cb0be6e1de6ced4fd266c","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def stop(self):"},{"line_number":260,"context_line":"        # When the service is stopped, the threads for _handle_tcp and"},{"line_number":261,"context_line":"        # _handle_udp are stopped too."},{"line_number":262,"context_line":"        super(DNSService, self).stop()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_d477ab39","line":261,"in_reply_to":"9a80dd14_2319b379","updated":"2015-03-05 18:19:27.000000000","message":"As above :)","commit_id":"deb65468e916317e913f0a86a647a597a9f2d0bf"}]}