)]}'
{"contrib/devstack/lib/designate":[{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"dff419b9b895a393fa9431afb46f198084ce43ad","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    # Override the logging_context_format_string value chosen by"},{"line_number":78,"context_line":"    # setup_colorized_logging."},{"line_number":79,"context_line":"    iniset $conf_file $conf_section logging_context_format_string \"%(asctime)s.%(msecs)03d %(color)s%(levelname)s %(name)s [\u001b[01;36m%(request_id)s \u001b[00;36m%(user_identity)s%(color)s] \u001b[01;35m%(instance)s%(color)s%(message)s\u001b[00m\""},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# DevStack Plugin"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a80dd14_c8da5d4a","line":79,"updated":"2015-03-13 21:23:36.000000000","message":"Are these things \"01;36m\" in here by mistake?","commit_id":"e6b2b12e450d499838e901d4edfe5d9cc7fb4d6d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"fc0e6fb2e725ad9c3f460a7fab0715761548e94b","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    # Override the logging_context_format_string value chosen by"},{"line_number":78,"context_line":"    # setup_colorized_logging."},{"line_number":79,"context_line":"    iniset $conf_file $conf_section logging_context_format_string \"%(asctime)s.%(msecs)03d %(color)s%(levelname)s %(name)s [\u001b[01;36m%(request_id)s \u001b[00;36m%(user_identity)s%(color)s] \u001b[01;35m%(instance)s%(color)s%(message)s\u001b[00m\""},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# DevStack Plugin"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a80dd14_929875c1","line":79,"in_reply_to":"9a80dd14_c8da5d4a","updated":"2015-03-14 11:55:49.000000000","message":"Nope, that\u0027s how the coloring is done..","commit_id":"e6b2b12e450d499838e901d4edfe5d9cc7fb4d6d"}],"designate/mdns/handler.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"cbe2d92d94f1f6a85ce705ecd05127cbd8b7241e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if tsigkey is None:"},{"line_number":90,"context_line":"            # Default to using the default_pool_id when no TSIG key is"},{"line_number":91,"context_line":"            # available"},{"line_number":92,"context_line":"            criterion[\u0027pool_id\u0027] \u003d CONF[\u0027service:central\u0027].default_pool_id"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            if tsigkey.scope \u003d\u003d \u0027POOL\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_c6233056","line":92,"updated":"2015-03-03 17:31:24.000000000","message":"while we should allow people to run the single pool without TSIG, we should make it a config option, and allow people require TSIG keys for all requests to miniDNS","commit_id":"a6dfb134b7a54db6ff835b5f3b5f758c7d29f5d6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"55342ecae705faf9467aaa3162cfb6e7266b62e9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if tsigkey is None:"},{"line_number":90,"context_line":"            # Default to using the default_pool_id when no TSIG key is"},{"line_number":91,"context_line":"            # available"},{"line_number":92,"context_line":"            criterion[\u0027pool_id\u0027] \u003d CONF[\u0027service:central\u0027].default_pool_id"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            if tsigkey.scope \u003d\u003d \u0027POOL\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_e879eb2f","line":92,"in_reply_to":"9a80dd14_3c50570a","updated":"2015-03-13 12:43:34.000000000","message":"Done","commit_id":"a6dfb134b7a54db6ff835b5f3b5f758c7d29f5d6"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d8ab9fe5903757fb3853b72418a7f3b98cfba206","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if tsigkey is None:"},{"line_number":90,"context_line":"            # Default to using the default_pool_id when no TSIG key is"},{"line_number":91,"context_line":"            # available"},{"line_number":92,"context_line":"            criterion[\u0027pool_id\u0027] \u003d CONF[\u0027service:central\u0027].default_pool_id"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            if tsigkey.scope \u003d\u003d \u0027POOL\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_3c50570a","line":92,"in_reply_to":"ba7be1f8_552e008d","updated":"2015-03-10 10:27:30.000000000","message":"I think this should be a fairly quick change - I would like to see it in before this patch merges","commit_id":"a6dfb134b7a54db6ff835b5f3b5f758c7d29f5d6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a1a34ca3ac88ddda0c883a319b82d70b0684aed0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if tsigkey is None:"},{"line_number":90,"context_line":"            # Default to using the default_pool_id when no TSIG key is"},{"line_number":91,"context_line":"            # available"},{"line_number":92,"context_line":"            criterion[\u0027pool_id\u0027] \u003d CONF[\u0027service:central\u0027].default_pool_id"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            if tsigkey.scope \u003d\u003d \u0027POOL\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_552e008d","line":92,"in_reply_to":"ba7be1f8_c6233056","updated":"2015-03-03 18:06:28.000000000","message":"Agreed, Rather than extend this patchset again, let\u0027s add that option after we merge the core functionality.","commit_id":"a6dfb134b7a54db6ff835b5f3b5f758c7d29f5d6"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"cbe2d92d94f1f6a85ce705ecd05127cbd8b7241e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                domain \u003d self.storage.find_domain(context, criterion)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            except exceptions.DomainNotFound:"},{"line_number":207,"context_line":"                LOG.exception(_LE(\"got exception while handling axfr request. \""},{"line_number":208,"context_line":"                                  \"Question is %(qr)s\") % {\u0027qr\u0027: q_rrset})"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"                return self._handle_query_error(request, dns.rcode.REFUSED)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_e6ad949c","line":207,"updated":"2015-03-03 17:31:24.000000000","message":"this is not a AFXR request","commit_id":"a6dfb134b7a54db6ff835b5f3b5f758c7d29f5d6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"55342ecae705faf9467aaa3162cfb6e7266b62e9","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                domain \u003d self.storage.find_domain(context, criterion)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            except exceptions.DomainNotFound:"},{"line_number":207,"context_line":"                LOG.exception(_LE(\"got exception while handling axfr request. \""},{"line_number":208,"context_line":"                                  \"Question is %(qr)s\") % {\u0027qr\u0027: q_rrset})"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"                return self._handle_query_error(request, dns.rcode.REFUSED)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_6895fb31","line":207,"in_reply_to":"ba7be1f8_b50c9ced","updated":"2015-03-13 12:43:34.000000000","message":"Done","commit_id":"a6dfb134b7a54db6ff835b5f3b5f758c7d29f5d6"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"a1a34ca3ac88ddda0c883a319b82d70b0684aed0","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                domain \u003d self.storage.find_domain(context, criterion)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            except exceptions.DomainNotFound:"},{"line_number":207,"context_line":"                LOG.exception(_LE(\"got exception while handling axfr request. \""},{"line_number":208,"context_line":"                                  \"Question is %(qr)s\") % {\u0027qr\u0027: q_rrset})"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"                return self._handle_query_error(request, dns.rcode.REFUSED)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_b50c9ced","line":207,"in_reply_to":"ba7be1f8_e6ad949c","updated":"2015-03-03 18:06:28.000000000","message":"Nice catch, will fix that up..","commit_id":"a6dfb134b7a54db6ff835b5f3b5f758c7d29f5d6"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"dff419b9b895a393fa9431afb46f198084ce43ad","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                LOG.exception(_LE(\"Forbidden while handling query request. \""},{"line_number":221,"context_line":"                                  \"Question was %(qr)s\") % {\u0027qr\u0027: q_rrset})"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            r_rrset \u003d self._convert_to_rrset(domain, recordset)"},{"line_number":224,"context_line":"            response.set_rcode(dns.rcode.NOERROR)"},{"line_number":225,"context_line":"            response.answer \u003d [r_rrset]"},{"line_number":226,"context_line":"            # For all the data stored in designate mdns is Authoritative"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_d395a140","line":223,"updated":"2015-03-13 21:23:36.000000000","message":"If the request isn\u0027t TSIG signed, and you\u0027re enforcing that, you can get a \n\nlocal variable \u0027domain\u0027 referenced before assignment\n\nHere because L211 was never executed.","commit_id":"e6b2b12e450d499838e901d4edfe5d9cc7fb4d6d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"fc0e6fb2e725ad9c3f460a7fab0715761548e94b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                LOG.exception(_LE(\"Forbidden while handling query request. \""},{"line_number":221,"context_line":"                                  \"Question was %(qr)s\") % {\u0027qr\u0027: q_rrset})"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            r_rrset \u003d self._convert_to_rrset(domain, recordset)"},{"line_number":224,"context_line":"            response.set_rcode(dns.rcode.NOERROR)"},{"line_number":225,"context_line":"            response.answer \u003d [r_rrset]"},{"line_number":226,"context_line":"            # For all the data stored in designate mdns is Authoritative"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_b293b9a1","line":223,"in_reply_to":"9a80dd14_d395a140","updated":"2015-03-14 11:55:49.000000000","message":"Oh nice spot, I must have cut the return self._handle_query_error(request, dns.rcode.REFUSED) line from the Forbidden exc handler.","commit_id":"e6b2b12e450d499838e901d4edfe5d9cc7fb4d6d"}]}