)]}'
{"designate/objects/adapters/base.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b55e7d761aa6f7767adbf833ca5f286e7cd0bfdd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # Loop over all fields that are supposed to be output"},{"line_number":92,"context_line":"        for key, value in cls.MODIFICATIONS[\u0027fields\u0027].iteritems():"},{"line_number":93,"context_line":"            # Get properties for this field"},{"line_number":94,"context_line":"            field_props \u003d cls.MODIFICATIONS[\u0027fields\u0027][key]"},{"line_number":95,"context_line":"            # Check if it has to be renamed"},{"line_number":96,"context_line":"            if field_props.get(\u0027rename\u0027, False):"},{"line_number":97,"context_line":"                obj \u003d getattr(object, field_props.get(\u0027rename\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_360946de","line":94,"updated":"2015-03-10 19:08:02.000000000","message":"Nit: No need to get these, the \"value\" prop already has the same contents","commit_id":"f7252ecdb0bd650aab5485fb1a2e22e0c00a400d"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"c6cc3ced4587968bffbfa3f661deb3500852ef79","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # Loop over all fields that are supposed to be output"},{"line_number":92,"context_line":"        for key, value in cls.MODIFICATIONS[\u0027fields\u0027].iteritems():"},{"line_number":93,"context_line":"            # Get properties for this field"},{"line_number":94,"context_line":"            field_props \u003d cls.MODIFICATIONS[\u0027fields\u0027][key]"},{"line_number":95,"context_line":"            # Check if it has to be renamed"},{"line_number":96,"context_line":"            if field_props.get(\u0027rename\u0027, False):"},{"line_number":97,"context_line":"                obj \u003d getattr(object, field_props.get(\u0027rename\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_3cbafb0a","line":94,"in_reply_to":"9a80dd14_360946de","updated":"2015-03-10 19:15:29.000000000","message":"yup - so it would","commit_id":"f7252ecdb0bd650aab5485fb1a2e22e0c00a400d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b55e7d761aa6f7767adbf833ca5f286e7cd0bfdd","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    object.FIELDS[obj_key].get(\u0027relation_cls\u0027)).render("},{"line_number":113,"context_line":"                        obj, *args, **kwargs)"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                # Just attach the damn item if there is no weird edge cases"},{"line_number":116,"context_line":"                r_obj[key] \u003d obj"},{"line_number":117,"context_line":"        # Send it back"},{"line_number":118,"context_line":"        return r_obj"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_16d28234","line":115,"updated":"2015-03-10 19:08:02.000000000","message":"lol... frustrated much? ;)","commit_id":"f7252ecdb0bd650aab5485fb1a2e22e0c00a400d"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"c6cc3ced4587968bffbfa3f661deb3500852ef79","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    object.FIELDS[obj_key].get(\u0027relation_cls\u0027)).render("},{"line_number":113,"context_line":"                        obj, *args, **kwargs)"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                # Just attach the damn item if there is no weird edge cases"},{"line_number":116,"context_line":"                r_obj[key] \u003d obj"},{"line_number":117,"context_line":"        # Send it back"},{"line_number":118,"context_line":"        return r_obj"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_5c2b2f33","line":115,"in_reply_to":"9a80dd14_16d28234","updated":"2015-03-10 19:15:29.000000000","message":"slightly ;)","commit_id":"f7252ecdb0bd650aab5485fb1a2e22e0c00a400d"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b55e7d761aa6f7767adbf833ca5f286e7cd0bfdd","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            if key in cls.MODIFICATIONS[\u0027fields\u0027]:"},{"line_number":159,"context_line":"                # No rename needed"},{"line_number":160,"context_line":"                obj_key \u003d key"},{"line_number":161,"context_line":"                error_flag \u003d False"},{"line_number":162,"context_line":"                # This item may need to be translated"},{"line_number":163,"context_line":"                if cls.MODIFICATIONS[\u0027fields\u0027][key].get(\u0027rename\u0027, False):"},{"line_number":164,"context_line":"                    obj_key \u003d cls.MODIFICATIONS[\u0027fields\u0027][key].get(\u0027rename\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_9c7a1124","line":161,"updated":"2015-03-10 19:08:02.000000000","message":"Nit: Any reason not to turn the error_flag into a simple if/else?","commit_id":"f7252ecdb0bd650aab5485fb1a2e22e0c00a400d"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"c6cc3ced4587968bffbfa3f661deb3500852ef79","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            if key in cls.MODIFICATIONS[\u0027fields\u0027]:"},{"line_number":159,"context_line":"                # No rename needed"},{"line_number":160,"context_line":"                obj_key \u003d key"},{"line_number":161,"context_line":"                error_flag \u003d False"},{"line_number":162,"context_line":"                # This item may need to be translated"},{"line_number":163,"context_line":"                if cls.MODIFICATIONS[\u0027fields\u0027][key].get(\u0027rename\u0027, False):"},{"line_number":164,"context_line":"                    obj_key \u003d cls.MODIFICATIONS[\u0027fields\u0027][key].get(\u0027rename\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_7cd47347","line":161,"in_reply_to":"9a80dd14_9c7a1124","updated":"2015-03-10 19:15:29.000000000","message":"nope - there was 2 or 3 checks at one point, which is why it was a flag, but if could go to a loop","commit_id":"f7252ecdb0bd650aab5485fb1a2e22e0c00a400d"}],"designate/tests/test_objects/test_adapters.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"b55e7d761aa6f7767adbf833ca5f286e7cd0bfdd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            \u0027TEST_API\u0027, objects.DesignateObject)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_get_object_render(self):"},{"line_number":59,"context_line":"        adapters.DesignateAdapter.render(\u0027TEST_API\u0027, objects.DesignateObject)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_33edd38f","line":59,"updated":"2015-03-10 19:08:02.000000000","message":"Can we add a couple more tests for things like the rename, extra fields, removed/hidden fields etc? Probably easier in a follow up patchset due to the dependent patchsets...","commit_id":"f7252ecdb0bd650aab5485fb1a2e22e0c00a400d"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"c6cc3ced4587968bffbfa3f661deb3500852ef79","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            \u0027TEST_API\u0027, objects.DesignateObject)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_get_object_render(self):"},{"line_number":59,"context_line":"        adapters.DesignateAdapter.render(\u0027TEST_API\u0027, objects.DesignateObject)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_7c62b3ae","line":59,"in_reply_to":"9a80dd14_33edd38f","updated":"2015-03-10 19:15:29.000000000","message":"yeah, there is a ton of tests to go in. I will add them on as we progress","commit_id":"f7252ecdb0bd650aab5485fb1a2e22e0c00a400d"}]}