)]}'
{"designate/objects/adapters/api_v1/domain.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cbf92ea6620c36aa5661d55bd933b9a1e890a02d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            \"id\": {},"},{"line_number":28,"context_line":"            \"tenant_id\": {},"},{"line_number":29,"context_line":"            \"name\": {"},{"line_number":30,"context_line":"                \u0027idempotent\u0027: True,"},{"line_number":31,"context_line":"            },"},{"line_number":32,"context_line":"            \"email\": {},"},{"line_number":33,"context_line":"            \"description\": {},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_37fb36c2","line":30,"updated":"2015-03-14 20:52:33.000000000","message":"Shouldn\u0027t this be immutable? idempotent describes something that can be done over+over without changing the result, rather than immutable - \"unchanging over time or unable to be changed.\" (Yea, I had to copy+paste the definition since my explanation was awful ;))","commit_id":"1dc866f509e5042fa709fef6dab3c4d578d6da2b"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"ee76be9153fb527a229aa4cb4384210cca7d1711","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            \"id\": {},"},{"line_number":28,"context_line":"            \"tenant_id\": {},"},{"line_number":29,"context_line":"            \"name\": {"},{"line_number":30,"context_line":"                \u0027idempotent\u0027: True,"},{"line_number":31,"context_line":"            },"},{"line_number":32,"context_line":"            \"email\": {},"},{"line_number":33,"context_line":"            \"description\": {},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_d3f9ee80","line":30,"in_reply_to":"9a80dd14_37fb36c2","updated":"2015-03-16 13:21:15.000000000","message":"Yup - idempotent is not even implemented - i guess I was not thinking straight","commit_id":"1dc866f509e5042fa709fef6dab3c4d578d6da2b"}],"designate/objects/adapters/api_v1/record.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cbf92ea6620c36aa5661d55bd933b9a1e890a02d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                \u0027idempotent\u0027: True,"},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"            \"data\": {"},{"line_number":32,"context_line":"                \u0027read_only\u0027: False"},{"line_number":33,"context_line":"            },"},{"line_number":34,"context_line":"            \"priority\": {"},{"line_number":35,"context_line":"                \u0027read_only\u0027: False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1728f231","line":32,"updated":"2015-03-14 20:52:33.000000000","message":"Is there a reason we need all these read_only\u003dFalse, while the various Domain properties don\u0027t? and  - isn\u0027t ready only implemented on the object itself.","commit_id":"1dc866f509e5042fa709fef6dab3c4d578d6da2b"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"ee76be9153fb527a229aa4cb4384210cca7d1711","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                \u0027idempotent\u0027: True,"},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"            \"data\": {"},{"line_number":32,"context_line":"                \u0027read_only\u0027: False"},{"line_number":33,"context_line":"            },"},{"line_number":34,"context_line":"            \"priority\": {"},{"line_number":35,"context_line":"                \u0027read_only\u0027: False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_33bdeab1","line":32,"in_reply_to":"9a80dd14_1728f231","updated":"2015-03-16 13:21:15.000000000","message":"read_only isn\u0027t in the objects yet (need to implement more stuff for read_only etc in the object.validate() )","commit_id":"1dc866f509e5042fa709fef6dab3c4d578d6da2b"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"cbf92ea6620c36aa5661d55bd933b9a1e890a02d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            },"},{"line_number":43,"context_line":"            \"domain_id\": {},"},{"line_number":44,"context_line":"            \"created_at\": {},"},{"line_number":45,"context_line":"            \"updated_at\": {},"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"        \u0027options\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_37225652","line":45,"updated":"2015-03-14 20:52:33.000000000","message":"Assuming RO is implemented in Adaptors, shouldn\u0027t these be read_only\u003dTrue?","commit_id":"1dc866f509e5042fa709fef6dab3c4d578d6da2b"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"ee76be9153fb527a229aa4cb4384210cca7d1711","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            },"},{"line_number":43,"context_line":"            \"domain_id\": {},"},{"line_number":44,"context_line":"            \"created_at\": {},"},{"line_number":45,"context_line":"            \"updated_at\": {},"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"        \u0027options\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b3e8fab3","line":45,"in_reply_to":"9a80dd14_37225652","updated":"2015-03-16 13:21:15.000000000","message":"read_only defaults to True","commit_id":"1dc866f509e5042fa709fef6dab3c4d578d6da2b"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"2b4e6f91f61c814d9cba40305412aefc68134e8b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \u0027fields\u0027: {"},{"line_number":27,"context_line":"            \"id\": {},"},{"line_number":28,"context_line":"            \"name\": {"},{"line_number":29,"context_line":"                \u0027idempotent\u0027: True,"},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"            \"data\": {"},{"line_number":32,"context_line":"                \u0027read_only\u0027: False"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_5ab3dde8","line":29,"updated":"2015-03-18 12:44:54.000000000","message":"This should be immutable, right?","commit_id":"eb14853cb325788cdedcea2142f2698b9f95808f"}],"designate/objects/adapters/api_v1/recordset.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"2b4e6f91f61c814d9cba40305412aefc68134e8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                \u0027idempotent\u0027: True,"},{"line_number":29,"context_line":"            },"},{"line_number":30,"context_line":"            \"type\": {"},{"line_number":31,"context_line":"                \u0027idempotent\u0027: True,"},{"line_number":32,"context_line":"            },"},{"line_number":33,"context_line":"            \"priority\": {"},{"line_number":34,"context_line":"                \u0027read_only\u0027: False"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_fadc911a","line":31,"updated":"2015-03-18 12:44:54.000000000","message":"These should be immutable, right?","commit_id":"eb14853cb325788cdedcea2142f2698b9f95808f"}]}