)]}'
{"designate/api/v1/domains.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f2504c3dbfb322185aa6bd753b4a6a6b32c6949c","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    domain \u003d central_api.create_zone(context, objects.Zone(**values))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    LOG.info(_LI(\"Created %(zone)s\") % {\u0027zone\u0027: domain})"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    response \u003d flask.jsonify(domain_schema.filter(domain))"},{"line_number":74,"context_line":"    response.status_int \u003d 201"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_f951e163","line":71,"updated":"2016-03-21 21:19:34.000000000","message":"So, we should probably get in the habit of using the logging module\u0027s string interpolation. Old habits die hard, but I think over time, it is a good habit to let die! \n\ns/%/,","commit_id":"2b83c9ea813d15366cf196b6278ec80485cf3bd5"}],"designate/api/v1/records.py":[{"author":{"_account_id":16962,"name":"Federico Ceratto","email":"federico.ceratto@gmail.com","username":"ceratto"},"change_message_id":"cd83d23ff657af79550d9a8c0bb0fbd318cfdfd7","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    records \u003d central_api.find_records(context, {\u0027domain_id\u0027: domain_id})"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    LOG.info(_LI(\"Retrieved %(records)s\") % {\u0027records\u0027: records})"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    recordsets \u003d _fetch_domain_recordsets(context, domain_id)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_7324e00d","line":162,"updated":"2015-09-28 18:21:11.000000000","message":"Maybe all the calls to LOG for \"get\" events where nothing is being changed should be of debug level rather than info?","commit_id":"1fef96f8d1ab128a5f9eae139d7a4bd9d27dbc47"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f2504c3dbfb322185aa6bd753b4a6a6b32c6949c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    # Make sure it\u0027s the right recordset"},{"line_number":246,"context_line":"    if len(recordset.records) \u003d\u003d 0:"},{"line_number":247,"context_line":"        recordset \u003d central_api.delete_recordset("},{"line_number":248,"context_line":"            context, domain_id, recordset_id)"},{"line_number":249,"context_line":"        LOG.info(_LI(\"Deleted %(recordset)s\") % {\u0027recordset\u0027: recordset})"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_59fd6d39","line":248,"updated":"2016-03-21 21:19:34.000000000","message":"Might want to go ahead and move this back to one line just in case we backport this change. I\u0027d imagine this would be helpful for older releases as well.","commit_id":"2b83c9ea813d15366cf196b6278ec80485cf3bd5"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f2504c3dbfb322185aa6bd753b4a6a6b32c6949c","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    # Cannot delete a managed record via the API."},{"line_number":269,"context_line":"    if record[\u0027managed\u0027] is True:"},{"line_number":270,"context_line":"        raise exceptions.BadRequest(\u0027Managed records may not be deleted\u0027)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    record \u003d central_api.delete_record("},{"line_number":273,"context_line":"        context, domain_id, record[\u0027recordset_id\u0027], record_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_59944de1","line":270,"updated":"2016-03-21 21:19:34.000000000","message":"Should this happen in another patch?","commit_id":"2b83c9ea813d15366cf196b6278ec80485cf3bd5"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"2ed60609f03d710250e46a61489eee908f7205c5","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    # Cannot delete a managed record via the API."},{"line_number":269,"context_line":"    if record[\u0027managed\u0027] is True:"},{"line_number":270,"context_line":"        raise exceptions.BadRequest(\u0027Managed records may not be deleted\u0027)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    record \u003d central_api.delete_record("},{"line_number":273,"context_line":"        context, domain_id, record[\u0027recordset_id\u0027], record_id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a061dce_fbdafe49","line":270,"updated":"2016-04-06 22:17:41.000000000","message":"This bit should go in a separate change. Although, it\u0027s v1 so I don\u0027t mind.","commit_id":"6832fa14c91bd5c6077da3052aff7b1da4bf0664"}],"designate/api/v2/controllers/blacklists.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f2504c3dbfb322185aa6bd753b4a6a6b32c6949c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        request \u003d pecan.request"},{"line_number":39,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        blacklist \u003d self.central_api.get_blacklist(context, blacklist_id)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        LOG.info(_LI(\"Retrieved %(blacklist)s\") % {\u0027blacklist\u0027: blacklist})"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_796831f6","line":41,"updated":"2016-03-21 21:19:34.000000000","message":"Just want to +1 this. It looks much nicer than that semi-hidden function call!","commit_id":"2b83c9ea813d15366cf196b6278ec80485cf3bd5"}],"designate/api/v2/controllers/pools.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f2504c3dbfb322185aa6bd753b4a6a6b32c6949c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        response.status_int \u003d 201"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        response.headers[\u0027Location\u0027] \u003d pool[\u0027links\u0027][\u0027self\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Prepare and return the response body"},{"line_number":89,"context_line":"        return pool"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_3956b929","line":87,"updated":"2016-03-21 21:19:34.000000000","message":"If I didn\u0027t agree with this whitespace change I\u0027d say remove it ;)","commit_id":"2b83c9ea813d15366cf196b6278ec80485cf3bd5"}],"designate/api/v2/controllers/recordsets.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"f2504c3dbfb322185aa6bd753b4a6a6b32c6949c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        context \u003d request.environ[\u0027context\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        recordset \u003d self.central_api.get_recordset(context, zone_id,"},{"line_number":42,"context_line":"                                                   recordset_id)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        LOG.info(_LI(\"Retrieved %(recordset)s\") % {\u0027recordset\u0027: recordset})"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_791dd172","line":42,"updated":"2016-03-21 21:19:34.000000000","message":"This is a nit, but the format I see more often in our code has been to go ahead and move all the args to another line. I\u0027d say do that here as well as it is less of a problem for more editors. You know, like vim and sublimetext. #trollololol","commit_id":"2b83c9ea813d15366cf196b6278ec80485cf3bd5"}]}