)]}'
{"designate/backend/base.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c496caeded28c7b7b8ca012e3f76c9163a552f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                    cfg.IntOpt(\u0027port\u0027),"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"                    cfg.ListOpt(\u0027masters\u0027, default\u003d[]),"},{"line_number":92,"context_line":"                    cfg.DictOpt(\u0027options\u0027, default\u003d[]),"},{"line_number":93,"context_line":"                ])"},{"line_number":94,"context_line":"            )"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_64e1b1fd","line":92,"updated":"2015-03-25 21:06:01.000000000","message":"[] !\u003d dict","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"27cf74df2e3e414f2a97e2828d23aefc18bdad39","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                    cfg.IntOpt(\u0027port\u0027),"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"                    cfg.ListOpt(\u0027masters\u0027, default\u003d[]),"},{"line_number":92,"context_line":"                    cfg.DictOpt(\u0027options\u0027, default\u003d[]),"},{"line_number":93,"context_line":"                ])"},{"line_number":94,"context_line":"            )"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_028b8d1f","line":92,"in_reply_to":"1a6ced46_64e1b1fd","updated":"2015-03-26 16:07:01.000000000","message":"Done","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"}],"designate/manage/powerdns.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"49c8acbb27f201a74c5b9a496f2f7a592eb742dc","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class DatabaseCommands(base.Commands):"},{"line_number":43,"context_line":"    @base.args(\u0027--connection\u0027, help\u003d\"Database Connection String\","},{"line_number":44,"context_line":"               default\u003dNone, required\u003dTrue, type\u003dstr)"},{"line_number":45,"context_line":"    def version(self, connection):"},{"line_number":46,"context_line":"        current \u003d get_manager(connection).version()"}],"source_content_type":"text/x-python","patch_set":11,"id":"da9b358b_66e748e5","line":43,"updated":"2015-03-30 12:05:22.000000000","message":"would the target id not be better here?","commit_id":"817114e1556704cc00ea60fcf934b90ae9bbd811"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"2f8770815271b6d402811ebb2e247b6c8a9b8eb4","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class DatabaseCommands(base.Commands):"},{"line_number":43,"context_line":"    @base.args(\u0027--connection\u0027, help\u003d\"Database Connection String\","},{"line_number":44,"context_line":"               default\u003dNone, required\u003dTrue, type\u003dstr)"},{"line_number":45,"context_line":"    def version(self, connection):"},{"line_number":46,"context_line":"        current \u003d get_manager(connection).version()"}],"source_content_type":"text/x-python","patch_set":11,"id":"da9b358b_7aed8b8a","line":43,"in_reply_to":"da9b358b_66e748e5","updated":"2015-03-30 18:41:53.000000000","message":"Done","commit_id":"817114e1556704cc00ea60fcf934b90ae9bbd811"}],"designate/pool_manager/service.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c496caeded28c7b7b8ca012e3f76c9163a552f","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                # TODO(kiall): If the domain was created within the last"},{"line_number":216,"context_line":"                #              periodic_sync_seconds, attempt to recreate to"},{"line_number":217,"context_line":"                #              fill in targets which may have failed."},{"line_number":218,"context_line":"                self.update_domain(context, domain)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        except Exception:"},{"line_number":221,"context_line":"            LOG.exception(_LE(\u0027An unhandled exception in periodic \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_67a3734f","line":218,"updated":"2015-03-25 21:06:01.000000000","message":"we need to address post create fails - this current implementation fails to try to re-create on the failed targets","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"522748d98c5205aed46db027a5d305c480adb6a7","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                # TODO(kiall): If the domain was created within the last"},{"line_number":216,"context_line":"                #              periodic_sync_seconds, attempt to recreate to"},{"line_number":217,"context_line":"                #              fill in targets which may have failed."},{"line_number":218,"context_line":"                self.update_domain(context, domain)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        except Exception:"},{"line_number":221,"context_line":"            LOG.exception(_LE(\u0027An unhandled exception in periodic \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_aa6521e2","line":218,"in_reply_to":"1a6ced46_67a3734f","updated":"2015-03-26 21:25:32.000000000","message":"Done","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c496caeded28c7b7b8ca012e3f76c9163a552f","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        results \u003d []"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        # Create the domain on each of the Pool Targets"},{"line_number":291,"context_line":"        for target in self.pool.targets:"},{"line_number":292,"context_line":"            results.append("},{"line_number":293,"context_line":"                self._update_domain_on_target(context, target, domain))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_07855f59","line":290,"updated":"2015-03-25 21:06:01.000000000","message":"s/create/update/","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"27cf74df2e3e414f2a97e2828d23aefc18bdad39","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        results \u003d []"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        # Create the domain on each of the Pool Targets"},{"line_number":291,"context_line":"        for target in self.pool.targets:"},{"line_number":292,"context_line":"            results.append("},{"line_number":293,"context_line":"                self._update_domain_on_target(context, target, domain))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_827e9d17","line":290,"in_reply_to":"1a6ced46_07855f59","updated":"2015-03-26 16:07:01.000000000","message":"Done","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c496caeded28c7b7b8ca012e3f76c9163a552f","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            results.append("},{"line_number":293,"context_line":"                self._update_domain_on_target(context, target, domain))"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        if not self._exceed_or_meet_threshold(results.count(True)):"},{"line_number":296,"context_line":"            LOG.warn(_LW(\u0027Consensus not reached for updating domain \u0027"},{"line_number":297,"context_line":"                         \u0027%(domain)s\u0027) % {\u0027domain\u0027: domain.name})"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_a7e64b13","line":295,"updated":"2015-03-25 21:06:01.000000000","message":"need matching log message for success here","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c496caeded28c7b7b8ca012e3f76c9163a552f","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        results \u003d []"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Create the domain on each of the Pool Targets"},{"line_number":361,"context_line":"        for target in self.pool.targets:"},{"line_number":362,"context_line":"            results.append("},{"line_number":363,"context_line":"                self._delete_domain_on_target(context, target, domain))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_27909b49","line":360,"updated":"2015-03-25 21:06:01.000000000","message":"as above","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"27cf74df2e3e414f2a97e2828d23aefc18bdad39","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        results \u003d []"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Create the domain on each of the Pool Targets"},{"line_number":361,"context_line":"        for target in self.pool.targets:"},{"line_number":362,"context_line":"            results.append("},{"line_number":363,"context_line":"                self._delete_domain_on_target(context, target, domain))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_0292ad4b","line":360,"in_reply_to":"1a6ced46_27909b49","updated":"2015-03-26 16:07:01.000000000","message":"Done","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"49c8acbb27f201a74c5b9a496f2f7a592eb742dc","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            results.append("},{"line_number":291,"context_line":"                self._update_domain_on_target(context, target, domain))"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        if not self._exceed_or_meet_threshold(results.count(True)):"},{"line_number":294,"context_line":"            LOG.warn(_LW(\u0027Consensus not reached for updating domain \u0027"},{"line_number":295,"context_line":"                         \u0027%(domain)s\u0027) % {\u0027domain\u0027: domain.name})"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da9b358b_e6c47841","line":293,"updated":"2015-03-30 12:05:22.000000000","message":"missing comment from PS:2 here","commit_id":"817114e1556704cc00ea60fcf934b90ae9bbd811"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"2f8770815271b6d402811ebb2e247b6c8a9b8eb4","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            results.append("},{"line_number":291,"context_line":"                self._update_domain_on_target(context, target, domain))"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        if not self._exceed_or_meet_threshold(results.count(True)):"},{"line_number":294,"context_line":"            LOG.warn(_LW(\u0027Consensus not reached for updating domain \u0027"},{"line_number":295,"context_line":"                         \u0027%(domain)s\u0027) % {\u0027domain\u0027: domain.name})"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da9b358b_bae2f3d3","line":293,"in_reply_to":"da9b358b_e6c47841","updated":"2015-03-30 18:41:53.000000000","message":"Done","commit_id":"817114e1556704cc00ea60fcf934b90ae9bbd811"}],"etc/designate/designate.conf.sample":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"a2c496caeded28c7b7b8ca012e3f76c9163a552f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"# example pool / server set up. Different backends will have different options."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"#[pool:794ccc2c-d751-44fe-b57f-8894c9f5c842]"},{"line_number":253,"context_line":"#nameservers \u003d 0f66b842-96c2-4189-93fc-1dc95a08b012"},{"line_number":254,"context_line":"#targets \u003d f26e0b32-736f-4f0a-831b-039a415c481e"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#[pool_nameserver:0f66b842-96c2-4189-93fc-1dc95a08b012]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a6ced46_448115fa","line":253,"updated":"2015-03-25 21:06:01.000000000","message":"can these 2 be prefixed with pool_ ?","commit_id":"2b1eb694eb289919e34f7587158ac27518376157"}]}