)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7f1441a40e57ca731d5575ee813a8c9623f1351f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Reduce the # of SQL queries during AXFRs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Adds a new SQL base function _get that does no object serialization,"},{"line_number":10,"context_line":"  or much of anything else"},{"line_number":11,"context_line":"- Adds a storage method to get all of the record data necessary for an"},{"line_number":12,"context_line":"  AXFR in one query"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa963961_f2779400","line":9,"updated":"2015-03-27 09:33:57.000000000","message":"s/_get/_select_raw/ :)","commit_id":"77f486e1a1fac5a07a81bae3e88d4bf218c573b5"}],"designate/mdns/handler.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7f1441a40e57ca731d5575ee813a8c9623f1351f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                rrset_id \u003d record[0]"},{"line_number":223,"context_line":"                rrtype \u003d str(record[1])"},{"line_number":224,"context_line":"                # gross"},{"line_number":225,"context_line":"                ttl \u003d int(record[2]) if record[2] is not None else 3600"},{"line_number":226,"context_line":"                name \u003d str(record[3])"},{"line_number":227,"context_line":"                rdata \u003d str(record[4])"},{"line_number":228,"context_line":"                current_rrset \u003d dns.rrset.from_text_list("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa963961_320dfc3e","line":225,"updated":"2015-03-27 09:33:57.000000000","message":"The `else 3600` should be `else domain.ttl`","commit_id":"77f486e1a1fac5a07a81bae3e88d4bf218c573b5"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7f1441a40e57ca731d5575ee813a8c9623f1351f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                # gross"},{"line_number":225,"context_line":"                ttl \u003d int(record[2]) if record[2] is not None else 3600"},{"line_number":226,"context_line":"                name \u003d str(record[3])"},{"line_number":227,"context_line":"                rdata \u003d str(record[4])"},{"line_number":228,"context_line":"                current_rrset \u003d dns.rrset.from_text_list("},{"line_number":229,"context_line":"                    name, ttl, dns.rdataclass.IN, rrtype, [rdata])"},{"line_number":230,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa963961_0d11b952","line":227,"updated":"2015-03-27 09:33:57.000000000","message":"Wow - I\u0027ve only just realized ALL out DB cols are UTF8 - What a waste.","commit_id":"77f486e1a1fac5a07a81bae3e88d4bf218c573b5"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7f1441a40e57ca731d5575ee813a8c9623f1351f","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if current_rrset is not None:"},{"line_number":241,"context_line":"                rrsets.append(current_rrset)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        return rrsets"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def _handle_axfr(self, request):"},{"line_number":246,"context_line":"        context \u003d request.environ[\u0027context\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa963961_ad4d2d74","line":243,"updated":"2015-03-27 09:33:57.000000000","message":"In order to handle greater than 65k responses, this will have to be reworked a little.. This should land first though, just a heads up :P","commit_id":"77f486e1a1fac5a07a81bae3e88d4bf218c573b5"}],"designate/sqlalchemy/base.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3e0cf38a813f35c4cde4bf230651c327c69229cc","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        return _set_object_from_model(obj, resultproxy.fetchone())"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    # This is just a dump, no obj serialization, no pagination required(?)"},{"line_number":334,"context_line":"    def _get(self, context, table, exc_notfound, criterion, query\u003dNone):"},{"line_number":335,"context_line":"        # Build the query"},{"line_number":336,"context_line":"        if query is None:"},{"line_number":337,"context_line":"            query \u003d select([table])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_585c92ed","line":334,"updated":"2015-03-25 22:14:41.000000000","message":"I *think* I\u0027d prefer to call this `_select_raw` rather than \"get\" (Get sounds like fetch 1 row to me!)","commit_id":"4d73334fcd3820937d81c2404f0f22ed491ee9f7"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bd7689155bc8099961e316f2aac14cf05be854aa","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        return _set_object_from_model(obj, resultproxy.fetchone())"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def _select_raw(self, context, table, exc_notfound, criterion, query\u003dNone):"},{"line_number":333,"context_line":"        # Build the query"},{"line_number":334,"context_line":"        if query is None:"},{"line_number":335,"context_line":"            query \u003d select([table])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9b358b_2919da88","line":332,"updated":"2015-03-31 15:08:03.000000000","message":"exc_notfound doesn\u0027t get used, can we remove it?","commit_id":"06519f37f53b1c7025a5554a386ea570db1a87b4"}],"designate/storage/impl_sqlalchemy/__init__.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7f1441a40e57ca731d5575ee813a8c9623f1351f","unresolved":false,"context_lines":[{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        return recordsets"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    # Does this need to be a wrapper around a private method?"},{"line_number":478,"context_line":"    def find_recordsets_axfr(self, context, criterion\u003dNone):"},{"line_number":479,"context_line":"        query \u003d None"},{"line_number":480,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa963961_b2790cff","line":477,"updated":"2015-03-27 09:33:57.000000000","message":"No, it doesn\u0027t have enough in common with anything else to bother IMO","commit_id":"77f486e1a1fac5a07a81bae3e88d4bf218c573b5"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"4075efcc7237a63315166e72af6e22c5609f55b0","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        query \u003d query.order_by(tables.recordsets.c.id)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        raw_rows \u003d self._select_raw("},{"line_number":495,"context_line":"            context, tables.recordsets, exceptions.RecordSetNotFound,"},{"line_number":496,"context_line":"            criterion, query)"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        return raw_rows"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_3f8c6c7e","line":495,"updated":"2015-03-31 15:25:17.000000000","message":"this will probably fail now, as we removed the not found exception","commit_id":"fe9f61e6e5d3466e4da107a3e6f8a7998b2279c5"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"66a256441d8e84c9b8d0dec33b9362df3d1303a8","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        query \u003d query.order_by(tables.recordsets.c.id)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        raw_rows \u003d self._select_raw("},{"line_number":495,"context_line":"            context, tables.recordsets, exceptions.RecordSetNotFound,"},{"line_number":496,"context_line":"            criterion, query)"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        return raw_rows"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9b358b_9f4c9843","line":495,"in_reply_to":"da9b358b_3f8c6c7e","updated":"2015-03-31 15:26:30.000000000","message":"dooh :)","commit_id":"fe9f61e6e5d3466e4da107a3e6f8a7998b2279c5"}]}